[sane-devel] Experimental lexmark backend inclusion in regular CVS

[Fred Odendaal]

Stef,

I've finished testing the experimental code on my X1185 and it works 
well. It is much slower than the current backend - probably due to 
shading calculations during the scanner reads. This may be optimized. I 
know there is a double buffer copy that I put in that can probably be 
removed. So,  I don't see anything that can't be worked around on the 
performance side.

The quality of the scans are much better with the experimental backend 
probably due to the shading, and the gain and offset calculations. Very 
nice!

The code changes look good too. I do have a small concern about name 
space collision with the use of functions named "rts88xx_*", but they 
are only used in a single file and aren't exported so shouldn't be a 
problem. If they are moved into a separate file as indicated in the code 
they may have to be renamed...

So, all in all I'd say the good outweighs the bad and we should move the 
experimental code into the main repository. I'd be interested to hear 
other opinions.

regards,
Fred Odendaal

St?phane VOLTZ wrote:
>   Hello,
>
>   the experimental lexmark backend is now quite in a good shape. It 
> brings 
> other the current backend:
>   - 2 new USB id support (Dell A920 and Lexmark X12xx models)
>   - add support for new X11xx models
>   - add arbitrary scan area selection
>   - offset and gain calibration
>   - software shading correction
>
>   It has been tested on A920, X1200 in USB1.1 and newer X1100 model. Only 
> the 
> orignal model supported by the current backend should need some testing.
>
>   So I'd like to know what everybody, and especially Fred, think about 
> moving 
> the experimental backend into regular CVS.
>
> Regards,
>   Stef
>
>   

[sane-devel] Experimental lexmark backend inclusion in regular CVS

[Stéphane VOLTZ]

Le jeudi 30 ao?t 2007, Fred Odendaal a ?crit?:
> Stef,
>
> I can't build the backend with the latest CVS checkout of the
>
> experimental code. Here is the error message I get:
> >  gcc -c -g -O2 -W -Wall -DHAVE_CONFIG_H -I. -I. -I../include
> > -I../include -D_REENTRANT -I/usr/include/gphoto2
> > -DPATH_SANE_CONFIG_DIR=/usr/local/etc/sane.d
> > -DPATH_SANE_DATA_DIR=/usr/local/share
> > -DPATH_SANE_LOCK_DIR=/usr/local/var/lock/sane -DV_MAJOR=1 -DV_MINOR=0
> > -DBACKEND_NAME=lexmark-x1100 -DLIBDIR=/usr/local/lib/sane
> > lexmark-x1100.c  -fPIC -DPIC -o .libs/lexmark-x1100.o
> > In file included from ../include/sane/sanei_backend.h:29,
> >  from lexmark-x1100.c:60:
> > ../include/sane/sanei_debug.h:88: error: expected '=', ',', ';', 'asm'
> > or '__attribute__' before '-' token
> > ../include/sane/sanei_debug.h:106: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > In file included from lexmark-x1100.c:60:
> > ../include/sane/sanei_backend.h:110: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:111: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:112: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:114: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:115: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:117: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:118: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:119: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:121: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:122: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:123: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:124: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > ../include/sane/sanei_backend.h:125: error: expected '=', ',', ';',
> > 'asm' or '__attribute__' before '-' token
> > lexmark-x1100.c: In function 'x1100_usb_bulk_write':
> > lexmark-x1100.c:186: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c:186: error: (Each undeclared identifier is reported
> > only once
> > lexmark-x1100.c:186: error: for each function it appears in.)
> > lexmark-x1100.c:186: warning: implicit declaration of function
> > 'x1100_call'
> > lexmark-x1100.c: In function 'x1100_usb_bulk_read':
> > lexmark-x1100.c:204: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_open_device':
> > lexmark-x1100.c:275: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_search_home_fwd':
> > lexmark-x1100.c:631: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_search_home_bwd':
> > lexmark-x1100.c:846: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'x1100_set_scan_area':
> > lexmark-x1100.c:1141: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_set_scan_regs':
> > lexmark-x1100.c:1483: error: 'Lexmark_Device' has no member named
> > 'pixel_height'
> > lexmark-x1100.c:1484: error: 'Lexmark_Device' has no member named
> > 'pixel_width'
> > lexmark-x1100.c:1489: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_start_scan':
> > lexmark-x1100.c:2259: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'sanei_lexmark_x1100_read_scan_data':
> > lexmark-x1100.c:2344: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'x1100_rewind':
> > lexmark-x1100.c:2516: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c:2575: error: 'Lexmark_Device' has no member named
> > 'pixel_height'
> > lexmark-x1100.c: In function 'read_buffer_init':
> > lexmark-x1100.c:2645: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'read_buffer_free':
> > lexmark-x1100.c:2679: error: 'sanei_debug_lexmark' undeclared (first
> > use in this function)
> > lexmark-x1100.c: In function 'read_buffer_bytes_available':
> > lex

[sane-devel] Experimental lexmark backend inclusion in regular CVS

[Stéphane VOLTZ]

Hello,

the experimental lexmark backend is now quite in a good shape. It 
brings 
other the current backend:
- 2 new USB id support (Dell A920 and Lexmark X12xx models)
- add support for new X11xx models
- add arbitrary scan area selection
- offset and gain calibration
- software shading correction

It has been tested on A920, X1200 in USB1.1 and newer X1100 model. Only 
the 
orignal model supported by the current backend should need some testing.

So I'd like to know what everybody, and especially Fred, think about 
moving 
the experimental backend into regular CVS.

Regards,
Stef