[sane-devel] New backend kodakaio for kodak AiO devices -adding tosane-backends

2012-06-30 Thread m. allan noah
I have committed this code to sane-backends git repo. Please sign up
for an alioth account, and request to join the sane project. Then I
can assign any future bug reports to you :)

allan

On Fri, Jun 29, 2012 at 4:09 PM, Paul Newall  wrote:
> Woops!
> This patch applies to the git version of 28 june 2012. (not july)
>
>
> - Original Message - From: "Paul Newall" 
> To: "m. allan noah" 
> Cc: 
> Sent: Friday, June 29, 2012 6:44 PM
>
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -adding
> tosane-backends
>
>
>> Regarding kodakaio
>> Following the advice from various people I have done the following:
>> Cut out all the unused code that I can find.
>> Removed most of the references to magicolor (since there's nothing in
>> common
>> with magicolor scanners)
>> Used the licence from magicolor, without the sane exception. Since I based
>> this backend on magicolor.
>> >
>> Regards,
>> Paul Newall
>>
>>
>> ----- Original Message ----- From: "m. allan noah" 
>> To: "Paul Newall" 
>> Cc: 
>> Sent: Thursday, June 21, 2012 10:21 PM
>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>> adding tosane-backends
>>
>>
>> Oh- and a compressed patch is just fine.
>>
>> allan
>>
>> On Thu, Jun 21, 2012 at 5:19 PM, m. allan noah  wrote:
>>>
>>> It can be a problem for later maintainers when the code contains
>>> unused vars/functions/etc. I would prune the backend down to the bare
>>> minimum, and rename everything so it is consistent.
>>>
>>> Clearly the license of magicolor applies to you now, though i wonder
>>> if the magicolor license is legitimate, based on its origin?
>>>
>>> allan
>>>
>>> On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall 
>>> wrote:
>>>>
>>>> kodakaio was based on magicolor. I have made the minimum changes to get
>>>> it
>>>> to work. That's why so many references to magicolor remain. I'm not sure
>>>> what the right approach is? If I have a function that is identical to
>>>> the
>>>> function in magicolor, it might be good for it to have the same name?
>>>> I guess if I have changed a function, it ought to have a new name.
>>>> The kodakaio scanners have nothing significant in common with the
>>>> magicolor
>>>> scanners.
>>>>
>>>> I chose not to use SNMP for auto detecting scanners because that would
>>>> mean
>>>> installing a version of the SNMP library that was not readily available
>>>> in
>>>> ubuntu repositories. I used cups instead. Since the kodak AiO devices
>>>> have
>>>> printers built in and can only print from linux using cups it's a good
>>>> assumption that users will generally have cups installed.
>>>> But I left the SNMP functions in the backend just in case the cups
>>>> method
>>>> did not work out OK.
>>>> I think it would be better if I removed them now.
>>>>
>>>> It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I
>>>> should
>>>> fix that.
>>>>
>>>> I have a couple of questions:
>>>> Regarding the SANE exception to the GPL. Is it generally desirable to
>>>> have
>>>> that exception for backends? it seems to be more likely to be relevant
>>>> for
>>>> the sanei libraries? In the case of kodakaio, it has lots of code from
>>>> magicolor, and magicolor does not have the exception, does that mean
>>>> that
>>>> kodakaio should not have the exception?
>>>>
>>>> Is it the right thing to do to keep attaching versions of my patch to
>>>> emails
>>>> to this mailing list? or would it be better to point people to a website
>>>> where they can download it?
>>>>
>>>> Thank you for all the comments,
>>>> Paul Newall
>>>>
>>>> - Original Message - From: "m. allan noah" 
>>>> To: "Paul Newall" 
>>>> Cc: 
>>>> Sent: Thursday, June 21, 2012 12:56 AM
>>>>
>>>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>>>> adding tosane-backends
>>>>
>>>>
>>>> Does kodak use SNMP? If not, it would be cleaner to remove that code.
>>>> Also, th

[sane-devel] New backend kodakaio for kodak AiO devices -adding tosane-backends

2012-06-29 Thread Paul Newall
Woops!
This patch applies to the git version of 28 june 2012. (not july)

- Original Message - 
From: "Paul Newall" 
To: "m. allan noah" 
Cc: 
Sent: Friday, June 29, 2012 6:44 PM
Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -adding 
tosane-backends


> Regarding kodakaio
> Following the advice from various people I have done the following:
> Cut out all the unused code that I can find.
> Removed most of the references to magicolor (since there's nothing in 
> common
> with magicolor scanners)
> Used the licence from magicolor, without the sane exception. Since I based
> this backend on magicolor.
> >
> Regards,
> Paul Newall
>
>
> - Original Message - 
> From: "m. allan noah" 
> To: "Paul Newall" 
> Cc: 
> Sent: Thursday, June 21, 2012 10:21 PM
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
> adding tosane-backends
>
>
> Oh- and a compressed patch is just fine.
>
> allan
>
> On Thu, Jun 21, 2012 at 5:19 PM, m. allan noah  wrote:
>> It can be a problem for later maintainers when the code contains
>> unused vars/functions/etc. I would prune the backend down to the bare
>> minimum, and rename everything so it is consistent.
>>
>> Clearly the license of magicolor applies to you now, though i wonder
>> if the magicolor license is legitimate, based on its origin?
>>
>> allan
>>
>> On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall 
>> wrote:
>>> kodakaio was based on magicolor. I have made the minimum changes to get
>>> it
>>> to work. That's why so many references to magicolor remain. I'm not sure
>>> what the right approach is? If I have a function that is identical to 
>>> the
>>> function in magicolor, it might be good for it to have the same name?
>>> I guess if I have changed a function, it ought to have a new name.
>>> The kodakaio scanners have nothing significant in common with the
>>> magicolor
>>> scanners.
>>>
>>> I chose not to use SNMP for auto detecting scanners because that would
>>> mean
>>> installing a version of the SNMP library that was not readily available
>>> in
>>> ubuntu repositories. I used cups instead. Since the kodak AiO devices
>>> have
>>> printers built in and can only print from linux using cups it's a good
>>> assumption that users will generally have cups installed.
>>> But I left the SNMP functions in the backend just in case the cups 
>>> method
>>> did not work out OK.
>>> I think it would be better if I removed them now.
>>>
>>> It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I
>>> should
>>> fix that.
>>>
>>> I have a couple of questions:
>>> Regarding the SANE exception to the GPL. Is it generally desirable to
>>> have
>>> that exception for backends? it seems to be more likely to be relevant
>>> for
>>> the sanei libraries? In the case of kodakaio, it has lots of code from
>>> magicolor, and magicolor does not have the exception, does that mean 
>>> that
>>> kodakaio should not have the exception?
>>>
>>> Is it the right thing to do to keep attaching versions of my patch to
>>> emails
>>> to this mailing list? or would it be better to point people to a website
>>> where they can download it?
>>>
>>> Thank you for all the comments,
>>> Paul Newall
>>>
>>> - Original Message - From: "m. allan noah" 
>>> To: "Paul Newall" 
>>> Cc: 
>>> Sent: Thursday, June 21, 2012 12:56 AM
>>>
>>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>>> adding tosane-backends
>>>
>>>
>>> Does kodak use SNMP? If not, it would be cleaner to remove that code.
>>> Also, this contains lots of references to magicolor in macro and
>>> variable names. Does it depend on magicolor? Are these machines
>>> derivatives of magicolor scanners?
>>>
>>> allan
>>>
>>> On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall 
>>> wrote:
>>>>
>>>> A new patch is attached.
>>>> This patch should modify the current git to add kodakaio for the kodak
>>>> ESP
>>>> , ESP Cnnn, and Hero series of AiOs
>>>>
>>>>
>>>> Regards,
>>>> Paul Newall
>>>>
>>>> - Original Message - From: "P

[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-29 Thread Paul Newall
Regarding kodakaio
Following the advice from various people I have done the following:
Cut out all the unused code that I can find.
Removed most of the references to magicolor (since there's nothing in common 
with magicolor scanners)
Used the licence from magicolor, without the sane exception. Since I based 
this backend on magicolor.
Made a new patch, which is attached. This patch applies to the git version 
of 28 july 2012.

Regards,
Paul Newall


- Original Message - 
From: "m. allan noah" 
To: "Paul Newall" 
Cc: 
Sent: Thursday, June 21, 2012 10:21 PM
Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - 
adding tosane-backends


Oh- and a compressed patch is just fine.

allan

On Thu, Jun 21, 2012 at 5:19 PM, m. allan noah  wrote:
> It can be a problem for later maintainers when the code contains
> unused vars/functions/etc. I would prune the backend down to the bare
> minimum, and rename everything so it is consistent.
>
> Clearly the license of magicolor applies to you now, though i wonder
> if the magicolor license is legitimate, based on its origin?
>
> allan
>
> On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall  
> wrote:
>> kodakaio was based on magicolor. I have made the minimum changes to get 
>> it
>> to work. That's why so many references to magicolor remain. I'm not sure
>> what the right approach is? If I have a function that is identical to the
>> function in magicolor, it might be good for it to have the same name?
>> I guess if I have changed a function, it ought to have a new name.
>> The kodakaio scanners have nothing significant in common with the 
>> magicolor
>> scanners.
>>
>> I chose not to use SNMP for auto detecting scanners because that would 
>> mean
>> installing a version of the SNMP library that was not readily available 
>> in
>> ubuntu repositories. I used cups instead. Since the kodak AiO devices 
>> have
>> printers built in and can only print from linux using cups it's a good
>> assumption that users will generally have cups installed.
>> But I left the SNMP functions in the backend just in case the cups method
>> did not work out OK.
>> I think it would be better if I removed them now.
>>
>> It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I 
>> should
>> fix that.
>>
>> I have a couple of questions:
>> Regarding the SANE exception to the GPL. Is it generally desirable to 
>> have
>> that exception for backends? it seems to be more likely to be relevant 
>> for
>> the sanei libraries? In the case of kodakaio, it has lots of code from
>> magicolor, and magicolor does not have the exception, does that mean that
>> kodakaio should not have the exception?
>>
>> Is it the right thing to do to keep attaching versions of my patch to 
>> emails
>> to this mailing list? or would it be better to point people to a website
>> where they can download it?
>>
>> Thank you for all the comments,
>> Paul Newall
>>
>> - Original Message - From: "m. allan noah" 
>> To: "Paul Newall" 
>> Cc: 
>> Sent: Thursday, June 21, 2012 12:56 AM
>>
>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>> adding tosane-backends
>>
>>
>> Does kodak use SNMP? If not, it would be cleaner to remove that code.
>> Also, this contains lots of references to magicolor in macro and
>> variable names. Does it depend on magicolor? Are these machines
>> derivatives of magicolor scanners?
>>
>> allan
>>
>> On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall  
>> wrote:
>>>
>>> A new patch is attached.
>>> This patch should modify the current git to add kodakaio for the kodak 
>>> ESP
>>> , ESP Cnnn, and Hero series of AiOs
>>>
>>>
>>> Regards,
>>> Paul Newall
>>>
>>> ----- Original Message - From: "Paul Newall" 
>>> 
>>> To: 
>>> Sent: Sunday, June 17, 2012 9:21 PM
>>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>>> adding tosane-backends
>>>
>>>
>>>
>>>> I had a few suggestions for improvements. In a few days I will made a 
>>>> new
>>>> version of the patch.
>>>> Any other suggestions would be gratefully received.
>>>>
>>>> Regards,
>>>> Paul Newall
>>>>
>>>> - Original Message - From: "Paul Newall" 
>>>> 
>>>> To: 
>>>> Sent:

[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-22 Thread Olaf Meeuwissen
Reinhold Kainhofer  writes:

> On 2012-06-21 23:19, m. allan noah wrote:
>> Clearly the license of magicolor applies to you now, though i wonder
>> if the magicolor license is legitimate, based on its origin?

The epson backend, from which epson2 was forked, clearly states one has
the right to delete the exception in epson.[ch].

  If you write modifications of your own for SANE, it is your choice
  whether to permit this exception to apply to your modifications.
  If you do not wish that, delete this exception notice.

Unfortunately, the epson_{scsi,usb}.[ch] files have no license blurb but
should probably be assumed to be under the same terms.  The epson2
backend only kept the epson_scsi.[ch] files and did not add any license
blurb.  Whether or not these files may be used with a GPL-only backend
remains a question.

> Sorry, I don't understand which concerns you have. The magicolor
> backend is a fork of the GPL'ed epson2 backend, adjusted to
> magicolor-specific functionality and scanner protocol.
> The magicolor backend is under the GPL, too, so I don't think there
> should be any concern as to the ligitimacy of the license or the
> backend.

The magicolor backend seems to have only "copied" epson2.c so can be
argued to be in the clear.  As a matter of opinion, I would hardly call
it a fork.  Looks like you just kept the general structure of the file
and replaced the body of just about every function.

IANAL but hope this helps anyways,
-- 
Olaf Meeuwissen, LPIC-2   FLOSS Engineer -- AVASYS CORPORATION
FSF Associate Member #1962   Help support software freedom
 http://www.fsf.org/jf?referrer=1962



[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread Reinhold Kainhofer
On 2012-06-21 23:19, m. allan noah wrote:
> Clearly the license of magicolor applies to you now, though i wonder
> if the magicolor license is legitimate, based on its origin?

Sorry, I don't understand which concerns you have. The magicolor backend 
is a fork of the GPL'ed epson2 backend, adjusted to magicolor-specific 
functionality and scanner protocol.
The magicolor backend is under the GPL, too, so I don't think there 
should be any concern as to the ligitimacy of the license or the backend.

Cheers,
Reinhold

-- 
--
Reinhold Kainhofer, reinhold at kainhofer.com, http://reinhold.kainhofer.com/
  * Financial&  Actuarial Math., Vienna Univ. of Technology, Austria
  * http://www.fam.tuwien.ac.at/, DVR: 0005886
  * LilyPond, Music typesetting, http://www.lilypond.org




[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread Reinhold Kainhofer
On 2012-06-21 23:07, Paul Newall wrote:
> kodakaio was based on magicolor. I have made the minimum changes to 
> get it to work. That's why so many references to magicolor remain. I'm 
> not sure what the right approach is? If I have a function that is 
> identical to the function in magicolor, it might be good for it to 
> have the same name?
> I guess if I have changed a function, it ought to have a new name.
> The kodakaio scanners have nothing significant in common with the 
> magicolor scanners.

When I wrote the magicolor backend, I took the epson2 backend and did a 
huge search-and-replace to get rid of everything epson-specific and 
instead use magicolor-specific names (e.g. *_mc_* etc.)

Cheers,
Reinhold

-- 
--
Reinhold Kainhofer, reinhold at kainhofer.com, http://reinhold.kainhofer.com/
  * Financial&  Actuarial Math., Vienna Univ. of Technology, Austria
  * http://www.fam.tuwien.ac.at/, DVR: 0005886
  * LilyPond, Music typesetting, http://www.lilypond.org




[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread Paul Newall
kodakaio was based on magicolor. I have made the minimum changes to get it 
to work. That's why so many references to magicolor remain. I'm not sure 
what the right approach is? If I have a function that is identical to the 
function in magicolor, it might be good for it to have the same name?
I guess if I have changed a function, it ought to have a new name.
The kodakaio scanners have nothing significant in common with the magicolor 
scanners.

I chose not to use SNMP for auto detecting scanners because that would mean 
installing a version of the SNMP library that was not readily available in 
ubuntu repositories. I used cups instead. Since the kodak AiO devices have 
printers built in and can only print from linux using cups it's a good 
assumption that users will generally have cups installed.
But I left the SNMP functions in the backend just in case the cups method 
did not work out OK.
I think it would be better if I removed them now.

It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I should 
fix that.

I have a couple of questions:
Regarding the SANE exception to the GPL. Is it generally desirable to have 
that exception for backends? it seems to be more likely to be relevant for 
the sanei libraries? In the case of kodakaio, it has lots of code from 
magicolor, and magicolor does not have the exception, does that mean that 
kodakaio should not have the exception?

Is it the right thing to do to keep attaching versions of my patch to emails 
to this mailing list? or would it be better to point people to a website 
where they can download it?

Thank you for all the comments,
Paul Newall

- Original Message - 
From: "m. allan noah" 
To: "Paul Newall" 
Cc: 
Sent: Thursday, June 21, 2012 12:56 AM
Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - 
adding tosane-backends


Does kodak use SNMP? If not, it would be cleaner to remove that code.
Also, this contains lots of references to magicolor in macro and
variable names. Does it depend on magicolor? Are these machines
derivatives of magicolor scanners?

allan

On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall  wrote:
> A new patch is attached.
> This patch should modify the current git to add kodakaio for the kodak ESP
> , ESP Cnnn, and Hero series of AiOs
>
>
> Regards,
> Paul Newall
>
> - Original Message - From: "Paul Newall" 
> To: 
> Sent: Sunday, June 17, 2012 9:21 PM
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
> adding tosane-backends
>
>
>
>> I had a few suggestions for improvements. In a few days I will made a new
>> version of the patch.
>> Any other suggestions would be gratefully received.
>>
>> Regards,
>> Paul Newall
>>
>> ----- Original Message ----- From: "Paul Newall" 
>> To: 
>> Sent: Sunday, June 17, 2012 12:10 AM
>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding
>> tosane-backends
>>
>>
>>> I have this backend (kodakaio) working.
>>> And tested by a few users, using a cut down version of sane-backends.
>>> Now I have made a patch for the git version cloned today from
>>> git://git.debian.org/sane/sane-backends.git
>>> The patch is attached
>>> Does anyone with write access to git want to add this backend?
>>>
>>> Summary of the changes I made:
>>> Added the backend: kodakaio.c .h .conf .man .desc
>>> Modified: configure.in (added detection of a cups installation since 
>>> this
>>> is
>>> used for autodetection on the network)
>>> Modified: makefile.am in backends and in docs. Modified: authors,
>>> dll.conf
>>>
>>> I think that's all the changes.
>>>
>>> Regards,
>>> Paul Newall
>>>
>>>
>>>
>>
>>
>>
>> 
>>
>>
>>> --
>>> sane-devel mailing list: sane-devel at lists.alioth.debian.org
>>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
>>> Unsubscribe: Send mail with subject "unsubscribe your_password"
>>> to sane-devel-request at lists.alioth.debian.org
>>
>>
>
> --
> sane-devel mailing list: sane-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
> Unsubscribe: Send mail with subject "unsubscribe your_password"
> to sane-devel-request at lists.alioth.debian.org



-- 
"The truth is an offense, but not a sin" 




[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread m. allan noah
On Thu, Jun 21, 2012 at 5:32 PM, Reinhold Kainhofer
 wrote:
> On 2012-06-21 23:19, m. allan noah wrote:
>>
>> Clearly the license of magicolor applies to you now, though i wonder
>> if the magicolor license is legitimate, based on its origin?
>
>
> Sorry, I don't understand which concerns you have. The magicolor backend is
> a fork of the GPL'ed epson2 backend, adjusted to magicolor-specific
> functionality and scanner protocol.
> The magicolor backend is under the GPL, too, so I don't think there should
> be any concern as to the ligitimacy of the license or the backend.

Yes- but epson2 claims to be based on epson, which was GPL + SANE
exception. Perhaps epson2 has a license problem, though I hate to
point it out, since I am unhappy with the wording of the exception.

allan

> --
> --
> Reinhold Kainhofer, reinhold at kainhofer.com, http://reinhold.kainhofer.com/
> ?* Financial& ?Actuarial Math., Vienna Univ. of Technology, Austria
> ?* http://www.fam.tuwien.ac.at/, DVR: 0005886
> ?* LilyPond, Music typesetting, http://www.lilypond.org
>



-- 
"The truth is an offense, but not a sin"



[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread m. allan noah
Oh- and a compressed patch is just fine.

allan

On Thu, Jun 21, 2012 at 5:19 PM, m. allan noah  wrote:
> It can be a problem for later maintainers when the code contains
> unused vars/functions/etc. I would prune the backend down to the bare
> minimum, and rename everything so it is consistent.
>
> Clearly the license of magicolor applies to you now, though i wonder
> if the magicolor license is legitimate, based on its origin?
>
> allan
>
> On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall  
> wrote:
>> kodakaio was based on magicolor. I have made the minimum changes to get it
>> to work. That's why so many references to magicolor remain. I'm not sure
>> what the right approach is? If I have a function that is identical to the
>> function in magicolor, it might be good for it to have the same name?
>> I guess if I have changed a function, it ought to have a new name.
>> The kodakaio scanners have nothing significant in common with the magicolor
>> scanners.
>>
>> I chose not to use SNMP for auto detecting scanners because that would mean
>> installing a version of the SNMP library that was not readily available in
>> ubuntu repositories. I used cups instead. Since the kodak AiO devices have
>> printers built in and can only print from linux using cups it's a good
>> assumption that users will generally have cups installed.
>> But I left the SNMP functions in the backend just in case the cups method
>> did not work out OK.
>> I think it would be better if I removed them now.
>>
>> It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I should
>> fix that.
>>
>> I have a couple of questions:
>> Regarding the SANE exception to the GPL. Is it generally desirable to have
>> that exception for backends? it seems to be more likely to be relevant for
>> the sanei libraries? In the case of kodakaio, it has lots of code from
>> magicolor, and magicolor does not have the exception, does that mean that
>> kodakaio should not have the exception?
>>
>> Is it the right thing to do to keep attaching versions of my patch to emails
>> to this mailing list? or would it be better to point people to a website
>> where they can download it?
>>
>> Thank you for all the comments,
>> Paul Newall
>>
>> - Original Message - From: "m. allan noah" 
>> To: "Paul Newall" 
>> Cc: 
>> Sent: Thursday, June 21, 2012 12:56 AM
>>
>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>> adding tosane-backends
>>
>>
>> Does kodak use SNMP? If not, it would be cleaner to remove that code.
>> Also, this contains lots of references to magicolor in macro and
>> variable names. Does it depend on magicolor? Are these machines
>> derivatives of magicolor scanners?
>>
>> allan
>>
>> On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall  
>> wrote:
>>>
>>> A new patch is attached.
>>> This patch should modify the current git to add kodakaio for the kodak ESP
>>> , ESP Cnnn, and Hero series of AiOs
>>>
>>>
>>> Regards,
>>> Paul Newall
>>>
>>> - Original Message - From: "Paul Newall" 
>>> To: 
>>> Sent: Sunday, June 17, 2012 9:21 PM
>>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>>> adding tosane-backends
>>>
>>>
>>>
>>>> I had a few suggestions for improvements. In a few days I will made a new
>>>> version of the patch.
>>>> Any other suggestions would be gratefully received.
>>>>
>>>> Regards,
>>>> Paul Newall
>>>>
>>>> - Original Message - From: "Paul Newall" >>> ntlworld.com>
>>>> To: 
>>>> Sent: Sunday, June 17, 2012 12:10 AM
>>>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding
>>>> tosane-backends
>>>>
>>>>
>>>>> I have this backend (kodakaio) working.
>>>>> And tested by a few users, using a cut down version of sane-backends.
>>>>> Now I have made a patch for the git version cloned today from
>>>>> git://git.debian.org/sane/sane-backends.git
>>>>> The patch is attached
>>>>> Does anyone with write access to git want to add this backend?
>>>>>
>>>>> Summary of the changes I made:
>>>>> Added the backend: kodakaio.c .h .conf .man .desc
>>>>> Modified: configure.in (added dete

[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread m. allan noah
It can be a problem for later maintainers when the code contains
unused vars/functions/etc. I would prune the backend down to the bare
minimum, and rename everything so it is consistent.

Clearly the license of magicolor applies to you now, though i wonder
if the magicolor license is legitimate, based on its origin?

allan

On Thu, Jun 21, 2012 at 5:07 PM, Paul Newall  wrote:
> kodakaio was based on magicolor. I have made the minimum changes to get it
> to work. That's why so many references to magicolor remain. I'm not sure
> what the right approach is? If I have a function that is identical to the
> function in magicolor, it might be good for it to have the same name?
> I guess if I have changed a function, it ought to have a new name.
> The kodakaio scanners have nothing significant in common with the magicolor
> scanners.
>
> I chose not to use SNMP for auto detecting scanners because that would mean
> installing a version of the SNMP library that was not readily available in
> ubuntu repositories. I used cups instead. Since the kodak AiO devices have
> printers built in and can only print from linux using cups it's a good
> assumption that users will generally have cups installed.
> But I left the SNMP functions in the backend just in case the cups method
> did not work out OK.
> I think it would be better if I removed them now.
>
> It seems I forgot to add kodakaio to ALL_BACKENDS in configure, so I should
> fix that.
>
> I have a couple of questions:
> Regarding the SANE exception to the GPL. Is it generally desirable to have
> that exception for backends? it seems to be more likely to be relevant for
> the sanei libraries? In the case of kodakaio, it has lots of code from
> magicolor, and magicolor does not have the exception, does that mean that
> kodakaio should not have the exception?
>
> Is it the right thing to do to keep attaching versions of my patch to emails
> to this mailing list? or would it be better to point people to a website
> where they can download it?
>
> Thank you for all the comments,
> Paul Newall
>
> - Original Message - From: "m. allan noah" 
> To: "Paul Newall" 
> Cc: 
> Sent: Thursday, June 21, 2012 12:56 AM
>
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
> adding tosane-backends
>
>
> Does kodak use SNMP? If not, it would be cleaner to remove that code.
> Also, this contains lots of references to magicolor in macro and
> variable names. Does it depend on magicolor? Are these machines
> derivatives of magicolor scanners?
>
> allan
>
> On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall  
> wrote:
>>
>> A new patch is attached.
>> This patch should modify the current git to add kodakaio for the kodak ESP
>> nnnn, ESP Cnnn, and Hero series of AiOs
>>
>>
>> Regards,
>> Paul Newall
>>
>> - Original Message - From: "Paul Newall" 
>> To: 
>> Sent: Sunday, June 17, 2012 9:21 PM
>> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
>> adding tosane-backends
>>
>>
>>
>>> I had a few suggestions for improvements. In a few days I will made a new
>>> version of the patch.
>>> Any other suggestions would be gratefully received.
>>>
>>> Regards,
>>> Paul Newall
>>>
>>> - Original Message - From: "Paul Newall" 
>>> To: 
>>> Sent: Sunday, June 17, 2012 12:10 AM
>>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding
>>> tosane-backends
>>>
>>>
>>>> I have this backend (kodakaio) working.
>>>> And tested by a few users, using a cut down version of sane-backends.
>>>> Now I have made a patch for the git version cloned today from
>>>> git://git.debian.org/sane/sane-backends.git
>>>> The patch is attached
>>>> Does anyone with write access to git want to add this backend?
>>>>
>>>> Summary of the changes I made:
>>>> Added the backend: kodakaio.c .h .conf .man .desc
>>>> Modified: configure.in (added detection of a cups installation since
>>>> this
>>>> is
>>>> used for autodetection on the network)
>>>> Modified: makefile.am in backends and in docs. Modified: authors,
>>>> dll.conf
>>>>
>>>> I think that's all the changes.
>>>>
>>>> Regards,
>>>> Paul Newall
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>> -

[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-21 Thread stef
Le 21/06/2012 00:41, Paul Newall a ?crit :
> A new patch is attached.
> This patch should modify the current git to add kodakaio for the kodak 
> ESP , ESP Cnnn, and Hero series of AiOs
>
> Regards,
> Paul Newall
>
> - Original Message - From: "Paul Newall" 
> To: 
> Sent: Sunday, June 17, 2012 9:21 PM
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - 
> adding tosane-backends
>
>
>> I had a few suggestions for improvements. In a few days I will made a 
>> new version of the patch.
>> Any other suggestions would be gratefully received.
>>
>> Regards,
>> Paul Newall
>>
>> - Original Message ----- From: "Paul Newall" 
>> 
>> To: 
>> Sent: Sunday, June 17, 2012 12:10 AM
>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - 
>> adding tosane-backends
>>
>>
>>> I have this backend (kodakaio) working.
>>> And tested by a few users, using a cut down version of sane-backends.
>>> Now I have made a patch for the git version cloned today from
>>> git://git.debian.org/sane/sane-backends.git
>>> The patch is attached
>>> Does anyone with write access to git want to add this backend?
>>>
>>> Summary of the changes I made:
>>> Added the backend: kodakaio.c  .h  .conf  .man .desc
>>> Modified: configure.in (added detection of a cups installation since 
>>> this is
>>> used for autodetection on the network)
>>> Modified: makefile.am in backends and in docs. Modified: authors, 
>>> dll.conf
>>>
>>> I think that's all the changes.
>>>
>>> Regards,
>>> Paul Newall
>>>
>>>
>>>
>>
>>
>> 
>>  
>>
>>
>>
>>> -- 
>>> sane-devel mailing list: sane-devel at lists.alioth.debian.org
>>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
>>> Unsubscribe: Send mail with subject "unsubscribe your_password"
>>> to sane-devel-request at lists.alioth.debian.org
>>
>
>
 Hello,

 kodakaio is not added to ALL_BACKENDS in configure, is it on purpose ?

Regards,
 Stef




[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-20 Thread Paul Newall
A new patch is attached.
This patch should modify the current git to add kodakaio for the kodak ESP 
, ESP Cnnn, and Hero series of AiOs

Regards,
Paul Newall

- Original Message - 
From: "Paul Newall" 
To: 
Sent: Sunday, June 17, 2012 9:21 PM
Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices - 
adding tosane-backends


>I had a few suggestions for improvements. In a few days I will made a new 
>version of the patch.
> Any other suggestions would be gratefully received.
>
> Regards,
> Paul Newall
>
> - Original Message - 
> From: "Paul Newall" 
> To: 
> Sent: Sunday, June 17, 2012 12:10 AM
> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding 
> tosane-backends
>
>
>>I have this backend (kodakaio) working.
>> And tested by a few users, using a cut down version of sane-backends.
>> Now I have made a patch for the git version cloned today from
>> git://git.debian.org/sane/sane-backends.git
>> The patch is attached
>> Does anyone with write access to git want to add this backend?
>>
>> Summary of the changes I made:
>> Added the backend: kodakaio.c  .h  .conf  .man .desc
>> Modified: configure.in (added detection of a cups installation since this 
>> is
>> used for autodetection on the network)
>> Modified: makefile.am in backends and in docs. Modified: authors, 
>> dll.conf
>>
>> I think that's all the changes.
>>
>> Regards,
>> Paul Newall
>>
>>
>>
>
>
> 
>
>
>> -- 
>> sane-devel mailing list: sane-devel at lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
>> Unsubscribe: Send mail with subject "unsubscribe your_password"
>> to sane-devel-request at lists.alioth.debian.org
> 
-- next part --
A non-text attachment was scrubbed...
Name: kodakaio-patch2.4.1
Type: application/octet-stream
Size: 154918 bytes
Desc: not available
URL: 
<http://lists.alioth.debian.org/pipermail/sane-devel/attachments/20120620/60b5acde/attachment-0001.obj>


[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-20 Thread m. allan noah
Does kodak use SNMP? If not, it would be cleaner to remove that code.
Also, this contains lots of references to magicolor in macro and
variable names. Does it depend on magicolor? Are these machines
derivatives of magicolor scanners?

allan

On Wed, Jun 20, 2012 at 6:41 PM, Paul Newall  wrote:
> A new patch is attached.
> This patch should modify the current git to add kodakaio for the kodak ESP
> , ESP Cnnn, and Hero series of AiOs
>
>
> Regards,
> Paul Newall
>
> - Original Message - From: "Paul Newall" 
> To: 
> Sent: Sunday, June 17, 2012 9:21 PM
> Subject: Re: [sane-devel] New backend kodakaio for kodak AiO devices -
> adding tosane-backends
>
>
>
>> I had a few suggestions for improvements. In a few days I will made a new
>> version of the patch.
>> Any other suggestions would be gratefully received.
>>
>> Regards,
>> Paul Newall
>>
>> - Original Message - From: "Paul Newall" 
>> To: 
>> Sent: Sunday, June 17, 2012 12:10 AM
>> Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding
>> tosane-backends
>>
>>
>>> I have this backend (kodakaio) working.
>>> And tested by a few users, using a cut down version of sane-backends.
>>> Now I have made a patch for the git version cloned today from
>>> git://git.debian.org/sane/sane-backends.git
>>> The patch is attached
>>> Does anyone with write access to git want to add this backend?
>>>
>>> Summary of the changes I made:
>>> Added the backend: kodakaio.c ?.h ?.conf ?.man .desc
>>> Modified: configure.in (added detection of a cups installation since this
>>> is
>>> used for autodetection on the network)
>>> Modified: makefile.am in backends and in docs. Modified: authors,
>>> dll.conf
>>>
>>> I think that's all the changes.
>>>
>>> Regards,
>>> Paul Newall
>>>
>>>
>>>
>>
>>
>>
>> 
>>
>>
>>> --
>>> sane-devel mailing list: sane-devel at lists.alioth.debian.org
>>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
>>> Unsubscribe: Send mail with subject "unsubscribe your_password"
>>> ? ? ? ? ? ?to sane-devel-request at lists.alioth.debian.org
>>
>>
>
> --
> sane-devel mailing list: sane-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
> Unsubscribe: Send mail with subject "unsubscribe your_password"
> ? ? ? ? ? ? to sane-devel-request at lists.alioth.debian.org



-- 
"The truth is an offense, but not a sin"



[sane-devel] New backend kodakaio for kodak AiO devices - adding tosane-backends

2012-06-17 Thread Paul Newall
I had a few suggestions for improvements. In a few days I will made a new 
version of the patch.
Any other suggestions would be gratefully received.

Regards,
Paul Newall

- Original Message - 
From: "Paul Newall" 
To: 
Sent: Sunday, June 17, 2012 12:10 AM
Subject: [sane-devel] New backend kodakaio for kodak AiO devices - adding 
tosane-backends


>I have this backend (kodakaio) working.
> And tested by a few users, using a cut down version of sane-backends.
> Now I have made a patch for the git version cloned today from
> git://git.debian.org/sane/sane-backends.git
> The patch is attached
> Does anyone with write access to git want to add this backend?
>
> Summary of the changes I made:
> Added the backend: kodakaio.c  .h  .conf  .man .desc
> Modified: configure.in (added detection of a cups installation since this 
> is
> used for autodetection on the network)
> Modified: makefile.am in backends and in docs. Modified: authors, dll.conf
>
> I think that's all the changes.
>
> Regards,
> Paul Newall
>
>
>





> -- 
> sane-devel mailing list: sane-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
> Unsubscribe: Send mail with subject "unsubscribe your_password"
> to sane-devel-request at lists.alioth.debian.org