Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

m. allan noah writes:

> On Thu, Sep 24, 2015 at 9:22 AM, Olaf Meeuwissen
>  wrote:
>>
>> Anyway, please consider merging the pu/ branches at my GitLab clone.
>
> These all made sense to me, so I pushed them up. Thanks for doing the
> legwork here.

Thanks.  I've removed the branches from my GitLab clone.
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join


-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[m. allan noah]

On Thu, Sep 24, 2015 at 9:22 AM, Olaf Meeuwissen
 wrote:
> Hi all,
>
> Olaf Meeuwissen writes:
>
>> m. allan noah writes:
>>
>>> On Sat, Sep 19, 2015 at 11:23 PM, Olaf Meeuwissen
>>>  wrote:
>>>
 Sorry about dropping the ball on the musl inb() outb() branch.  I had
 meant to commit configure.in but seem to have committed configure :-(
>>>
>>> Do you have a version which uses AC_* macros instead of what I did? I
>>> think that would be cleaner.
>>
>> I just applied the patch that Luiz mentioned on the mailing list[1].
>> Looking at that patch again I guess it'd be better to replace your stuff
>> with what's in the patch.  I've put up a pu/fixup-inb-outb-changes
>> branch to do just that[2].
>>
>>  [1] 
>> https://raw.githubusercontent.com/luizluca/openwrt-packages/e11fbf71f7f437c64d18929e7895dbaafa8c3293/utils/sane-backends/patches/020-inb_outb.patch
>>  [2] https://gitlab.com/sane-project/backends/branches
>
> In addition to the above, I just pushed pu/fix-new-compiler-warnings.
> It fixes a few handfuls of new warnings (when compared against a log of
> building 1.0.24 with the same settings).  It doesn't fix all of them as
> I wasn't sure what to do with a number of the new warnings.
>
> One, in sanei_ir.c, deserves some attention as it produces potentially
> undefined behaviour.  It's really the same issue as reported in 311857,
> which I recently reopened.
>
>   ../../../sanei/sanei_ir.c:481:11: warning: multiple unsequenced 
> modifications to 'outi' [-Wunsequenced]
>  *outi++ = *outi++ >> is;
>
> The two increments may occur in any given order, IIUC[3].
>
>  [3] http://c-faq.com/expr/seqpoints.html
>
> The rest are more benign: unused function arguments, self-assignments
> (to work around unused argument warnings ;-), conversions between enums
> that are not compatible and conditionals that are constant (because
> SANE_FRAME_JPEG is not a member of the SANE_Frame enum range).
>
> Anyway, please consider merging the pu/ branches at my GitLab clone.

These all made sense to me, so I pushed them up. Thanks for doing the
legwork here.

allan
-- 
"well, I stand up next to a mountain- and I chop it down with the edge
of my hand"

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Johannes Meixner]

Hello,

On Sep 24 22:22 Olaf Meeuwissen wrote (excerpt):

One, in sanei_ir.c, deserves some attention as it produces potentially
undefined behaviour.  It's really the same issue as reported in 311857,
which I recently reopened.

 ../../../sanei/sanei_ir.c:481:11: warning: multiple unsequenced modifications 
to 'outi' [-Wunsequenced]
*outi++ = *outi++ >> is;

The two increments may occur in any given order, IIUC[3].

[3] http://c-faq.com/expr/seqpoints.html


In general I would even demand that nowadays such kind
of fancy coding stlye should no longer be done at all.

With nowadays compiler optimizations it does not matter
if one writes

  y = x++ * 2;

or

  y = x * 2;
  x++;

The former is selfish and oversophisticated coding.
In this case it is a mix-up of two separated things.

The latter is altruistic and explicit coding that
makes it obvious for others what actually is meant.

If the two separated things are meant as one statement
one might (ab)use the "one statement per line" rule

  y = x * 2; x++;

which is still much more obvious than "y = x++ * 2;".

Of course everybody understands what "y = x++ * 2;" means.
This is only used here as a simple example.


Kind Regards
Johannes Meixner
--
SUSE LINUX GmbH - GF: Felix Imendoerffer, Jane Smithard,
Graham Norton - HRB 21284 (AG Nuernberg)


--
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Hi all,

Olaf Meeuwissen writes:

> m. allan noah writes:
>
>> On Sat, Sep 19, 2015 at 11:23 PM, Olaf Meeuwissen
>>  wrote:
>>
>>> Sorry about dropping the ball on the musl inb() outb() branch.  I had
>>> meant to commit configure.in but seem to have committed configure :-(
>>
>> Do you have a version which uses AC_* macros instead of what I did? I
>> think that would be cleaner.
>
> I just applied the patch that Luiz mentioned on the mailing list[1].
> Looking at that patch again I guess it'd be better to replace your stuff
> with what's in the patch.  I've put up a pu/fixup-inb-outb-changes
> branch to do just that[2].
>
>  [1] 
> https://raw.githubusercontent.com/luizluca/openwrt-packages/e11fbf71f7f437c64d18929e7895dbaafa8c3293/utils/sane-backends/patches/020-inb_outb.patch
>  [2] https://gitlab.com/sane-project/backends/branches

In addition to the above, I just pushed pu/fix-new-compiler-warnings.
It fixes a few handfuls of new warnings (when compared against a log of
building 1.0.24 with the same settings).  It doesn't fix all of them as
I wasn't sure what to do with a number of the new warnings.

One, in sanei_ir.c, deserves some attention as it produces potentially
undefined behaviour.  It's really the same issue as reported in 311857,
which I recently reopened.

  ../../../sanei/sanei_ir.c:481:11: warning: multiple unsequenced modifications 
to 'outi' [-Wunsequenced]
 *outi++ = *outi++ >> is;

The two increments may occur in any given order, IIUC[3].

 [3] http://c-faq.com/expr/seqpoints.html

The rest are more benign: unused function arguments, self-assignments
(to work around unused argument warnings ;-), conversions between enums
that are not compatible and conditionals that are constant (because
SANE_FRAME_JPEG is not a member of the SANE_Frame enum range).

Anyway, please consider merging the pu/ branches at my GitLab clone.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

m. allan noah writes:

> On Sat, Sep 19, 2015 at 11:23 PM, Olaf Meeuwissen
>  wrote:
>> Hi Allan,
>>
>> m. allan noah writes:
>>
>>> I have just pushed all these changes, and a few more to git repo. I
>>> have a few more minor bug fixes assigned to me that will go up in a
>>> few hours.
>>
>> Many thanks!  I've checked all my branches against 87bfd53, removed all
>> branches that are in from my GitLab clone and closed any related bug
>> reports.  Hope I didn't miss any.
>>
>> Talking about missing things, it seems you forgot about the Hungarian
>> translations.  There's a pu/add-hu.po-313073 branch on my GitLab clone
>> that has not been merged yet.  Any reason this didn't get in?
>
> Hmm- i missed that one. It is pushed now.

Thanks.  Closed the ticket and removed my pu/ branch.

>> Sorry about dropping the ball on the musl inb() outb() branch.  I had
>> meant to commit configure.in but seem to have committed configure :-(
>
> Do you have a version which uses AC_* macros instead of what I did? I
> think that would be cleaner.

I just applied the patch that Luiz mentioned on the mailing list[1].
Looking at that patch again I guess it'd be better to replace your stuff
with what's in the patch.  I've put up a pu/fixup-inb-outb-changes
branch to do just that[2].

 [1] 
https://raw.githubusercontent.com/luizluca/openwrt-packages/e11fbf71f7f437c64d18929e7895dbaafa8c3293/utils/sane-backends/patches/020-inb_outb.patch
 [2] https://gitlab.com/sane-project/backends/branches

>> After I pushed (what became) 9dd31f9 I had second thoughts when I
>> recalled that there was something special with lists constraints.
>> Cross-checking with the spec, it turns out my changeset is okay.
>
> Yes- I stared at that code for quite awhile. I think the new code is
> more clear, so even if it did not fix the problem, it is still a
> reasonable change.

It's not just more clear, it's the Right Thing to do for string type
constraint lists.  However, for a word type constraint list it would be
the wrong thing to do.

After I fixed the original code, I started to wonder why it was written
like that in the first place.  Then I remembered the Pascal string like
behaviour, where the first element contains the array size, for word
type constraint lists.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[m. allan noah]

On Sat, Sep 19, 2015 at 11:23 PM, Olaf Meeuwissen
 wrote:
> Hi Allan,
>
> m. allan noah writes:
>
>> I have just pushed all these changes, and a few more to git repo. I
>> have a few more minor bug fixes assigned to me that will go up in a
>> few hours.
>
> Many thanks!  I've checked all my branches against 87bfd53, removed all
> branches that are in from my GitLab clone and closed any related bug
> reports.  Hope I didn't miss any.
>
> Talking about missing things, it seems you forgot about the Hungarian
> translations.  There's a pu/add-hu.po-313073 branch on my GitLab clone
> that has not been merged yet.  Any reason this didn't get in?

Hmm- i missed that one. It is pushed now.

> Sorry about dropping the ball on the musl inb() outb() branch.  I had
> meant to commit configure.in but seem to have committed configure :-(

Do you have a version which uses AC_* macros instead of what I did? I
think that would be cleaner.

> After I pushed (what became) 9dd31f9 I had second thoughts when I
> recalled that there was something special with lists constraints.
> Cross-checking with the spec, it turns out my changeset is okay.

Yes- I stared at that code for quite awhile. I think the new code is
more clear, so
even if it did not fix the problem, it is still a reasonable change.

allan

--
"well, I stand up next to a mountain- and I chop it down with the edge
of my hand"

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Hi Allan,

m. allan noah writes:

> I have just pushed all these changes, and a few more to git repo. I
> have a few more minor bug fixes assigned to me that will go up in a
> few hours.

Many thanks!  I've checked all my branches against 87bfd53, removed all
branches that are in from my GitLab clone and closed any related bug
reports.  Hope I didn't miss any.

Talking about missing things, it seems you forgot about the Hungarian
translations.  There's a pu/add-hu.po-313073 branch on my GitLab clone
that has not been merged yet.  Any reason this didn't get in?

Sorry about dropping the ball on the musl inb() outb() branch.  I had
meant to commit configure.in but seem to have committed configure :-(

After I pushed (what became) 9dd31f9 I had second thoughts when I
recalled that there was something special with lists constraints.
Cross-checking with the spec, it turns out my changeset is okay.

# There is a difference in the way the SANE_CONSTRAINT_WORD_LIST and
# SANE_CONSTRAINT_STRING_LIST array are interpreted.  What I recalled
# was for the word list variety.  For string lists 9dd31f9 is okay.

> [snip]

Hope this helps,
--
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[m. allan noah]

I have just pushed all these changes, and a few more to git repo. I
have a few more minor bug fixes assigned to me that will go up in a
few hours.

allan

On Sat, Sep 19, 2015 at 7:32 AM, Olaf Meeuwissen
 wrote:
> Hi all,
>
> m. allan noah writes:
>
>> I agree with merging the png/jpg improvements, thanks for working on
>> that. The other branches look fine at first glance. I'll merge most or
>> all of this tomorrow, when I finally get some free time.
>
> Thanks, the number of branches is getting a bit unwieldy ;-)
>
> I finished going through all the unassigned bugs.  Phew!  There were 195
> when I started, now there's only 104 left.  That does not mean that 91
> tickets got closed of course, just that they got assigned or closed.
>
> For two of them I created new pu/ branches:
>
>  - pu/fix-compiler-warnings-314515 (security issue: out-of-bounds array
>access)
>  - pu/fix-option-descriptor-size-value-314975
>
>> On Fri, Sep 18, 2015 at 9:44 AM, Olaf Meeuwissen
>>  wrote:
>>> Hi again devs,
>>>
>>> Remember, 2015-09-19 is feature freeze day.  That's only about 90
>>> minutes away from where I'm at, but I hope that we can sneak in last
>>> minute features till the end of that day ;-)
>>>
>>> Please take a look at any of the branches I mentioned below.  I also
>>> added a few:
>>>
>>>  - pu/scanimage-png-jpeg-v4 adds PNG and JPEG image file format output
>>>support to scanimage
>>>  - pu/add-hu.po-313073 add Hungarian translations
>>>  - pu/ja.po-fixes-31385 for a few fixes to the Japanese translations
>>>  - pu/man-pages-fixes-314280-314282 fix manual page issues that make it
>>>next to impossible to cleanly convert these pages to other formats
>>>
>>> In terms of new "features", there's
>>>
>>>  - pu/scanimage-png-jpeg-v4
>>>  - pu/add-hu.po-313073
>>>
>>> that need to be acted on swiftly to make the feature freeze.
>>>
>>> The remainder are fixes or enhancements.  Of those, I'd like to see as
>>> many of the must-have, no-brainers and "IMNSHO-hsould-have" branches
>>> below go in Real Soon Now.
>>>
>>> Any branches that get merged will be removed from my GitLab clone as
>>> soon I as notice the merge and finish checking it.
>>>
>>> @devs (allan, stef, rolf mostly?): Please take a look and merge those
>>> branches you feel comfortable merging.  I may be able to merge branches
>>> myself but (as mentioned) don't feel comfortable doing so yet.  Maybe
>>> *after* the 1.0.25 release.
>>>
>>> Olaf Meeuwissen writes:
>>>
 Hi devs,

 I've been mail bombing the list, going through unassigned open tickets
 and pushing pu/* branches to my clone of sane-backends at GitLab[1].

  [1] https://gitlab.com/sane-project/backends/branches

 There are ten pu/* branches there as of writing and I have another five
 or so in the pipeline.  And I still have about 50 unassigned tickets to
 look at so there's probably more to come ;-)

 I would appreciate it if some of you could take a look at these branches
 and merge them to Alioth's master.

 There is one must-have: pu/fix-make-dist-targets.  Without it you won't
 be able to roll a tarball.  It also fixes `make distcheck` so you can do
 builds outside of the top-level source directory.

 There are two no-brainers: pu/fix-*.  The numbers refer to the associated
 bug reports.  I'll close those after I see the respective merges of these
 branches.

 In the "IMNSHO-should-have" category:
  - pu/epson-epson2-usb-split because the epson backend doesn't claim to
support *all* the scanners epson2 does --> @alessandro
  - pu/magicolor-4690MF-support because it adds support for a new scanner
--> @reinhold
  - pu/protect-niash-option-access-315132 because it fixes a slightly far
fetched security issue --> @stef
>>>
>>> This last one has been merged (and removed from my clone).
>>>
 For MIPS/musl portability, there's:
  - pu/dont-detach-after-join
  - pu/fix-musl-inb-outb-detection-on-mips
 and there may be another fix coming for u_char/u_long issues.

 Finally, there's:
  - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
output
  - pu/install-umax-pp-tools which addresses something Johannes pointed
out on the list.

 I've tried to attribute all the patches to their respective authors and
 timestamp them to match the first appearance that I am aware of.  While
 waiting for some/most/all of these to get merged, I'm off peering over
 unassigned tickets again.
>
> Hope this helps,
> --
> Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
> Support Free Software   Support the Free Software Foundation
> https://my.fsf.org/donatehttps://my.fsf.org/join



-- 
"well, I stand up next to a mountain- and I chop it down with the edge
of my hand"

-- 
sane-devel 

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Hi all,

m. allan noah writes:

> I agree with merging the png/jpg improvements, thanks for working on
> that. The other branches look fine at first glance. I'll merge most or
> all of this tomorrow, when I finally get some free time.

Thanks, the number of branches is getting a bit unwieldy ;-)

I finished going through all the unassigned bugs.  Phew!  There were 195
when I started, now there's only 104 left.  That does not mean that 91
tickets got closed of course, just that they got assigned or closed.

For two of them I created new pu/ branches:

 - pu/fix-compiler-warnings-314515 (security issue: out-of-bounds array
   access)
 - pu/fix-option-descriptor-size-value-314975

> On Fri, Sep 18, 2015 at 9:44 AM, Olaf Meeuwissen
>  wrote:
>> Hi again devs,
>>
>> Remember, 2015-09-19 is feature freeze day.  That's only about 90
>> minutes away from where I'm at, but I hope that we can sneak in last
>> minute features till the end of that day ;-)
>>
>> Please take a look at any of the branches I mentioned below.  I also
>> added a few:
>>
>>  - pu/scanimage-png-jpeg-v4 adds PNG and JPEG image file format output
>>support to scanimage
>>  - pu/add-hu.po-313073 add Hungarian translations
>>  - pu/ja.po-fixes-31385 for a few fixes to the Japanese translations
>>  - pu/man-pages-fixes-314280-314282 fix manual page issues that make it
>>next to impossible to cleanly convert these pages to other formats
>>
>> In terms of new "features", there's
>>
>>  - pu/scanimage-png-jpeg-v4
>>  - pu/add-hu.po-313073
>>
>> that need to be acted on swiftly to make the feature freeze.
>>
>> The remainder are fixes or enhancements.  Of those, I'd like to see as
>> many of the must-have, no-brainers and "IMNSHO-hsould-have" branches
>> below go in Real Soon Now.
>>
>> Any branches that get merged will be removed from my GitLab clone as
>> soon I as notice the merge and finish checking it.
>>
>> @devs (allan, stef, rolf mostly?): Please take a look and merge those
>> branches you feel comfortable merging.  I may be able to merge branches
>> myself but (as mentioned) don't feel comfortable doing so yet.  Maybe
>> *after* the 1.0.25 release.
>>
>> Olaf Meeuwissen writes:
>>
>>> Hi devs,
>>>
>>> I've been mail bombing the list, going through unassigned open tickets
>>> and pushing pu/* branches to my clone of sane-backends at GitLab[1].
>>>
>>>  [1] https://gitlab.com/sane-project/backends/branches
>>>
>>> There are ten pu/* branches there as of writing and I have another five
>>> or so in the pipeline.  And I still have about 50 unassigned tickets to
>>> look at so there's probably more to come ;-)
>>>
>>> I would appreciate it if some of you could take a look at these branches
>>> and merge them to Alioth's master.
>>>
>>> There is one must-have: pu/fix-make-dist-targets.  Without it you won't
>>> be able to roll a tarball.  It also fixes `make distcheck` so you can do
>>> builds outside of the top-level source directory.
>>>
>>> There are two no-brainers: pu/fix-*.  The numbers refer to the associated
>>> bug reports.  I'll close those after I see the respective merges of these
>>> branches.
>>>
>>> In the "IMNSHO-should-have" category:
>>>  - pu/epson-epson2-usb-split because the epson backend doesn't claim to
>>>support *all* the scanners epson2 does --> @alessandro
>>>  - pu/magicolor-4690MF-support because it adds support for a new scanner
>>>--> @reinhold
>>>  - pu/protect-niash-option-access-315132 because it fixes a slightly far
>>>fetched security issue --> @stef
>>
>> This last one has been merged (and removed from my clone).
>>
>>> For MIPS/musl portability, there's:
>>>  - pu/dont-detach-after-join
>>>  - pu/fix-musl-inb-outb-detection-on-mips
>>> and there may be another fix coming for u_char/u_long issues.
>>>
>>> Finally, there's:
>>>  - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
>>>output
>>>  - pu/install-umax-pp-tools which addresses something Johannes pointed
>>>out on the list.
>>>
>>> I've tried to attribute all the patches to their respective authors and
>>> timestamp them to match the first appearance that I am aware of.  While
>>> waiting for some/most/all of these to get merged, I'm off peering over
>>> unassigned tickets again.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[m. allan noah]

I agree with merging the png/jpg improvements, thanks for working on
that. The other branches look fine at first glance. I'll merge most or
all of this tomorrow, when I finally get some free time.

allan

On Fri, Sep 18, 2015 at 9:44 AM, Olaf Meeuwissen
 wrote:
> Hi again devs,
>
> Remember, 2015-09-19 is feature freeze day.  That's only about 90
> minutes away from where I'm at, but I hope that we can sneak in last
> minute features till the end of that day ;-)
>
> Please take a look at any of the branches I mentioned below.  I also
> added a few:
>
>  - pu/scanimage-png-jpeg-v4 adds PNG and JPEG image file format output
>support to scanimage
>  - pu/add-hu.po-313073 add Hungarian translations
>  - pu/ja.po-fixes-31385 for a few fixes to the Japanese translations
>  - pu/man-pages-fixes-314280-314282 fix manual page issues that make it
>next to impossible to cleanly convert these pages to other formats
>
> In terms of new "features", there's
>
>  - pu/scanimage-png-jpeg-v4
>  - pu/add-hu.po-313073
>
> that need to be acted on swiftly to make the feature freeze.
>
> The remainder are fixes or enhancements.  Of those, I'd like to see as
> many of the must-have, no-brainers and "IMNSHO-hsould-have" branches
> below go in Real Soon Now.
>
> Any branches that get merged will be removed from my GitLab clone as
> soon I as notice the merge and finish checking it.
>
> @devs (allan, stef, rolf mostly?): Please take a look and merge those
> branches you feel comfortable merging.  I may be able to merge branches
> myself but (as mentioned) don't feel comfortable doing so yet.  Maybe
> *after* the 1.0.25 release.
>
> Olaf Meeuwissen writes:
>
>> Hi devs,
>>
>> I've been mail bombing the list, going through unassigned open tickets
>> and pushing pu/* branches to my clone of sane-backends at GitLab[1].
>>
>>  [1] https://gitlab.com/sane-project/backends/branches
>>
>> There are ten pu/* branches there as of writing and I have another five
>> or so in the pipeline.  And I still have about 50 unassigned tickets to
>> look at so there's probably more to come ;-)
>>
>> I would appreciate it if some of you could take a look at these branches
>> and merge them to Alioth's master.
>>
>> There is one must-have: pu/fix-make-dist-targets.  Without it you won't
>> be able to roll a tarball.  It also fixes `make distcheck` so you can do
>> builds outside of the top-level source directory.
>>
>> There are two no-brainers: pu/fix-*.  The numbers refer to the associated
>> bug reports.  I'll close those after I see the respective merges of these
>> branches.
>>
>> In the "IMNSHO-should-have" category:
>>  - pu/epson-epson2-usb-split because the epson backend doesn't claim to
>>support *all* the scanners epson2 does --> @alessandro
>>  - pu/magicolor-4690MF-support because it adds support for a new scanner
>>--> @reinhold
>>  - pu/protect-niash-option-access-315132 because it fixes a slightly far
>>fetched security issue --> @stef
>
> This last one has been merged (and removed from my clone).
>
>> For MIPS/musl portability, there's:
>>  - pu/dont-detach-after-join
>>  - pu/fix-musl-inb-outb-detection-on-mips
>> and there may be another fix coming for u_char/u_long issues.
>>
>> Finally, there's:
>>  - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
>>output
>>  - pu/install-umax-pp-tools which addresses something Johannes pointed
>>out on the list.
>>
>> I've tried to attribute all the patches to their respective authors and
>> timestamp them to match the first appearance that I am aware of.  While
>> waiting for some/most/all of these to get merged, I'm off peering over
>> unassigned tickets again.
>
> Hope this helps,
> --
> Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
> Support Free Software   Support the Free Software Foundation
> https://my.fsf.org/donatehttps://my.fsf.org/join



-- 
"well, I stand up next to a mountain- and I chop it down with the edge
of my hand"

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Hi again devs,

Remember, 2015-09-19 is feature freeze day.  That's only about 90
minutes away from where I'm at, but I hope that we can sneak in last
minute features till the end of that day ;-)

Please take a look at any of the branches I mentioned below.  I also
added a few:

 - pu/scanimage-png-jpeg-v4 adds PNG and JPEG image file format output
   support to scanimage
 - pu/add-hu.po-313073 add Hungarian translations
 - pu/ja.po-fixes-31385 for a few fixes to the Japanese translations
 - pu/man-pages-fixes-314280-314282 fix manual page issues that make it
   next to impossible to cleanly convert these pages to other formats

In terms of new "features", there's

 - pu/scanimage-png-jpeg-v4
 - pu/add-hu.po-313073

that need to be acted on swiftly to make the feature freeze.

The remainder are fixes or enhancements.  Of those, I'd like to see as
many of the must-have, no-brainers and "IMNSHO-hsould-have" branches
below go in Real Soon Now.

Any branches that get merged will be removed from my GitLab clone as
soon I as notice the merge and finish checking it.

@devs (allan, stef, rolf mostly?): Please take a look and merge those
branches you feel comfortable merging.  I may be able to merge branches
myself but (as mentioned) don't feel comfortable doing so yet.  Maybe
*after* the 1.0.25 release.

Olaf Meeuwissen writes:

> Hi devs,
>
> I've been mail bombing the list, going through unassigned open tickets
> and pushing pu/* branches to my clone of sane-backends at GitLab[1].
>
>  [1] https://gitlab.com/sane-project/backends/branches
>
> There are ten pu/* branches there as of writing and I have another five
> or so in the pipeline.  And I still have about 50 unassigned tickets to
> look at so there's probably more to come ;-)
>
> I would appreciate it if some of you could take a look at these branches
> and merge them to Alioth's master.
>
> There is one must-have: pu/fix-make-dist-targets.  Without it you won't
> be able to roll a tarball.  It also fixes `make distcheck` so you can do
> builds outside of the top-level source directory.
>
> There are two no-brainers: pu/fix-*.  The numbers refer to the associated
> bug reports.  I'll close those after I see the respective merges of these
> branches.
>
> In the "IMNSHO-should-have" category:
>  - pu/epson-epson2-usb-split because the epson backend doesn't claim to
>support *all* the scanners epson2 does --> @alessandro
>  - pu/magicolor-4690MF-support because it adds support for a new scanner
>--> @reinhold
>  - pu/protect-niash-option-access-315132 because it fixes a slightly far
>fetched security issue --> @stef

This last one has been merged (and removed from my clone).

> For MIPS/musl portability, there's:
>  - pu/dont-detach-after-join
>  - pu/fix-musl-inb-outb-detection-on-mips
> and there may be another fix coming for u_char/u_long issues.
>
> Finally, there's:
>  - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
>output
>  - pu/install-umax-pp-tools which addresses something Johannes pointed
>out on the list.
>
> I've tried to attribute all the patches to their respective authors and
> timestamp them to match the first appearance that I am aware of.  While
> waiting for some/most/all of these to get merged, I'm off peering over
> unassigned tickets again.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Stef writes:

> On 16/09/2015 13:07, Olaf Meeuwissen wrote:
>> Hi devs,
>> [...]
>> I would appreciate it if some of you could take a look at these branches
>> and merge them to Alioth's master.
>> [...]
>>   - pu/protect-niash-option-access-315132 because it fixes a slightly far
>> fetched security issue --> @stef
>> [...]
>
>  Hello,
>
> pu/protect-niash-option-access-315132 
> is
>  
> merged, and while I was at it, I ifdef'ed the code that was hidden since 
> 2004.

Thanks!  I'll zap the pu/ branch from my repository then.
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join


-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

[sane-devel] Proposed Upgrade (pu) branches on GitLab

[Olaf Meeuwissen]

Hi devs,

I've been mail bombing the list, going through unassigned open tickets
and pushing pu/* branches to my clone of sane-backends at GitLab[1].

 [1] https://gitlab.com/sane-project/backends/branches

There are ten pu/* branches there as of writing and I have another five
or so in the pipeline.  And I still have about 50 unassigned tickets to
look at so there's probably more to come ;-)

I would appreciate it if some of you could take a look at these branches
and merge them to Alioth's master.

There is one must-have: pu/fix-make-dist-targets.  Without it you won't
be able to roll a tarball.  It also fixes `make distcheck` so you can do
builds outside of the top-level source directory.

There are two no-brainers: pu/fix-*.  The numbers refer to the associated
bug reports.  I'll close those after I see the respective merges of these
branches.

In the "IMNSHO-should-have" category:
 - pu/epson-epson2-usb-split because the epson backend doesn't claim to
   support *all* the scanners epson2 does --> @alessandro
 - pu/magicolor-4690MF-support because it adds support for a new scanner
   --> @reinhold
 - pu/protect-niash-option-access-315132 because it fixes a slightly far
   fetched security issue --> @stef

For MIPS/musl portability, there's:
 - pu/dont-detach-after-join
 - pu/fix-musl-inb-outb-detection-on-mips
and there may be another fix coming for u_char/u_long issues.

Finally, there's:
 - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
   output
 - pu/install-umax-pp-tools which addresses something Johannes pointed
   out on the list.

I've tried to attribute all the patches to their respective authors and
timestamp them to match the first appearance that I am aware of.  While
waiting for some/most/all of these to get merged, I'm off peering over
unassigned tickets again.

Hope this helps,
-- 
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
Support Free Software   Support the Free Software Foundation
https://my.fsf.org/donatehttps://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Proposed Upgrade (pu) branches on GitLab

[Stef]

On 16/09/2015 13:07, Olaf Meeuwissen wrote:

Hi devs,

I've been mail bombing the list, going through unassigned open tickets
and pushing pu/* branches to my clone of sane-backends at GitLab[1].

  [1] https://gitlab.com/sane-project/backends/branches

There are ten pu/* branches there as of writing and I have another five
or so in the pipeline.  And I still have about 50 unassigned tickets to
look at so there's probably more to come ;-)

I would appreciate it if some of you could take a look at these branches
and merge them to Alioth's master.

There is one must-have: pu/fix-make-dist-targets.  Without it you won't
be able to roll a tarball.  It also fixes `make distcheck` so you can do
builds outside of the top-level source directory.

There are two no-brainers: pu/fix-*.  The numbers refer to the associated
bug reports.  I'll close those after I see the respective merges of these
branches.

In the "IMNSHO-should-have" category:
  - pu/epson-epson2-usb-split because the epson backend doesn't claim to
support *all* the scanners epson2 does --> @alessandro
  - pu/magicolor-4690MF-support because it adds support for a new scanner
--> @reinhold
  - pu/protect-niash-option-access-315132 because it fixes a slightly far
fetched security issue --> @stef

For MIPS/musl portability, there's:
  - pu/dont-detach-after-join
  - pu/fix-musl-inb-outb-detection-on-mips
and there may be another fix coming for u_char/u_long issues.

Finally, there's:
  - pu/bit-depth-reporting-fix which fixes a corner case in scanimage's
output
  - pu/install-umax-pp-tools which addresses something Johannes pointed
out on the list.

I've tried to attribute all the patches to their respective authors and
timestamp them to match the first appearance that I am aware of.  While
waiting for some/most/all of these to get merged, I'm off peering over
unassigned tickets again.

Hope this helps,


Hello,

pu/protect-niash-option-access-315132 
is 
merged, and while I was at it, I ifdef'ed the code that was hidden since 
2004.


Regards,
Stef

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org