[jira] Updated: (SCM-29) test with CVS NT
[ http://jira.codehaus.org/browse/SCM-29?page=all ] Emmanuel Venisse updated SCM-29: Fix Version: 1.0 test with CVS NT Key: SCM-29 URL: http://jira.codehaus.org/browse/SCM-29 Project: Maven SCM Type: Test Components: maven-scm-provider-cvs Reporter: Brett Porter Fix For: 1.0 Vincent reported test failures on CVS NT... test it and fix if required. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-121) Intermittent CVS test failures
[ http://jira.codehaus.org/browse/SCM-121?page=all ] Emmanuel Venisse updated SCM-121: - Fix Version: (was: 1.0-beta-3) 1.0 Intermittent CVS test failures -- Key: SCM-121 URL: http://jira.codehaus.org/browse/SCM-121 Project: Maven SCM Type: Bug Components: maven-scm-provider-cvs Versions: 1.0-beta-3 Reporter: Mike Perham Fix For: 1.0 Dan and I continue to have test failures when trying to compile the cvs plugin in our environment. I emailed these problems to the scm-dev list about a week ago. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-85) Allow svn username/password to be set in servers section of settings.xml
[ http://jira.codehaus.org/browse/SCM-85?page=all ] Emmanuel Venisse updated SCM-85: Fix Version: 1.0-beta-3 Allow svn username/password to be set in servers section of settings.xml Key: SCM-85 URL: http://jira.codehaus.org/browse/SCM-85 Project: Maven SCM Type: Improvement Components: maven-scm-provider-svn Reporter: Micah Schehl Fix For: 1.0-beta-3 Attachments: MNG-85-maven-scm.patch, SCM-85.patch Allow developers to have their own subversion username/password set in settings.xml.Also, this would prevent having to use the web setup to enter username/password in Continuum since the info would be in settings.xml. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-131) mvn scm:validate does not validate the developerConnection in the pom
[ http://jira.codehaus.org/browse/SCM-131?page=all ]
Emmanuel Venisse updated SCM-131:
-
Fix Version: 1.0-beta-3
mvn scm:validate does not validate the developerConnection in the pom
-
Key: SCM-131
URL: http://jira.codehaus.org/browse/SCM-131
Project: Maven SCM
Type: Bug
Components: maven-plugin
Reporter: Dennis Lundberg
Fix For: 1.0-beta-3
Attachments: SCM-131.patch
There are a couple of reasons for this, in ValidateMojo:
# The check to see if the scmDeveloperConnection is not null is done on the
scmConnection
# The @parameter definitions are wrong for both the the scmConnection and
scmDeveloperConnection
The check for scmConnection is never run either because of of the wrong
@parameter definitions. But the actual value from the pom is normally checked
anyway because the default-value for connectionUrl in AbstractScmMojo is
${pom.scm.connection}. But if you run it like this:
mvn scm:validate -DconnectionUrl=invalidScmUrl
the value of pom.scm.connection will not be checked.
The supplied patch fixes these problems and logs an extra error the tells the
user the value of the invalid scm connection url, to help resolve the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (SCM-133) Merge redundant repository classes
[ http://jira.codehaus.org/browse/SCM-133?page=all ] Emmanuel Venisse updated SCM-133: - Fix Version: (was: 1.0-beta-3) Merge redundant repository classes -- Key: SCM-133 URL: http://jira.codehaus.org/browse/SCM-133 Project: Maven SCM Type: Improvement Components: maven-scm-api Versions: 1.0-beta-2 Reporter: Mike Perham Currently there are: com.apache.maven.scm.repository.ScmRepository com.apache.maven.scm.provider.ScmProviderRepository The comment at the top of the former says: * @todo clarify need - should be able to merge with ScmProviderRepository? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-117) Add parameters to scm configuration element
[ http://jira.codehaus.org/browse/SCM-117?page=all ] Emmanuel Venisse updated SCM-117: - Fix Version: (was: 1.0-beta-3) Add parameters to scm configuration element --- Key: SCM-117 URL: http://jira.codehaus.org/browse/SCM-117 Project: Maven SCM Type: Wish Components: maven-scm-provider-starteam Versions: 1.0-beta-2 Reporter: Aviran Mordo Assignee: Dan Tran It would be very nice to have the ability to add parameters to the scm element. For instance to add parameter to always force checkout. for instance in Starteam I would like to add -o so every time stcmd is called the parameters will be concatenated to the command line -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-21) separate revision and tag handling
[ http://jira.codehaus.org/browse/SCM-21?page=all ]
Emmanuel Venisse updated SCM-21:
Fix Version: (was: 1.0-beta-3)
separate revision and tag handling
--
Key: SCM-21
URL: http://jira.codehaus.org/browse/SCM-21
Project: Maven SCM
Type: Task
Components: maven-scm-api
Reporter: Brett Porter
while in CVS revision# and tag are handled in the same way, the concepts can
be separated and will make other SCMs easier.
for example, in subversion, valid revisions are:
rev#
HEAD
BASE
COMMITTED
PREV
{DATE}
tags are normal checkouts from a different base.
In CVS, revisions are:
rev# (per file only really makes sense here, but can apply to several)
HEAD
SOME_BRANCH_TAG
{DATE}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: Bazaar Provider
1.0-beta-3 will be release before end of Febrary. So if you do them for next week, it's great. Emmanuel Torbjørn Smørgrav a écrit : When is 1.0-beta-3 scheduled to? I'll try to do some of it this weekend, and then I can do the rest at the end of next week. T -Original Message- From: Emmanuel Venisse [mailto:[EMAIL PROTECTED] Sent: 2. februar 2006 16:33 To: scm-dev@maven.apache.org Subject: Re: Bazaar Provider Open an issue with this file and you'll add a changelog parser test when it will be ready. You can file issues for other point and assigned them to you. When do you think you'll can do them? I'd like commit fixes before 1.0-beta-3 Emmanuel Torbjørn Smørgrav a écrit : Do you want the output just as below or documented somewhere else? Sample changelog output from Bazaar: revno: 3 committer: [EMAIL PROTECTED] timestamp: Thu 2006-01-26 16:55:47 +0100 message: Inventory stuff revno: 2 committer: [EMAIL PROTECTED] timestamp: Tue 2006-01-03 15:42:54 +0100 message: Remove comment revno: 1 committer: [EMAIL PROTECTED] timestamp: Tue 2006-01-03 15:40:14 +0100 message: Initial revision FYI: I have a couple of other issues in the pipeline: 1. Diff cmd is not passing the unit test due to the @@ tag and wrong ScmFileStatus 2. Checkin unit test is failing on linux with bazaar 0.6 3. Add changelog test 4. Test urls with ftps and ftp 5. Proper std.err processing Regards Torbjørn -Original Message- From: Emmanuel Venisse [mailto:[EMAIL PROTECTED] Sent: 2. februar 2006 15:11 To: scm-dev@maven.apache.org Subject: Bazaar Provider Hi Torbjorn, Can you provide a sample output of bazaar changelog output and add a changelog consumer test? Thanks Emmanuel
[jira] Created: (SCM-150) Start pure java cvs provider
Start pure java cvs provider Key: SCM-150 URL: http://jira.codehaus.org/browse/SCM-150 Project: Maven SCM Type: New Feature Components: maven-scm-provider-cvs Reporter: Emmanuel Venisse Fix For: 1.0-beta-3 required by changelo plugin for backward compatibility -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-150) Start pure java cvs provider
[ http://jira.codehaus.org/browse/SCM-150?page=all ] Emmanuel Venisse updated SCM-150: - Assign To: Emmanuel Venisse Fix Version: 1.0-beta-3 Start pure java cvs provider Key: SCM-150 URL: http://jira.codehaus.org/browse/SCM-150 Project: Maven SCM Type: New Feature Components: maven-scm-provider-cvs Reporter: Emmanuel Venisse Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 required by changelo plugin for backward compatibility -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SCM-130) scm:validate should not require a project
[ http://jira.codehaus.org/browse/SCM-130?page=all ] Emmanuel Venisse closed SCM-130: Assign To: Emmanuel Venisse Resolution: Fixed Done. scm:validate should not require a project - Key: SCM-130 URL: http://jira.codehaus.org/browse/SCM-130 Project: Maven SCM Type: Improvement Versions: 1.0-beta-2 Environment: xp, cvs, starteam Reporter: Dan Tran Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 We should be able to run scm:validate any where as long as we can passin -DconnectionUrl -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=all ] Emmanuel Venisse closed SCM-124: Assign To: Emmanuel Venisse Resolution: Fixed Fixed. I've tested with : MAVEN_OPTS=-Duser.language=de -Duser.country=DE StarteamChangeLogConsumerTest does not work if locale is not en or fr - Key: SCM-124 URL: http://jira.codehaus.org/browse/SCM-124 Project: Maven SCM Type: Bug Components: maven-scm-provider-starteam Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale Reporter: Dennis Lundberg Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 The testcase StarteamChangeLogConsumerTest makes assumptions about the user's locale that are not always true. Lines 45-52 uses the default locale and if a suitable changelog for that locale is not found, it defaults to using the English changelog file. This works well for English and French which have changelog files. But it does not work for other locales that use a different dateformat than English, i.e most of Europe. The problem is that the class StarteamChangeLogConsumer has a private instance variable of SimpleDateFormat called localFormat. This variable can not be set from outside the class. On line 390 localFormat is used to parse dates. This will fail if the user has a different locale than the one being used in the logfile being parsed. I imagine that it is common (at least not uncommon) to have different locales on the server and the client. So the locale used in the StarteamChangeLogConsumer needs to be set to the locale used by the *server* and not the *client*. A simple getter/setter would do the trick. The locale would need to be configurable in some way so that the user can set the locale that is used by his/her server. The reason I stumbled upon this was when I tried to do mvn test for maven-scm. It produced this stacktrace: ... [INFO] [INFO] Building Maven SCM Starteam Provider [INFO]task-segment: [test] [INFO] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 25 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes [INFO] [surefire:test] [INFO] Setting reports dir: G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports --- T E S T S --- [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec Added: ./maven.xml Added: ./target/checkout/maven.xml Added: ./target/checkout/project.properties Added: ./target/checkout/project.xml Added: ./target/checkout/bootstrap/maven.xml Added: ./target/checkout/bootstrap/project.properties Added: ./target/checkout/bootstrap/project.xml [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec [ERROR] ParseException Caught java.text.ParseException: Unparseable date: 4/21/04 1:05:00 PM PDT at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) at
[jira] Commented: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=comments#action_57688 ] Dennis Lundberg commented on SCM-124: - I can confirm that the tests run successfully using revision 374523. But I do think that the root of the problem is still there. Running the tests succeeds, but they produce 6 ERROR lines in the output, which seems to be ignored. They look like this: [ERROR] ParseException Caught java.text.ParseException: Unparseable date: 4/21/04 1:05:00 PM PDT at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.util.AbstractConsumer.parseDate(AbstractConsumer.java:79) The reason for these exceptions is this. If no pattern is specified in a call to parseDate( String date, String userPattern, String defaultPattern ) a SimpleDateInstance is created using the users default locale. This assumes that the ChangeLog that is being parsed uses the same date format as the users default locale. As I stated in a previous comment, I don't know much about Starteam, so please correct me if I'm wrong here: Wouldn't it be better to assume a locale of en_US if no pattern is specified? By using a DateFormat factory method I managed to do this in AbstractConsumer, which made the test run successfully *without* any ERROR lines. I'll attach a patch shortly. I do not know, however, how this would affect normal usage. Perhaps someone knowledgeable in Starteam can step up and shed some light on this. StarteamChangeLogConsumerTest does not work if locale is not en or fr - Key: SCM-124 URL: http://jira.codehaus.org/browse/SCM-124 Project: Maven SCM Type: Bug Components: maven-scm-provider-starteam Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale Reporter: Dennis Lundberg Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 The testcase StarteamChangeLogConsumerTest makes assumptions about the user's locale that are not always true. Lines 45-52 uses the default locale and if a suitable changelog for that locale is not found, it defaults to using the English changelog file. This works well for English and French which have changelog files. But it does not work for other locales that use a different dateformat than English, i.e most of Europe. The problem is that the class StarteamChangeLogConsumer has a private instance variable of SimpleDateFormat called localFormat. This variable can not be set from outside the class. On line 390 localFormat is used to parse dates. This will fail if the user has a different locale than the one being used in the logfile being parsed. I imagine that it is common (at least not uncommon) to have different locales on the server and the client. So the locale used in the StarteamChangeLogConsumer needs to be set to the locale used by the *server* and not the *client*. A simple getter/setter would do the trick. The locale would need to be configurable in some way so that the user can set the locale that is used by his/her server. The reason I stumbled upon this was when I tried to do mvn test for maven-scm. It produced this stacktrace: ... [INFO] [INFO] Building Maven SCM Starteam Provider [INFO]task-segment: [test] [INFO] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 25 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes [INFO] [surefire:test] [INFO] Setting reports dir: G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports --- T E S T S --- [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec Added: ./maven.xml Added: ./target/checkout/maven.xml Added: ./target/checkout/project.properties Added: ./target/checkout/project.xml
[jira] Updated: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=all ] Dennis Lundberg updated SCM-124: Attachment: SCM-124.patch StarteamChangeLogConsumerTest does not work if locale is not en or fr - Key: SCM-124 URL: http://jira.codehaus.org/browse/SCM-124 Project: Maven SCM Type: Bug Components: maven-scm-provider-starteam Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale Reporter: Dennis Lundberg Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 Attachments: SCM-124.patch The testcase StarteamChangeLogConsumerTest makes assumptions about the user's locale that are not always true. Lines 45-52 uses the default locale and if a suitable changelog for that locale is not found, it defaults to using the English changelog file. This works well for English and French which have changelog files. But it does not work for other locales that use a different dateformat than English, i.e most of Europe. The problem is that the class StarteamChangeLogConsumer has a private instance variable of SimpleDateFormat called localFormat. This variable can not be set from outside the class. On line 390 localFormat is used to parse dates. This will fail if the user has a different locale than the one being used in the logfile being parsed. I imagine that it is common (at least not uncommon) to have different locales on the server and the client. So the locale used in the StarteamChangeLogConsumer needs to be set to the locale used by the *server* and not the *client*. A simple getter/setter would do the trick. The locale would need to be configurable in some way so that the user can set the locale that is used by his/her server. The reason I stumbled upon this was when I tried to do mvn test for maven-scm. It produced this stacktrace: ... [INFO] [INFO] Building Maven SCM Starteam Provider [INFO]task-segment: [test] [INFO] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 25 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes [INFO] [surefire:test] [INFO] Setting reports dir: G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports --- T E S T S --- [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec Added: ./maven.xml Added: ./target/checkout/maven.xml Added: ./target/checkout/project.properties Added: ./target/checkout/project.xml Added: ./target/checkout/bootstrap/maven.xml Added: ./target/checkout/bootstrap/project.properties Added: ./target/checkout/bootstrap/project.xml [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec [ERROR] ParseException Caught java.text.ParseException: Unparseable date: 4/21/04 1:05:00 PM PDT at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.processGetAuthor(StarteamChangeLogConsumer.java:281 at
[jira] Commented: (SCM-150) Start pure java cvs provider
[ http://jira.codehaus.org/browse/SCM-150?page=comments#action_57690 ] Dennis Lundberg commented on SCM-150: - How is this different from SCM-10? Start pure java cvs provider Key: SCM-150 URL: http://jira.codehaus.org/browse/SCM-150 Project: Maven SCM Type: New Feature Components: maven-scm-provider-cvs Reporter: Emmanuel Venisse Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 required by changelo plugin for backward compatibility -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (SCM-124) StarteamChangeLogConsumerTest does not work if locale is not en or fr
[ http://jira.codehaus.org/browse/SCM-124?page=all ] Emmanuel Venisse closed SCM-124: Resolution: Fixed Applied. Thanks. StarteamChangeLogConsumerTest does not work if locale is not en or fr - Key: SCM-124 URL: http://jira.codehaus.org/browse/SCM-124 Project: Maven SCM Type: Bug Components: maven-scm-provider-starteam Environment: Maven 2.0.1, JDK 1.4.2_09, Win XP Pro, Swedish locale Reporter: Dennis Lundberg Assignee: Emmanuel Venisse Fix For: 1.0-beta-3 Attachments: SCM-124.patch The testcase StarteamChangeLogConsumerTest makes assumptions about the user's locale that are not always true. Lines 45-52 uses the default locale and if a suitable changelog for that locale is not found, it defaults to using the English changelog file. This works well for English and French which have changelog files. But it does not work for other locales that use a different dateformat than English, i.e most of Europe. The problem is that the class StarteamChangeLogConsumer has a private instance variable of SimpleDateFormat called localFormat. This variable can not be set from outside the class. On line 390 localFormat is used to parse dates. This will fail if the user has a different locale than the one being used in the logfile being parsed. I imagine that it is common (at least not uncommon) to have different locales on the server and the client. So the locale used in the StarteamChangeLogConsumer needs to be set to the locale used by the *server* and not the *client*. A simple getter/setter would do the trick. The locale would need to be configurable in some way so that the user can set the locale that is used by his/her server. The reason I stumbled upon this was when I tried to do mvn test for maven-scm. It produced this stacktrace: ... [INFO] [INFO] Building Maven SCM Starteam Provider [INFO]task-segment: [test] [INFO] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] Compiling 25 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\classes [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] Compiling 22 source files to G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target\test-classes [INFO] [surefire:test] [INFO] Setting reports dir: G:\svn\maven-scm\maven-scm-providers\maven-scm-provider-starteam\target/surefire-reports --- T E S T S --- [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddCommandTest [surefire] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0,02 sec Added: ./maven.xml Added: ./target/checkout/maven.xml Added: ./target/checkout/project.properties Added: ./target/checkout/project.xml Added: ./target/checkout/bootstrap/maven.xml Added: ./target/checkout/bootstrap/project.properties Added: ./target/checkout/bootstrap/project.xml [surefire] Running org.apache.maven.scm.provider.starteam.command.add.StarteamAddConsumerTest [surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0,03 sec [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [WARNING] Your scm URL use a deprecated format. The new format is :[username[:[EMAIL PROTECTED]:port:/projectName/[viewName/][folderHiearchy/] [surefire] Running org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommandTest [surefire] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0,02 sec [ERROR] ParseException Caught java.text.ParseException: Unparseable date: 4/21/04 1:05:00 PM PDT at java.text.DateFormat.parse(DateFormat.java:335) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.parseDate(StarteamChangeLogConsumer.java:390) at org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer.processGetAuthor(StarteamChangeLogConsumer.java:281 at
