[jira] Updated: (SCM-131) mvn scm:validate does not validate the developerConnection in the pom
[ http://jira.codehaus.org/browse/SCM-131?page=all ] Emmanuel Venisse updated SCM-131: - Fix Version: 1.0-beta-3 > mvn scm:validate does not validate the developerConnection in the pom > - > > Key: SCM-131 > URL: http://jira.codehaus.org/browse/SCM-131 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Reporter: Dennis Lundberg > Fix For: 1.0-beta-3 > Attachments: SCM-131.patch > > > There are a couple of reasons for this, in ValidateMojo: > # The check to see if the scmDeveloperConnection is not null is done on the > scmConnection > # The @parameter definitions are wrong for both the the scmConnection and > scmDeveloperConnection > The check for scmConnection is never run either because of of the wrong > @parameter definitions. But the actual value from the pom is normally checked > anyway because the default-value for connectionUrl in AbstractScmMojo is > ${pom.scm.connection}. But if you run it like this: > mvn scm:validate -DconnectionUrl=invalidScmUrl > the value of pom.scm.connection will not be checked. > The supplied patch fixes these problems and logs an extra error the tells the > user the value of the invalid scm connection url, to help resolve the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-131) mvn scm:validate does not validate the developerConnection in the pom
[ http://jira.codehaus.org/browse/SCM-131?page=all ] Dennis Lundberg updated SCM-131: Attachment: SCM-131.patch > mvn scm:validate does not validate the developerConnection in the pom > - > > Key: SCM-131 > URL: http://jira.codehaus.org/browse/SCM-131 > Project: Maven SCM > Type: Bug > Components: maven-plugin > Reporter: Dennis Lundberg > Attachments: SCM-131.patch > > > There are a couple of reasons for this, in ValidateMojo: > # The check to see if the scmDeveloperConnection is not null is done on the > scmConnection > # The @parameter definitions are wrong for both the the scmConnection and > scmDeveloperConnection > The check for scmConnection is never run either because of of the wrong > @parameter definitions. But the actual value from the pom is normally checked > anyway because the default-value for connectionUrl in AbstractScmMojo is > ${pom.scm.connection}. But if you run it like this: > mvn scm:validate -DconnectionUrl=invalidScmUrl > the value of pom.scm.connection will not be checked. > The supplied patch fixes these problems and logs an extra error the tells the > user the value of the invalid scm connection url, to help resolve the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira