Re: [Scons-dev] SCons speedup and profiling results...
Hi Rupert, On 26.09.2013 09:24, rupert THURNER wrote: On Thu, Sep 26, 2013 at 8:44 AM, Dirk Bächle wrote: Hi Gary, On 26.09.2013 02:08, Gary Oberbrunner wrote: [...] what are the main things which make waf, and wonderbuild so much faster than scons? a test is here, but already a little outdated: http://retropaganda.info/~bohan/work/psycle/branches/bohan/wonderbuild/benchmarks/time.xml the main difference between SCons and waf/wonderbuild regarding run times for updates is, that the latter two don't offer a "recursive variable substitution" feature (the subst() method in SCons). Additionally, wonderbuild is trimmed to speed by sacrificing correctness, e.g. it's CPP scanner doesn't care about "#ifdef"s. Waf handles this much better, I guess...but I didn't check its sources. Regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
Here's the wiki page for the mercurial flow for submitting bugs. http://www.scons.org/wiki/SconsMercurialWorkflows -Bill On Thu, Sep 26, 2013 at 5:22 AM, wrote: > I used the test case described in the bug, but I have nothing to integrate > in scons test suite. > > Le 26 sept. 2013 à 14:16, Gary Oberbrunner a > écrit : > > > On Thu, Sep 26, 2013 at 8:11 AM, wrote: > >> Hi, >> By the way, did you review mine? ( >> https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff >> ) >> >> I saw it, Alexandre -- it's definitely in the queue, and on simple > inspection it looks OK. I just want to make sure that that's the best way > to fix it. Do you have a test case for it? > > -- > Gary > ___ > Scons-dev mailing list > Scons-dev@scons.org > http://two.pairlist.net/mailman/listinfo/scons-dev > > > > ___ > Scons-dev mailing list > Scons-dev@scons.org > http://two.pairlist.net/mailman/listinfo/scons-dev > > ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
I used the test case described in the bug, but I have nothing to integrate in scons test suite. Le 26 sept. 2013 à 14:16, Gary Oberbrunner a écrit : > > On Thu, Sep 26, 2013 at 8:11 AM, wrote: > Hi, > By the way, did you review mine? ( > https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff > ) > > I saw it, Alexandre -- it's definitely in the queue, and on simple inspection > it looks OK. I just want to make sure that that's the best way to fix it. > Do you have a test case for it? > > -- > Gary > ___ > Scons-dev mailing list > Scons-dev@scons.org > http://two.pairlist.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
On Thu, Sep 26, 2013 at 8:11 AM, wrote: > Hi, > By the way, did you review mine? ( > https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff > ) > > I saw it, Alexandre -- it's definitely in the queue, and on simple inspection it looks OK. I just want to make sure that that's the best way to fix it. Do you have a test case for it? -- Gary ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
Hi, By the way, did you review mine? ( https://bitbucket.org/scons/scons/pull-request/86/fix-http-sconstigrisorg-issues/diff ) Le 26 sept. 2013 à 13:29, Gary Oberbrunner a écrit : > > > > On Thu, Sep 26, 2013 at 6:16 AM, anatoly techtonik > wrote: > If each of these small changes requires some time foe testing and time for > review, then it is better to schedule that with separate pull requests. If > these are trivial, it is more convenient to merge it in one bunch. > > I agree, though I'd say if they are truly unrelated (even though trivial), > separate pull requests are a little better still. But as Anatoly says, it's > pretty simple for us to merge trivial changes either way. Bigger ones take > more time and review. But basically you're doing it right; all you need to > do is submit the pull request, and we'll review as soon as we can. > > -- > Gary > ___ > Scons-dev mailing list > Scons-dev@scons.org > http://two.pairlist.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
On Thu, Sep 26, 2013 at 6:16 AM, anatoly techtonik wrote: > If each of these small changes requires some time foe testing and time for > review, then it is better to schedule that with separate pull requests. If > these are trivial, it is more convenient to merge it in one bunch. > I agree, though I'd say if they are truly unrelated (even though trivial), separate pull requests are a little better still. But as Anatoly says, it's pretty simple for us to merge trivial changes either way. Bigger ones take more time and review. But basically you're doing it right; all you need to do is submit the pull request, and we'll review as soon as we can. -- Gary ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] getting changes accepted
If each of these small changes requires some time foe testing and time for review, then it is better to schedule that with separate pull requests. If these are trivial, it is more convenient to merge it in one bunch. -- anatoly t. On Thu, Sep 26, 2013 at 12:05 PM, Tom Tanner (BLOOMBERG/ LONDON) < ttann...@bloomberg.net> wrote: > What's the process for getting changes requested. Or alternatively, what's > the process for submitting several unrelated small changes? Do I have to > create a fork for each one or something? > > ___ > Scons-dev mailing list > Scons-dev@scons.org > http://two.pairlist.net/mailman/listinfo/scons-dev > > ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
[Scons-dev] getting changes accepted
What's the process for getting changes requested. Or alternatively, what's the process for submitting several unrelated small changes? Do I have to create a fork for each one or something?___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons speedup and profiling results...
On Thu, Sep 26, 2013 at 8:44 AM, Dirk Bächle wrote: > Hi Gary, > > On 26.09.2013 02:08, Gary Oberbrunner wrote: >> >> >> >> [...] >> >> >> I think this is excellent work! Solid analysis. I know there's been some >> thought given to caching subst() before; it's trickier than one might think >> but in many cases it should work, and it definitely speeds things up. I'm >> also impressed by a 30% memory reduction -- interested to hear how that >> comes out. >> > > it will definitely take some more time. Not only subst() is quite tricky, > but getting cyclic dependencies out of the way for garbage-collecting Nodes > means a lot of fiddling. But there should be some light at the end of the > tunnel soon > > By the way: Does anybody know of a use case for having more than one FS > during a build or interactive mode? I've wondered many times now, why on > earth we keep a reference to the current DefaultFS in each Node? After all I > don't see any place in the source code where I could initialize a second > one, or one that's different from the Default FS... > > >> Have you seen the speed and memory tests the buildbots used to run? Not >> sure what their status is these days but perhaps your tests could be >> integrated into them at some point. > > > Yes, I considered using them. But as far as I know, they rely on everything > that's being run to be a packaged archive and you always have to write some > sort of config file. That's what put me off a little bit, and so I stuck to > my own scripts/packages and developed them further... what are the main things which make waf, and wonderbuild so much faster than scons? a test is here, but already a little outdated: http://retropaganda.info/~bohan/work/psycle/branches/bohan/wonderbuild/benchmarks/time.xml rupert. ___ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
