Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
Pull request created: https://bitbucket.org/scons/scons/pull-request/186/attempt-to-fix-versionned-shared-library Le 19 sept. 2014 à 22:54, alexandre.feb...@gmail.com a écrit : > I may, but I'm pretty sure my patch is OK for me but only for me, and I've no > real clue on what is the correct way to fix this in all situations. > > Le 19 sept. 2014 à 21:48, William Blevins a écrit : > >> Would you mind making a pull request via Bitbucket? >> >> On Sep 19, 2014 1:03 PM, "Alexandre Feblot" wrote: >> The change on SCons/Tool/__init__.py line 308 was a bad idea, it broke >> Solaris build. >> Attached is my final patch which seem to work properly. >> >> 2014-09-19 17:36 GMT+02:00 Alexandre Feblot : >> So, I fixed point 2 by adding the same kind of fixes ( or platform == >> 'sunos') on : >> >> * required for sure: >> SCons/Tool/__init__.py line 259 >> >> SCons/Tool/__init__.py line 308 >> >> >> * not required but seems related, I don't really know: >> SCons/Tool/install.py" line 152 >> >> SCons/Tool/install.py" line 163 >> >> >> 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : >> Hi, >> >> as the title says, it fails with the following error:" IndexError: list >> index out of range" in SCons/Tool/link.py. >> >> The reason is that versionned shared lib seem to be handled properly for >> unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" >> rather than "posix". >> >> >> I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or >> platform == 'sunos':, but >> This is an ugly fix which does not take into account other unixes which >> probably fail the same way. In fact, 'posix' is not at the same meaning >> level as 'sunos'. Shouldn't PLATFORM be set to something like 'linux' on >> linux, and a posix flag to be set for all posix platforms? >> This just fixes part of the issue. It now does create the lib with its >> version number, but not the 2 symlinks (and I don't really kow where to >> search for that. Any hint will be welcome). >> >> Note: I'd be happy to fill a bug, but should this still be done on Tigris, >> with ongoing migrations to new bug trackers (and I'm totally lost with the >> current status of these migrations)? >> >> Attached: the smallest example to reproduce the issue. >> >> >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
I may, but I'm pretty sure my patch is OK for me but only for me, and I've no real clue on what is the correct way to fix this in all situations. Le 19 sept. 2014 à 21:48, William Blevins a écrit : > Would you mind making a pull request via Bitbucket? > > On Sep 19, 2014 1:03 PM, "Alexandre Feblot" wrote: > The change on SCons/Tool/__init__.py line 308 was a bad idea, it broke > Solaris build. > Attached is my final patch which seem to work properly. > > 2014-09-19 17:36 GMT+02:00 Alexandre Feblot : > So, I fixed point 2 by adding the same kind of fixes ( or platform == > 'sunos') on : > > * required for sure: > SCons/Tool/__init__.py line 259 > > SCons/Tool/__init__.py line 308 > > > * not required but seems related, I don't really know: > SCons/Tool/install.py" line 152 > > SCons/Tool/install.py" line 163 > > > 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : > Hi, > > as the title says, it fails with the following error:" IndexError: list index > out of range" in SCons/Tool/link.py. > > The reason is that versionned shared lib seem to be handled properly for > unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" > rather than "posix". > > > I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or > platform == 'sunos':, but > This is an ugly fix which does not take into account other unixes which > probably fail the same way. In fact, 'posix' is not at the same meaning level > as 'sunos'. Shouldn't PLATFORM be set to something like 'linux' on linux, and > a posix flag to be set for all posix platforms? > This just fixes part of the issue. It now does create the lib with its > version number, but not the 2 symlinks (and I don't really kow where to > search for that. Any hint will be welcome). > > Note: I'd be happy to fill a bug, but should this still be done on Tigris, > with ongoing migrations to new bug trackers (and I'm totally lost with the > current status of these migrations)? > > Attached: the smallest example to reproduce the issue. > > > > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev > > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
Would you mind making a pull request via Bitbucket? On Sep 19, 2014 1:03 PM, "Alexandre Feblot" wrote: > The change on SCons/Tool/__init__.py line 308 was a bad idea, it broke > Solaris build. > Attached is my final patch which seem to work properly. > > 2014-09-19 17:36 GMT+02:00 Alexandre Feblot : > >> So, I fixed point 2 by adding the same kind of fixes ( or platform == >> 'sunos') on : >> >> * required for sure: >> >> SCons/Tool/__init__.py line 259 >> >> SCons/Tool/__init__.py line 308 >> >> * not required but seems related, I don't really know: >> >> SCons/Tool/install.py" line 152 >> >> SCons/Tool/install.py" line 163 >> >> 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : >> >>> Hi, >>> >>> as the title says, it fails with the following error:" IndexError: list >>> index out of range" in SCons/Tool/link.py. >>> >>> The reason is that versionned shared lib seem to be handled properly for >>> unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" >>> rather than "posix". >>> >>> >>> I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' >>> or platform == 'sunos':, but >>> >>>1. This is an ugly fix which does not take into account other unixes >>>which probably fail the same way. In fact, 'posix' is not at the same >>>meaning level as 'sunos'. Shouldn't PLATFORM be set to something like >>>'linux' on linux, and a posix flag to be set for all posix platforms? >>>2. This just fixes part of the issue. It now does create the lib >>>with its version number, but not the 2 symlinks (and I don't really kow >>>where to search for that. Any hint will be welcome). >>> >>> >>> Note: I'd be happy to fill a bug, but should this still be done on >>> Tigris, with ongoing migrations to new bug trackers (and I'm totally lost >>> with the current status of these migrations)? >>> >>> Attached: the smallest example to reproduce the issue. >>> >> >> > > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev > > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
The change on SCons/Tool/__init__.py line 308 was a bad idea, it broke Solaris build. Attached is my final patch which seem to work properly. 2014-09-19 17:36 GMT+02:00 Alexandre Feblot : > So, I fixed point 2 by adding the same kind of fixes ( or platform == > 'sunos') on : > > * required for sure: > > SCons/Tool/__init__.py line 259 > > SCons/Tool/__init__.py line 308 > > * not required but seems related, I don't really know: > > SCons/Tool/install.py" line 152 > > SCons/Tool/install.py" line 163 > > 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : > >> Hi, >> >> as the title says, it fails with the following error:" IndexError: list >> index out of range" in SCons/Tool/link.py. >> >> The reason is that versionned shared lib seem to be handled properly for >> unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" >> rather than "posix". >> >> >> I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or >> platform == 'sunos':, but >> >>1. This is an ugly fix which does not take into account other unixes >>which probably fail the same way. In fact, 'posix' is not at the same >>meaning level as 'sunos'. Shouldn't PLATFORM be set to something like >>'linux' on linux, and a posix flag to be set for all posix platforms? >>2. This just fixes part of the issue. It now does create the lib with >>its version number, but not the 2 symlinks (and I don't really kow where >> to >>search for that. Any hint will be welcome). >> >> >> Note: I'd be happy to fill a bug, but should this still be done on >> Tigris, with ongoing migrations to new bug trackers (and I'm totally lost >> with the current status of these migrations)? >> >> Attached: the smallest example to reproduce the issue. >> > > scons-2.3.3.fixSolarisVersionnedSharedLib.patch Description: Binary data ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
So, I fixed point 2 by adding the same kind of fixes ( or platform == 'sunos') on : * required for sure: SCons/Tool/__init__.py line 259 SCons/Tool/__init__.py line 308 * not required but seems related, I don't really know: SCons/Tool/install.py" line 152 SCons/Tool/install.py" line 163 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : > Hi, > > as the title says, it fails with the following error:" IndexError: list > index out of range" in SCons/Tool/link.py. > > The reason is that versionned shared lib seem to be handled properly for > unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" > rather than "posix". > > > I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or > platform == 'sunos':, but > >1. This is an ugly fix which does not take into account other unixes >which probably fail the same way. In fact, 'posix' is not at the same >meaning level as 'sunos'. Shouldn't PLATFORM be set to something like >'linux' on linux, and a posix flag to be set for all posix platforms? >2. This just fixes part of the issue. It now does create the lib with >its version number, but not the 2 symlinks (and I don't really kow where to >search for that. Any hint will be welcome). > > > Note: I'd be happy to fill a bug, but should this still be done on Tigris, > with ongoing migrations to new bug trackers (and I'm totally lost with the > current status of these migrations)? > > Attached: the smallest example to reproduce the issue. > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
[Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
Hi, as the title says, it fails with the following error:" IndexError: list index out of range" in SCons/Tool/link.py. The reason is that versionned shared lib seem to be handled properly for unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" rather than "posix". I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or platform == 'sunos':, but 1. This is an ugly fix which does not take into account other unixes which probably fail the same way. In fact, 'posix' is not at the same meaning level as 'sunos'. Shouldn't PLATFORM be set to something like 'linux' on linux, and a posix flag to be set for all posix platforms? 2. This just fixes part of the issue. It now does create the lib with its version number, but not the 2 symlinks (and I don't really kow where to search for that. Any hint will be welcome). Note: I'd be happy to fill a bug, but should this still be done on Tigris, with ongoing migrations to new bug trackers (and I'm totally lost with the current status of these migrations)? Attached: the smallest example to reproduce the issue. bugSconsSharedLib.tar Description: Unix tar archive ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
