Re: [SeaBIOS] [PATCH 0/2] use full io address space on q35
On Mo, 2014-05-12 at 11:00 -0400, Kevin O'Connor wrote: On Mon, May 12, 2014 at 03:28:25PM +0200, Gerd Hoffmann wrote: Hi, This patch adds a config option to move PORT_ACPI_PM_BASE, then use the full I/O address space on q35. Patches have been sent already a few months back, but IIRC we didn't came to a final conclusion. Resending rebased + with minor help text update to re-kick discussion. Were you looking for this series to be included into the upcoming release? Would be nice to have it in, yes. My concern with the series is patch 1 - I don't think we should be adding a compile time config setting for what I believe should be detected at runtime. New series with runtime detection just posted. cheers, Gerd ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
[SeaBIOS] [PATCH 0/2] use full io address space on q35
Hi, This patch adds a config option to move PORT_ACPI_PM_BASE, then use the full I/O address space on q35. Patches have been sent already a few months back, but IIRC we didn't came to a final conclusion. Resending rebased + with minor help text update to re-kick discussion. cheers, Gerd Gerd Hoffmann (2): Add config option to move PORT_ACPI_PM_BASE out of the way Allow using full io region on q35 src/Kconfig | 7 +++ src/fw/paravirt.h | 9 +++-- src/fw/pciinit.c | 16 +--- 3 files changed, 23 insertions(+), 9 deletions(-) -- 1.8.3.1 ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH 0/2] use full io address space on q35
On Mon, May 12, 2014 at 03:28:25PM +0200, Gerd Hoffmann wrote: Hi, This patch adds a config option to move PORT_ACPI_PM_BASE, then use the full I/O address space on q35. Patches have been sent already a few months back, but IIRC we didn't came to a final conclusion. Resending rebased + with minor help text update to re-kick discussion. Were you looking for this series to be included into the upcoming release? My concern with the series is patch 1 - I don't think we should be adding a compile time config setting for what I believe should be detected at runtime. It would seem to me that the QEMU-firmware interfaces would be simpler if QEMU just passed the desired iobase to the firmware. (I understand the setting may be needed early in the bootstrap process, but a fw_cfg file could be at a static address, which could then be read during bootstrap with only a few instructions.) However, if passing the iobase from QEMU to firmware isn't an option, then I think SeaBIOS should at least detect at runtime if it is running on a QEMU version that supports a dynamic iobase. Am I missing something? -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
