Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
On Wed, May 15, 2013 at 03:27:39PM +0800, Hu Tao wrote:
On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote:
On 04/05/13 09:17, Hu Tao wrote:
+Method(RDPT, 0, NotSerialized) {
+Store(PEPT, Local0)
+Return (Local0)
+}
+
+Method(WRPT, 1, NotSerialized) {
+Store(Arg0, PEPT)
+}
Please excuse my asking, I haven't been following this -- who's supposed
to call these methods? The latest guest kernel patch I managed to find
([PATCH v7] kvm: notify host when the guest is panicked -- probably
obsolete by now) appears to do a direct outl().
An old version calls WRPT but is buggy, so you see the outl version.
This patch is in seabios before the outl version. If you think these
methods are needless, feel free to send a patch.
I mean v19 by outl verson. Sorry for confusing.
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
(Not sure why the CC list has grown this huge, but I'm adding Drew for
good mesaure.)
On 05/15/13 09:27, Hu Tao wrote:
On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote:
On 04/05/13 09:17, Hu Tao wrote:
+Method(RDPT, 0, NotSerialized) {
+Store(PEPT, Local0)
+Return (Local0)
+}
+
+Method(WRPT, 1, NotSerialized) {
+Store(Arg0, PEPT)
+}
Please excuse my asking, I haven't been following this -- who's supposed
to call these methods? The latest guest kernel patch I managed to find
([PATCH v7] kvm: notify host when the guest is panicked -- probably
obsolete by now) appears to do a direct outl().
An old version calls WRPT but is buggy, so you see the outl version.
This patch is in seabios before the outl version. If you think these
methods are needless, feel free to send a patch.
After Drew located the guest kernel commit for me,
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=8b10acd7
I can see this SeaBIOS patch *is* necessary -- even though the RDPT /
WRPT methods are not used for port access, the port number itself is
available from ACPI (\_SB.PCI0.ISA.PEVT._CRS, identified by the
QEMU0001 HID) to the kernel.
Hu, can you (and are you willing to) relicense this commit (seabios
commit e9725dd7) under the 2-clause BSDL so I can port it to OVMF?
(Actually I'm somewhat confused because the first S-o-b is from Paolo.
Since I share an employer with Paolo, getting permission from Paolo
would be either quite easy or even unnecessary. Anyway it's better to ask!)
Thanks,
Laszlo
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
Il 15/05/2013 18:25, Laszlo Ersek ha scritto:
(Not sure why the CC list has grown this huge, but I'm adding Drew for
good mesaure.)
On 05/15/13 09:27, Hu Tao wrote:
On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote:
On 04/05/13 09:17, Hu Tao wrote:
+Method(RDPT, 0, NotSerialized) {
+Store(PEPT, Local0)
+Return (Local0)
+}
+
+Method(WRPT, 1, NotSerialized) {
+Store(Arg0, PEPT)
+}
Please excuse my asking, I haven't been following this -- who's supposed
to call these methods? The latest guest kernel patch I managed to find
([PATCH v7] kvm: notify host when the guest is panicked -- probably
obsolete by now) appears to do a direct outl().
An old version calls WRPT but is buggy, so you see the outl version.
This patch is in seabios before the outl version. If you think these
methods are needless, feel free to send a patch.
After Drew located the guest kernel commit for me,
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=8b10acd7
I can see this SeaBIOS patch *is* necessary -- even though the RDPT /
WRPT methods are not used for port access, the port number itself is
available from ACPI (\_SB.PCI0.ISA.PEVT._CRS, identified by the
QEMU0001 HID) to the kernel.
Hu, can you (and are you willing to) relicense this commit (seabios
commit e9725dd7) under the 2-clause BSDL so I can port it to OVMF?
(Actually I'm somewhat confused because the first S-o-b is from Paolo.
Since I share an employer with Paolo, getting permission from Paolo
would be either quite easy or even unnecessary. Anyway it's better to ask!)
I and Hu did half of the patch each. :)
But I think it's simpler to avoid OVMF and wait for the time when QEMU
will produce the ACPI tables.
Paolo
___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
On 05/04/13 09:17, Hu Tao wrote: pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Another question: are you planning to provide libvirt support? Currently I see the guest as paused after a crash. Since there is a crashed state in libvirt it might make sense to use that. Christian ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
Il 05/04/2013 09:17, Hu Tao ha scritto: pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- No change from v16. qemu patches at: http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg01028.html Ping. The QEMU parts will be committed shortly. Paolo ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v17] Add pvpanic device driver
On Tue, Apr 30, 2013 at 06:00:09PM +0200, Paolo Bonzini wrote: Il 05/04/2013 09:17, Hu Tao ha scritto: pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- No change from v16. qemu patches at: http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg01028.html Ping. The QEMU parts will be committed shortly. Thanks. I pushed this patch to SeaBIOS head. -Kevin ___ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
