Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Bradford Wetmore 

Hi Xuelei,

Can you put these CR requests on cr.openjdk.java.net?  I can't see them 
from home.


Brad

On 5/5/2012 8:06 AM, Xuelei Fan wrote:

The webrev URL should be:
http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

Xuelei

On 5/5/2012 9:38 PM, Xuelei Fan wrote:

Hi,

Please review the fix for JSSE certification path validation issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
not calculated properly, the non-intermediate certificate (end-entity
certificate) was count in.

Thanks,
Xuelei

Re: code review request, CR 7166487 checkSequenceNumber method never called within readRecord of SSLEngineImpl

2012-05-05 Thread David Schlosnagle 
On Sat, May 5, 2012 at 11:06 AM, Xuelei Fan  wrote:
> Please review the fix for JSSE TLS/SSL records' sequence number wrap issue.
>
> webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166487/webrev.00/

Xuelei, do you happen to have an internet facing site for this code
review as http://javaweb.us.oracle.com does not seem to be available?

Thanks,
Dave

code review request, CR 7166487 checkSequenceNumber method never called within readRecord of SSLEngineImpl

2012-05-05 Thread Xuelei Fan 
Hi,

Please review the fix for JSSE TLS/SSL records' sequence number wrap issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166487/webrev.00/

Cause of the issue: did not update the handshaking status before the
sequence number checking.

Thanks,
Xuelei

Re: code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Xuelei Fan 
The webrev URL should be:
http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev.00/

Xuelei

On 5/5/2012 9:38 PM, Xuelei Fan wrote:
> Hi,
> 
> Please review the fix for JSSE certification path validation issue.
> 
> webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/
> 
> Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
> not calculated properly, the non-intermediate certificate (end-entity
> certificate) was count in.
> 
> Thanks,
> Xuelei

code review request, CR 7166570: JSSE certificate validation has started to fail for certificate chains

2012-05-05 Thread Xuelei Fan 
Hi,

Please review the fix for JSSE certification path validation issue.

webrev: http://javaweb.us.oracle.com/~xufan/bugbios/7166570/webrev/

Cause of the issue: in SimpleValiadtor, the count pathLenConstraint was
not calculated properly, the non-intermediate certificate (end-entity
certificate) was count in.

Thanks,
Xuelei