hg: jdk8/tl/jdk: 7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows

2012-05-17 Thread xuelei . fan 
Changeset: 9fe6ebbe5895
Author:xuelei
Date:  2012-05-17 21:59 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fe6ebbe5895

7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows
Reviewed-by: vinnie, wetmore

! test/sun/security/mscapi/ShortRSAKey1024.sh
! test/sun/security/mscapi/ShortRSAKey512.sh
! test/sun/security/mscapi/ShortRSAKey768.sh

Re: Code Review Request for 7169496

2012-05-17 Thread Vincent Ryan 

Those changes look fine.
Thanks.

On 17/05/2012 19:51, Valerie (Yu-Ching) Peng wrote:

Vinnie,

Can you please review this?
http://cr.openjdk.java.net./~valeriep/7169496/webrev.00/

The changes are quite straight forward - remove SHA224withRSA sig due to
the lack of window alg id.
Thanks,
Valerie

hg: jdk8/tl/jdk: 7168110: Misleading jstack error message

2012-05-17 Thread rob . mckenna 
Changeset: 178c480998b1
Author:robm
Date:  2012-05-17 22:42 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/178c480998b1

7168110: Misleading jstack error message
Reviewed-by: alanb, dsamersoff

! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c

Code Review Request for 7169496

2012-05-17 Thread Valerie (Yu-Ching) Peng 

Vinnie,

Can you please review this?
http://cr.openjdk.java.net./~valeriep/7169496/webrev.00/

The changes are quite straight forward - remove SHA224withRSA sig due to 
the lack of window alg id.

Thanks,
Valerie

Re: Code review request, 7145960 sun/security/mscapi/ShortRSAKey1024.sh failing on windows

2012-05-17 Thread Bradford Wetmore 

Looks good to me also.

Brad




On 5/17/2012 6:24 AM, Vincent Ryan wrote:

Your fix looks fine. However you don't need to modify the file-separator
on Windows - both forms are supported in pathnames.


On 05/17/12 01:54 PM, Xuelei Fan wrote:

Hi,

Please review the fix of test cases in Windows.

webrev: http://cr.openjdk.java.net./~xuelei/7145960/webrev.00/

Cause of the issue: when keytool cannot generate key pairs in Windows
system, we should exit the testing.

Thanks,
Xuelei

hg: jdk8/tl/jdk: 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231

2012-05-17 Thread daniel . daugherty 
Changeset: ce165aa48dcb
Author:dcubed
Date:  2012-05-17 06:26 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce165aa48dcb

7168520: No jdk8 TL Nightly linux builds due to broken link in 
b39-2012-05-13_231
Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora 
doesn't like dangling symlinks
Reviewed-by: katleman

! make/java/redist/Makefile

Re: Code review request, 7145960 sun/security/mscapi/ShortRSAKey1024.sh failing on windows

2012-05-17 Thread Vincent Ryan 
Your fix looks fine. However you don't need to modify the file-separator 
on Windows - both forms are supported in pathnames.



On 05/17/12 01:54 PM, Xuelei Fan wrote:

Hi,

Please review the fix of test cases in Windows.

webrev: http://cr.openjdk.java.net./~xuelei/7145960/webrev.00/

Cause of the issue: when keytool cannot generate key pairs in Windows
system, we should exit the testing.

Thanks,
Xuelei

Code review request, 7145960 sun/security/mscapi/ShortRSAKey1024.sh failing on windows

2012-05-17 Thread Xuelei Fan 
Hi,

Please review the fix of test cases in Windows.

webrev: http://cr.openjdk.java.net./~xuelei/7145960/webrev.00/

Cause of the issue: when keytool cannot generate key pairs in Windows
system, we should exit the testing.

Thanks,
Xuelei