Re: code review request: 7170308: timing error in the krb5 test SSL.java
Looks fine to me.
Xuelei
On 5/21/2012 1:43 PM, Weijun Wang wrote:
How about this?
http://cr.openjdk.java.net/~weijun/7170308/webrev.01/
The flag is now a state.
Thanks
Max
On 05/21/2012 11:23 AM, Xuelei Fan wrote:
A minor comment.
There may be a potential dead loop in client/main block. If the server
runs into exception before set the serverReady, the client will deadly
wait for the setting.
I think it may be a little safer to have the set of serverReady in a
final clause.
try {
SSLServerSocketFactory sslssf =
...
} finally {
serverReady = true;
}
Xuelei
On 5/21/2012 10:52 AM, Weijun Wang wrote:
Hi Xuelei
I've adopted your style of synchronizing the SSL client and server.
Please take a review at
http://cr.openjdk.java.net/~weijun/7170308/webrev.00/
Noreg-self.
Thanks
Max
On 05/21/2012 10:14 AM, weijun.w...@oracle.com wrote:
*Change Request ID*: 7170308
*Synopsis*: timing error in the krb5 test SSL.java
=== *Description*
In the test the client side waits 2 seconds for the server to start,
but on some machines this is still not enough. We should using a flag
to synchronize their actions.
hg: jdk8/tl/jdk: 7170308: timing error in the krb5 test SSL.java
Changeset: 72af24348b2b Author:weijun Date: 2012-05-21 15:40 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72af24348b2b 7170308: timing error in the krb5 test SSL.java Reviewed-by: xuelei ! test/sun/security/krb5/auto/SSL.java
RFR: 7169257: Fix for 6424631 only partially ported to JDK 7 JDK 8
Recently noticed that the 6424631 fix was not fully ported to the JDK 7 workspace. Porting the changes (to 8 7) so that no regression is seen for users migrating to latest JDK families. bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169257 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7169257.jdk8/ regards, Sean.
Re: RFR: 7169257: Fix for 6424631 only partially ported to JDK 7 JDK 8
The changes look good. --Sean On 5/21/12 6:25 AM, Seán Coffey wrote: Recently noticed that the 6424631 fix was not fully ported to the JDK 7 workspace. Porting the changes (to 8 7) so that no regression is seen for users migrating to latest JDK families. bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169257 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7169257.jdk8/ regards, Sean.
Re: RFR: 7169257: Fix for 6424631 only partially ported to JDK 7 JDK 8
Thanks Sean, Further testing has thrown up a testcase failure. (recursion in Policy setup) - This one skipped by me prior to logging RFR. Let me look into it and get back with an updated webrev. Regards, Sean. On 21/05/12 13:37, Sean Mullan wrote: The changes look good. --Sean On 5/21/12 6:25 AM, Seán Coffey wrote: Recently noticed that the 6424631 fix was not fully ported to the JDK 7 workspace. Porting the changes (to 8 7) so that no regression is seen for users migrating to latest JDK families. bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169257 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7169257.jdk8/ regards, Sean.
hg: jdk8/tl/jdk: 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434
Changeset: f109feb13698 Author:ksrini Date: 2012-05-21 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f109feb13698 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434 Reviewed-by: ohair ! test/tools/launcher/Arrrghs.java
hg: jdk8/tl/jdk: 7167157: jcmd command file parsing does not respect the stop command
Changeset: 0a1ef7e07e01 Author:sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 7167157: jcmd command file parsing does not respect the stop command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java
