Code review request: 7194472: FileKeyTab.java test fails on Windows

2012-08-27 Thread Weijun Wang

Sorry, there is a problem in the test of my recent fix at

  http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61ddc8ce7f3b

Here is a webrev

  http://cr.openjdk.java.net/~weijun/7194472/webrev.00/

"/" is treated as a universal File.separatorChar in JAAS config files.

Noreg-self.

Thanks
Max

 Original Message 
7194472: FileKeyTab.java test fails on Windows
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194472

  Product: java
  Category: java
  Subcategory: classes_security

=== *Description* 

The newly added FileKeyTab.java test fails on Windows because it creates 
a file


  server {
com.sun.security.auth.module.Krb5LoginModule required
principal="server/host.rabbit.hole"
debug=true useKeyTab=true
keyTab="file:C:\tmp\RR1\W\scratch\localkdc.ktab"
storeKey=true;
  };

Here the keyTab line is illegal before JAAS config file is parsed with a 
StreamTokenizer and "\" is treated as a escape char.




JDK 8 Code review request for 7179715: Reason of CertPathValidatorException should be UNDETERMINED_REVOCATION_STATUS if OCSP request failed

2012-08-27 Thread Sean Mullan
Please review my webrev for 7179715:

http://cr.openjdk.java.net/~mullan/webrevs/7192896/webrev.00/

The bugid is not accessible for some reason. Essentially this is a simple fix to
set the reason of the CertPathValidatorException to
UNDETERMINED_REVOCATION_STATUS if a network failure prevents us from determining
if a certificate has been revoked or not.

Thanks,
Sean


hg: jdk8/tl/jdk: 14 new changesets

2012-08-27 Thread lana . steuck
Changeset: 05e5ce861a58
Author:jrose
Date:  2012-07-12 00:10 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05e5ce861a58

7153157: ClassValue.get does not return if computeValue calls remove
Summary: Track intermediate states more precisely, according to spec.
Reviewed-by: twisti, forax

! src/share/classes/java/lang/ClassValue.java

Changeset: beeb1d5ecd9e
Author:jrose
Date:  2012-07-12 00:11 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/beeb1d5ecd9e

7129034: VM crash with a field setter method with a filterArguments
Summary: add null checks before unsafe calls that take a variable base 
reference; update unit tests
Reviewed-by: kvn, twisti

! src/share/classes/java/lang/invoke/MethodHandleImpl.java
! test/java/lang/invoke/MethodHandlesTest.java

Changeset: 556141c6326c
Author:jrose
Date:  2012-07-12 00:12 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/556141c6326c

7087658: MethodHandles.Lookup.findVirtual is confused by interface methods that 
are multiply inherited
Reviewed-by: twisti

! src/share/classes/java/lang/invoke/MemberName.java

Changeset: 78f1f4e4e9c7
Author:jrose
Date:  2012-07-12 00:12 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78f1f4e4e9c7

7127687: MethodType leaks memory due to interning
Summary: Replace internTable with a weak-reference version.
Reviewed-by: sundar, forax, brutisso
Contributed-by: james.las...@oracle.com

! src/share/classes/java/lang/invoke/MethodType.java

Changeset: 050116960e99
Author:twisti
Date:  2012-07-24 10:47 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/050116960e99

7023639: JSR 292 method handle invocation needs a fast path for compiled code
6984705: JSR 292 method handle creation should not go through JNI
Summary: remove assembly code for JDK 7 chained method handles
Reviewed-by: jrose, twisti, mhaupt, forax
Contributed-by: John Rose , Christian Thalinger 
, Michael Haupt 

- src/share/classes/java/lang/invoke/AdapterMethodHandle.java
! src/share/classes/java/lang/invoke/BoundMethodHandle.java
! src/share/classes/java/lang/invoke/CallSite.java
- src/share/classes/java/lang/invoke/CountingMethodHandle.java
! src/share/classes/java/lang/invoke/DirectMethodHandle.java
+ src/share/classes/java/lang/invoke/DontInline.java
+ src/share/classes/java/lang/invoke/ForceInline.java
+ src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
! src/share/classes/java/lang/invoke/Invokers.java
+ src/share/classes/java/lang/invoke/LambdaForm.java
! src/share/classes/java/lang/invoke/MemberName.java
! src/share/classes/java/lang/invoke/MethodHandle.java
! src/share/classes/java/lang/invoke/MethodHandleImpl.java
+ src/share/classes/java/lang/invoke/MethodHandleInfo.java
! src/share/classes/java/lang/invoke/MethodHandleNatives.java
! src/share/classes/java/lang/invoke/MethodHandleStatics.java
! src/share/classes/java/lang/invoke/MethodHandles.java
! src/share/classes/java/lang/invoke/MethodType.java
! src/share/classes/java/lang/invoke/MethodTypeForm.java
+ src/share/classes/java/lang/invoke/SimpleMethodHandle.java
! src/share/classes/java/lang/invoke/package-info.java
! src/share/classes/sun/invoke/util/ValueConversions.java
! src/share/classes/sun/invoke/util/VerifyAccess.java
! src/share/classes/sun/invoke/util/VerifyType.java
! src/share/classes/sun/invoke/util/Wrapper.java
! src/share/classes/sun/misc/Unsafe.java
+ test/java/lang/invoke/7157574/Test7157574.java
! test/java/lang/invoke/InvokeGenericTest.java
! test/java/lang/invoke/JavaDocExamplesTest.java
+ test/java/lang/invoke/MaxTest.java
! test/java/lang/invoke/MethodHandlesTest.java
+ test/java/lang/invoke/PrivateInvokeTest.java
! test/java/lang/invoke/ThrowExceptionsTest.java
+ test/java/lang/invoke/remote/RemoteExample.java
! test/sun/invoke/util/ValueConversionsTest.java

Changeset: 64e24cc8e009
Author:twisti
Date:  2012-08-07 14:31 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64e24cc8e009

7188911: nightly failures after JSR 292 lazy method handle update (round 2)
Reviewed-by: kvn, jrose

! src/share/classes/java/lang/invoke/BoundMethodHandle.java
! src/share/classes/java/lang/invoke/MemberName.java

Changeset: e1d063685dc8
Author:twisti
Date:  2012-08-09 15:03 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1d063685dc8

7190416: JSR 292: typo in InvokerBytecodeGenerator.getConstantPoolSize
Reviewed-by: jrose

! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java

Changeset: 865c411ebcae
Author:twisti
Date:  2012-08-10 16:03 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/865c411ebcae

Merge

- src/share/classes/java/lang/invoke/AdapterMethodHandle.java
- src/share/classes/java/lang/invoke/CountingMethodHandle.java

Changeset: 93ddd9560751
Author:youdwei
Date:  2012-08-13 10:45 +0800
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93ddd9560751

7189611: Venezuela current Currency should be Bs.F.
Reviewed

hg: jdk8/tl/hotspot: 12 new changesets

2012-08-27 Thread lana . steuck
Changeset: ef437ea56651
Author:amurillo
Date:  2012-08-03 13:24 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ef437ea56651

7189086: new hotspot build - hs24-b20
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 1d7922586cf6
Author:twisti
Date:  2012-07-24 10:51 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1d7922586cf6

7023639: JSR 292 method handle invocation needs a fast path for compiled code
6984705: JSR 292 method handle creation should not go through JNI
Summary: remove assembly code for JDK 7 chained method handles
Reviewed-by: jrose, twisti, kvn, mhaupt
Contributed-by: John Rose , Christian Thalinger 
, Michael Haupt 

! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java
! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java
- agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/Frame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCFrame.java
- agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java
- agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java
! make/solaris/makefiles/fastdebug.make
! make/solaris/makefiles/optimized.make
! make/solaris/makefiles/product.make
! src/cpu/sparc/vm/assembler_sparc.cpp
! src/cpu/sparc/vm/assembler_sparc.hpp
! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp
! src/cpu/sparc/vm/cppInterpreter_sparc.cpp
! src/cpu/sparc/vm/frame_sparc.cpp
! src/cpu/sparc/vm/interp_masm_sparc.cpp
! src/cpu/sparc/vm/interpreterGenerator_sparc.hpp
! src/cpu/sparc/vm/interpreter_sparc.cpp
! src/cpu/sparc/vm/methodHandles_sparc.cpp
! src/cpu/sparc/vm/methodHandles_sparc.hpp
! src/cpu/sparc/vm/sharedRuntime_sparc.cpp
! src/cpu/sparc/vm/stubGenerator_sparc.cpp
! src/cpu/sparc/vm/templateInterpreter_sparc.cpp
! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/sparc/vm/templateTable_sparc.hpp
! src/cpu/sparc/vm/vtableStubs_sparc.cpp
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/assembler_x86.hpp
! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp
! src/cpu/x86/vm/cppInterpreter_x86.cpp
! src/cpu/x86/vm/frame_x86.cpp
! src/cpu/x86/vm/interp_masm_x86_32.cpp
! src/cpu/x86/vm/interp_masm_x86_64.cpp
! src/cpu/x86/vm/interpreterGenerator_x86.hpp
! src/cpu/x86/vm/interpreter_x86_32.cpp
! src/cpu/x86/vm/interpreter_x86_64.cpp
! src/cpu/x86/vm/methodHandles_x86.cpp
! src/cpu/x86/vm/methodHandles_x86.hpp
! src/cpu/x86/vm/sharedRuntime_x86_32.cpp
! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
! src/cpu/x86/vm/templateInterpreter_x86_32.cpp
! src/cpu/x86/vm/templateInterpreter_x86_64.cpp
! src/cpu/x86/vm/templateTable_x86_32.cpp
! src/cpu/x86/vm/templateTable_x86_32.hpp
! src/cpu/x86/vm/templateTable_x86_64.cpp
! src/cpu/x86/vm/templateTable_x86_64.hpp
! src/cpu/x86/vm/vtableStubs_x86_32.cpp
! src/cpu/x86/vm/vtableStubs_x86_64.cpp
! src/cpu/zero/vm/cppInterpreter_zero.cpp
! src/cpu/zero/vm/interpreterGenerator_zero.hpp
! src/cpu/zero/vm/interpreter_zero.cpp
! src/share/vm/adlc/output_h.cpp
! src/share/vm/asm/assembler.cpp
! src/share/vm/asm/assembler.hpp
! src/share/vm/asm/register.hpp
! src/share/vm/c1/c1_Canonicalizer.cpp
! src/share/vm/c1/c1_Canonicalizer.hpp
! src/share/vm/c1/c1_Compilation.cpp
! src/share/vm/c1/c1_FrameMap.cpp
! src/share/vm/c1/c1_FrameMap.hpp
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_GraphBuilder.hpp
! src/share/vm/c1/c1_Instruction.cpp
! src/share/vm/c1/c1_Instruction.hpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_InstructionPrinter.hpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LIRGenerator.hpp
! src/share/vm/c1/c1_Optimizer.cpp
! src/share/vm/c1/c1_ValueMap.hpp
! src/share/vm/c1/c1_ValueStack.cpp
! src/share/vm/c1/c1_ValueStack.hpp
! src/share/vm/c1/c1_ValueType.cpp
! src/share/vm/c1/c1_ValueType.hpp
! src/share/vm/ci/bcEscapeAnalyzer.cpp
! src/share/vm/ci/ciClassList.hpp
! src/share/vm/ci/ciEnv.cpp
+ src/share/vm/ci/ciMemberName.cpp
+ src/share/vm/ci/ciMemberName.hpp
! src/share/vm/ci/ciMethod.cpp
! src/share/vm/ci/ciMethod.hpp
! src/share/vm/ci/ciMethodHandle.cpp
! src/share/vm/ci/ciMethodHandle.hpp
! src/share/vm/ci/ciObject.hpp
! src/share/vm/ci/ciObjectFactory.cpp
! src/share/vm/ci/ciSignature.hpp
! src/share/vm/ci/ciStreams.cpp
! src/share/vm/ci/ciStreams.hpp
! src/share/vm/ci/ciSymbol.cpp
! src/share/vm/ci/ciSymbol.hpp
! src/share/vm/ci/ciTypeFlow.cpp
! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp
! src/share/vm/classfile/javaClasses.cpp
! src/share/vm/classfile/javaClasses.hpp
! src/share/vm/classfile/symbolTable.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/classfile/systemDictionary.hpp
! src/share/vm/classfile/vmSymbols.cpp
! src/share/

hg: jdk8/tl/jaxws: 2 new changesets

2012-08-27 Thread lana . steuck
Changeset: 8a35fd644d3c
Author:katleman
Date:  2012-08-16 11:43 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8a35fd644d3c

Added tag jdk8-b52 for changeset f62bc618122e

! .hgtags

Changeset: 91970935926a
Author:katleman
Date:  2012-08-23 12:27 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/91970935926a

Added tag jdk8-b53 for changeset 8a35fd644d3c

! .hgtags



hg: jdk8/tl/langtools: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: d3d0b9cd76e0
Author:katleman
Date:  2012-08-16 11:43 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d3d0b9cd76e0

Added tag jdk8-b52 for changeset 1d2db0e5eabc

! .hgtags

Changeset: 9cf72631baf5
Author:katleman
Date:  2012-08-23 12:27 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9cf72631baf5

Added tag jdk8-b53 for changeset d3d0b9cd76e0

! .hgtags

Changeset: 542c87b8ce7f
Author:lana
Date:  2012-08-27 10:59 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/542c87b8ce7f

Merge




hg: jdk8/tl/jaxp: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: 2c566f25c39f
Author:katleman
Date:  2012-08-16 11:43 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2c566f25c39f

Added tag jdk8-b52 for changeset bd3c00d57614

! .hgtags

Changeset: 7dd81ccb7c11
Author:katleman
Date:  2012-08-23 12:27 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7dd81ccb7c11

Added tag jdk8-b53 for changeset 2c566f25c39f

! .hgtags

Changeset: 933d0234670f
Author:lana
Date:  2012-08-27 10:55 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/933d0234670f

Merge




hg: jdk8/tl/corba: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: 63aeb7a2472f
Author:katleman
Date:  2012-08-16 11:43 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/corba/rev/63aeb7a2472f

Added tag jdk8-b52 for changeset 80689ff9cb49

! .hgtags

Changeset: 16c82fc74695
Author:katleman
Date:  2012-08-23 12:27 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/corba/rev/16c82fc74695

Added tag jdk8-b53 for changeset 63aeb7a2472f

! .hgtags

Changeset: d086e67eb9dd
Author:lana
Date:  2012-08-27 10:54 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/corba/rev/d086e67eb9dd

Merge




hg: jdk8/tl/langtools: 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes.

2012-08-27 Thread kumar . x . srinivasan
Changeset: c9749226cdde
Author:ksrini
Date:  2012-08-27 07:21 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c9749226cdde

7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes.
Reviewed-by: jjg
Contributed-by: jan.lah...@oracle.com

! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java