Re: 7u8 Code Review Request for 7107613, 7107616, 7185471

2012-08-29 Thread Valerie (Yu-Ching) Peng 

The changes look fine.
Thanks,
Valerie

On 08/28/12 13:25, Seán Coffey wrote:
Looking for a code review around the following perf. related backports 
to JDK 7u8. The changesets didn't apply cleanly but there was no major 
code differences encountered while porting.


Builds and security tests ran fine.

7107616: scalability blocker in javax.crypto.JceSecurityManager
jdk 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/175036ada2e3
7u webrev : http://cr.openjdk.java.net/~coffeys/webrev.7107616.7u/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7107616

7107613: scalability blocker in javax.crypto.CryptoPermissions
jdk 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/114fbbeb8f75
7u webrev :  http://cr.openjdk.java.net/~coffeys/webrev.7107613.7u/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7107613

7185471: Avoid key expansion when AES cipher is re-init w/ the same key
jdk 8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e97dacbfd35
7u webrev : http://cr.openjdk.java.net/~coffeys/webrev.7185471.7u/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7185471


Regards,
Sean.

Re: Code review request for JEP-121

2012-08-29 Thread Vincent Ryan 

On 06/ 1/12 07:18 PM, Vincent Ryan wrote:

Hello Valerie,

Could you please review these changes for JEP-121:
http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/

Thanks.



The latest webrev is now available at:

  http://cr.openjdk.java.net/~vinnie/6383200/webrev.02/

I've incorporated review comments and made some fixes
to the implementation of AES-based PBE algorithms.

Thanks.