Code review request, 7199066 Typo in method name
Hi, Please review the trivial fix of a typo in internal method name. The bug has not been shown in bug database. The method name, "getSuportedCipherSuiteList", of SSLContextImpl should be "getSupportedCipherSuiteList" webrev: http://cr.openjdk.java.net/~xuelei/7199066/webrev.00/ Thanks, Xuelei
hg: jdk8/tl/jdk: 7198988: re-order paramaters for Collision.java @run
Changeset: e20a2e6a92f7 Author:mduigou Date: 2012-09-17 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e20a2e6a92f7 7198988: re-order paramaters for Collision.java @run Reviewed-by: alanb ! test/java/util/Map/Collisions.java
hg: jdk8/tl/jdk: 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt
Changeset: 39e97f68fa8c Author:sla Date: 2012-09-17 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39e97f68fa8c 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt
hg: jdk8/tl/jdk: 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive
Changeset: 8a454e92aaf1 Author:sla Date: 2012-09-17 12:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a454e92aaf1 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive Reviewed-by: alanb ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java
Re: code review request: 7198901: correct the field size check when decoding a point on ECC curve
Thanks. On 17 Sep 2012, at 17:27, Xuelei Fan wrote: > Looks fine to me. > > Xuelei > > On 9/17/2012 10:57 PM, Vincent Ryan wrote: >> Please review the following change for JDK8: >> >> http://cr.openjdk.java.net/~vinnie/7198901/ >> >> It corrects the field size check when decoding an EC point. >> >> Thanks. >> >
Re: code review request: 7198901: correct the field size check when decoding a point on ECC curve
Looks fine to me. Xuelei On 9/17/2012 10:57 PM, Vincent Ryan wrote: > Please review the following change for JDK8: > >http://cr.openjdk.java.net/~vinnie/7198901/ > > It corrects the field size check when decoding an EC point. > > Thanks. >
code review request: 7198901: correct the field size check when decoding a point on ECC curve
Please review the following change for JDK8: http://cr.openjdk.java.net/~vinnie/7198901/ It corrects the field size check when decoding an EC point. Thanks.
Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec
Thanks Mike.
I've filed a bug on that and will fix it separately from 7197245/7194075:
7198901: correct the field size check when decoding a point on ECC curve
On 12 Sep 2012, at 19:19, Michael StJohns wrote:
> Sorry - additional comment. I think this one needs to be entered as a bug as
> it needs to be fixed both places.
>
> In encodePoint at 426,427
>
> int n = (data.length -1 ) / 2; // fix component size calculation.
> if ( n != ((curve.getField().getFieldSize() + 7 ) >> 3)) { // has to be
> equal, not just greater.
>
> Per x9.63 an encoded point is 1 byte of type followed by ceiling(log base 2
> field size/8) bytes of x and same of y. You can't trim or pad extra left
> zeros.
>
>
> At 12:22 PM 9/11/2012, Vincent Ryan wrote:
>
>> Hello Brad,
>>
>> Please review these changes to eliminate the dependency between the
>> SunJSSE provider and the ECParameters and NamedCurve classes in the
>> SunEC provider.
>>
>> http://cr.openjdk.java.net/~vinnie/7197245/webrev.00/
>>
>> Thanks.
>
>
Code review request: 7198871: cleanup security tests in problem lists with no CR attached
http://cr.openjdk.java.net/~weijun/7198871/webrev.00/ Some tests are liberated from ProblemList.txt: 1. Some saying too slow on sparc, I've run them multiple times on JPRT. The longest spends 15 seconds. 2. Some saying failure on Fedora 9. I guess they are CKR_DEVICE_ERROR pkcs11 error. This is due to old NSS libs. The same error can also appear on old Solaris 10 systems. This is not test error. Maybe we can add sanity check to test environments. 3. Other small changes. Thanks Max Original Message 7198871: cleanup security tests in problem lists with no CR attached http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198871 === *Description* Some tests in problem lists have no CR# attached.
Re: Code review request: 7197245: Eliminate sun.security.ssl.JsseJce dependency on sun.security.ec
Hello Stephen, We have crossed paths on this one. My original intention was just to address a static dependency in the Jigsaw module containing JSSE. However now it seems better to adopt your broader solution. I have discarded my changeset and closed CR 7197245 as a duplicate of CR 7194075. Thanks. On 12 Sep 2012, at 21:13, Stephen Flores wrote: > Vincent, > > It seems like we are work on same area, except I have a larger scope. > > The JSSE is not the only package to have sun.security.ec dependencies, PKCS > 11 has them plus the Public and private key class and the EC unit test. I > have same type of changes in mind so I can remove the duplicate classes in > rt.jar. > > CR 7194075: Various classes of sunec.jar are duplicated in rt.jar > > The main difference is that I moved the decode and encode point method out to > a new class sun.security.util.ECUtil to avoid duplication and since PKCS11 > would need the same changes JSSE for ECParameters and NamedCurve and to > minimize the changes in JSSE and PKCS11, I just changed ECParmeters and > NamedCurve to ECUtil and put the new code that uses the ECGenParameterSpec in > the ECUtil for both packages to use. > > I moved all of static lookup methods in ECParameters, NamedCurve and the > curve repository to separate class (CurveDB). This made ECParameters and > NamedCurve cleaner and easier work on (there was some ECParameters cleanup. > > PKCS needed to get curve by key size so a create a new AlgorithmParameterSpec > for that. > > I have not tried to compile my code yet, but here is a webrev: > > http://cr.openjdk.java.net/~sflores/7194075/webrev-suggested-fix-0/ > > It does not include the make file changes need to the rt.jar duplication or > the change to the EC unit test to use the list of supported curves that the > SunECEntries has already, (I have to write code to parser list) and have the > unit test use ECGenParameterSpec instead of ECParameterSpec. > > Steve. > > > On 09/11/2012 12:22 PM, Vincent Ryan wrote: >> >> Hello Brad, >> >> Please review these changes to eliminate the dependency between the >> SunJSSE provider and the ECParameters and NamedCurve classes in the >> SunEC provider. >> >> http://cr.openjdk.java.net/~vinnie/7197245/webrev.00/ >> >> Thanks.
Re: code review request: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
It hides warnings about the use of sun.* classes.
On 17 Sep 2012, at 11:18, Xuelei Fan wrote:
> Looks fine to me, except that:
>
> 91 ${TESTJAVA}${FS}bin${FS}javac -d . -XDignore.symbol.file \
>
> What's the purpose of the "-XDignore.symbol.file"?
>
> Xuelei
>
> On 9/17/2012 5:22 PM, Weijun Wang wrote:
>> ping again
>>
>> On 09/07/2012 07:11 PM, Weijun Wang wrote:
>>> Hi Vinnie
>>>
>>> Please take a look at
>>>
>>>http://cr.openjdk.java.net/~weijun/7196855/webrev.00/
>>>
>>> This one is similar to 7190945 (pkcs11 problem loading NSS libs on
>>> Ubuntu), because the test only looks up libsofokn.so in /usr/lib[64].
>>>
>>> Thanks
>>> Max
>>>
>>> Original Message
>>> 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
>>>
>>> === *Description*
>>>
>>> autotest.sh fails on ubuntu because libsoftokn.so not found, same reason
>>> as 7190945, because it's not in /usr/lib anymore.
>>>
>
hg: jdk8/tl/jdk: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
Changeset: f56f85040c58 Author:weijun Date: 2012-09-17 18:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f56f85040c58 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh
Re: code review request: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
Looks fine to me, except that:
91 ${TESTJAVA}${FS}bin${FS}javac -d . -XDignore.symbol.file \
What's the purpose of the "-XDignore.symbol.file"?
Xuelei
On 9/17/2012 5:22 PM, Weijun Wang wrote:
> ping again
>
> On 09/07/2012 07:11 PM, Weijun Wang wrote:
>> Hi Vinnie
>>
>> Please take a look at
>>
>> http://cr.openjdk.java.net/~weijun/7196855/webrev.00/
>>
>> This one is similar to 7190945 (pkcs11 problem loading NSS libs on
>> Ubuntu), because the test only looks up libsofokn.so in /usr/lib[64].
>>
>> Thanks
>> Max
>>
>> Original Message
>> 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
>>
>> === *Description*
>>
>> autotest.sh fails on ubuntu because libsoftokn.so not found, same reason
>> as 7190945, because it's not in /usr/lib anymore.
>>
Re: code review request: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
Fix looks good Max. Thanks. On 17 Sep 2012, at 10:22, Weijun Wang wrote: > ping again > > On 09/07/2012 07:11 PM, Weijun Wang wrote: >> Hi Vinnie >> >> Please take a look at >> >>http://cr.openjdk.java.net/~weijun/7196855/webrev.00/ >> >> This one is similar to 7190945 (pkcs11 problem loading NSS libs on >> Ubuntu), because the test only looks up libsofokn.so in /usr/lib[64]. >> >> Thanks >> Max >> >> Original Message >> 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found >> >> === *Description* >> >> autotest.sh fails on ubuntu because libsoftokn.so not found, same reason >> as 7190945, because it's not in /usr/lib anymore. >>
Re: code review request: 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found
ping again On 09/07/2012 07:11 PM, Weijun Wang wrote: Hi Vinnie Please take a look at http://cr.openjdk.java.net/~weijun/7196855/webrev.00/ This one is similar to 7190945 (pkcs11 problem loading NSS libs on Ubuntu), because the test only looks up libsofokn.so in /usr/lib[64]. Thanks Max Original Message 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found === *Description* autotest.sh fails on ubuntu because libsoftokn.so not found, same reason as 7190945, because it's not in /usr/lib anymore.
hg: jdk8/tl/jdk: 7198205: CloseTest fails on mac
Changeset: 0c3b0a82c4fc Author:weijun Date: 2012-09-17 17:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3b0a82c4fc 7198205: CloseTest fails on mac Reviewed-by: alanb, chegar, michaelm ! test/ProblemList.txt ! test/java/net/URLClassLoader/closetest/CloseTest.java
