Re: 7194075: Various classes of sunec.jar are duplicated in rt.jar
Hi Stephen, The update in JsseJce.java update the behaviors of SunJSSE provider. Need more time to evaluate the impact. For a particular standard named curve of EC, I think the ECParameterSpec does not change in different providers. I was wondering, is it necessary to bind the ECParameterSpec with a particular provider? in ECUtil, you have methods like this one: ECParameterSpec getECParameterSpec(Provider p, ECParameterSpec spec) I think it converts from one ECParameterSpec object to another ECParameterSpec object. What's the usage of this method? And this one: ECParameterSpec getECParameterSpec(Provider p, String name) For named curves, is it possible to make methods like this one to be provider independent? Regards, Xuelei On 11/27/2012 11:21 AM, Stephen Flores wrote: > Vincent, Sean, > > Please review the fix for: > > CR 7194075: Various classes of sunec.jar are duplicated in rt.jar > > http://cr.openjdk.java.net/~sflores/7194075/webrev-1/ > > Changes: > > *Changed/renamed any of methods that did not support the public API to > package private. > > *Moved the decode and encode point methods out of ECParameters to a new > class sun.security.util.ECUtil. > > *Changed any "new byte[], System.arraycopy" blocks in ECUtil point > methods to Arrays.copyOfRange. > > *Added a new AlgorithmParameterSpec in sun.security.util to get curves > by key size, for PKCS11 to use. > > *Moved all of static lookup methods in ECParameters, NamedCurve and the > curve repository to separate class (CurveDB). This made ECParameters and > NamedCurve cleaner and easier work on (there was some ECParameters cleanup. > > *In JSSE and PKCS11 and changed the references to ECParmeters and > NamedCurve to the ECUtil which has utility methods that use the public > APIs. > > *Changed to the EC unit test to use the list of supported curves in the > property that the SunEC provider has already. > > *Changed SunECEntries to build the list of supported curves property > from the collection in CurveDB. > > *Changed the JDK makefiles to not duplicate EC classes in rt.jar. > > Thanks, > > Steve.
hg: jdk8/tl/jdk: 8000983: Support narrow display names for calendar fields; ...
Changeset: fda257689786 Author:okutsu Date: 2012-12-10 10:52 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fda257689786 8000983: Support narrow display names for calendar fields 8003267: Support generic time zone names in TimeZoneNameProvider (SPI) Reviewed-by: naoto ! make/tools/src/build/tools/cldrconverter/Bundle.java ! make/tools/src/build/tools/cldrconverter/BundleGenerator.java ! make/tools/src/build/tools/cldrconverter/CLDRConverter.java ! make/tools/src/build/tools/cldrconverter/LDMLParseHandler.java ! make/tools/src/build/tools/cldrconverter/MetaZonesParseHandler.java ! make/tools/src/build/tools/cldrconverter/ResourceBundleGenerator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/spi/CalendarNameProvider.java ! src/share/classes/java/util/spi/TimeZoneNameProvider.java ! src/share/classes/sun/text/resources/FormatData.java ! src/share/classes/sun/text/resources/ar/FormatData_ar.java ! src/share/classes/sun/text/resources/be/FormatData_be.java ! src/share/classes/sun/text/resources/bg/FormatData_bg.java ! src/share/classes/sun/text/resources/ca/FormatData_ca.java ! src/share/classes/sun/text/resources/cs/FormatData_cs.java ! src/share/classes/sun/text/resources/da/FormatData_da.java ! src/share/classes/sun/text/resources/de/FormatData_de.java ! src/share/classes/sun/text/resources/el/FormatData_el.java ! src/share/classes/sun/text/resources/es/FormatData_es.java ! src/share/classes/sun/text/resources/et/FormatData_et.java ! src/share/classes/sun/text/resources/fi/FormatData_fi.java ! src/share/classes/sun/text/resources/fr/FormatData_fr.java ! src/share/classes/sun/text/resources/hi/FormatData_hi_IN.java ! src/share/classes/sun/text/resources/hr/FormatData_hr.java ! src/share/classes/sun/text/resources/hu/FormatData_hu.java ! src/share/classes/sun/text/resources/is/FormatData_is.java ! src/share/classes/sun/text/resources/it/FormatData_it.java ! src/share/classes/sun/text/resources/iw/FormatData_iw.java ! src/share/classes/sun/text/resources/ja/FormatData_ja.java ! src/share/classes/sun/text/resources/ko/FormatData_ko.java ! src/share/classes/sun/text/resources/lt/FormatData_lt.java ! src/share/classes/sun/text/resources/lv/FormatData_lv.java ! src/share/classes/sun/text/resources/mk/FormatData_mk.java ! src/share/classes/sun/text/resources/ms/FormatData_ms.java ! src/share/classes/sun/text/resources/mt/FormatData_mt.java ! src/share/classes/sun/text/resources/nl/FormatData_nl.java ! src/share/classes/sun/text/resources/pl/FormatData_pl.java ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! src/share/classes/sun/text/resources/ro/FormatData_ro.java ! src/share/classes/sun/text/resources/ru/FormatData_ru.java ! src/share/classes/sun/text/resources/sk/FormatData_sk.java ! src/share/classes/sun/text/resources/sl/FormatData_sl.java ! src/share/classes/sun/text/resources/sq/FormatData_sq.java ! src/share/classes/sun/text/resources/sr/FormatData_sr.java ! src/share/classes/sun/text/resources/sv/FormatData_sv.java ! src/share/classes/sun/text/resources/th/FormatData_th.java ! src/share/classes/sun/text/resources/tr/FormatData_tr.java ! src/share/classes/sun/text/resources/uk/FormatData_uk.java ! src/share/classes/sun/text/resources/vi/FormatData_vi.java ! src/share/classes/sun/text/resources/zh/FormatData_zh.java ! src/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleResources.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameUtility.java ! src/share/classes/sun/util/resources/LocaleData.java ! src/share/classes/sun/util/resources/OpenListResourceBundle.java ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.java + test/java/util/Calendar/GenericTimeZoneNamesTest.java + test/java/util/Calendar/GenericTimeZoneNamesTest.sh + test/java/util/Calendar/NarrowNamesTest.java + test/java/util/Calendar/NarrowNamesTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/GenericTimeZoneNameProviderImpl.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.TimeZoneNameProvider ! test/sun/text/resources/LocaleData ! test/sun/text/resources/Lo
Re: [8] Code Review Request for 8004064: Downgrade normative references to ${java.home}/lib/security/java.security
Looks fine to me. A pretty minor comment:
src/share/classes/javax/security/auth/login/LoginContext.java
166 * auth.login.defaultCallbackHandler security property for the
Do you want to use the "code" tag here, {@code
auth.login.defaultCallbackHandler}?
Xuelei
On 12/8/2012 5:05 AM, Sean Mullan wrote:
> As part of the effort to prepare the platform for modules (see
> http://openjdk.java.net/jeps/162) we need to re-examine all normative
> references to files/resources in ${java.home} as these may be candidates
> to be replaced or candidates to move to module-private locations in the
> future.
>
> The focus of this change are the various security APIs that specify that
> the default values of security properties are loaded from
> ${java.home}/lib/security/java.security. We need the flexibility to be
> able to re-locate this file and its properties to ease the transition to
> a modular system.
>
> The proposed changes remove all references to
> ${java.home}/lib/security/java.security or "security properties file"
> from the APIs and adds a reference to the java.security.Security API for
> more information about security properties. The class definition of the
> Security class has been adjusted to note that the loading of the default
> values of security properties is implementation-specific, but that they
> are typically loaded from the ${java.home}/lib/security/java.security file.
>
> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004064/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004064
>
> Thanks,
> Sean
hg: jdk8/tl/jdk: 7194370: (fs) WatchService fails if volume S/N is 0 [win]
Changeset: 343615aa0539 Author:dxu Date: 2012-12-09 19:13 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/343615aa0539 7194370: (fs) WatchService fails if volume S/N is 0 [win] Reviewed-by: alanb, forax ! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java
hg: jdk8/tl/jdk: 8004042: Arrrghs.java test failed on windows with access error.
Changeset: da387f0cecb7 Author:ksrini Date: 2012-12-09 07:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da387f0cecb7 8004042: Arrrghs.java test failed on windows with access error. Reviewed-by: smarks, jjh, ksrini Contributed-by: david.deha...@oracle.com ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java
