Code review request: 8012615: Realm.getRealmsList returns realms list in wrong
Hi All Please review the fix at http://cr.openjdk.java.net/~weijun/8012615/webrev.00/ Basically, the algorithm to calculate cross-realm authentication path is totally rewritten to be *correct*. This includes both the hierarchy codes and capaths codes. You are welcomed to read this blog post for more info: https://blogs.oracle.com/wangwj/entry/re_read_capaths Thanks Max
Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library
On 03/01/2013 11:30 AM, Severin Gehwolf wrote: Hi, The bug for this review request is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 In PlatformPCSC.java unversioned native libraries are loaded by default if no system property is specified. This could lead to a JVM crash if the API of the native library changes, but the Java code still relies on old API. The fix is to load versioned shared libraries instead. Hmm. Why doesn't the j2pcsc library link against the right version of libpcsclite.so? -- Florian Weimer / Red Hat Product Security Team
hg: jdk8/tl/jdk: 8005555: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed
Changeset: bbcebf893b83 Author:alanb Date: 2013-04-24 19:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbcebf893b83 800: TEST_BUG: java/io/Serializable/accessConstants/AccessConstants.java should be removed Reviewed-by: chegar - test/java/io/Serializable/accessConstants/AccessConstants.java
hg: jdk8/tl/jdk: 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c
Changeset: 754c9bb4f085 Author:sla Date: 2013-04-24 14:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/754c9bb4f085 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c Reviewed-by: sla, rbackman, alanb, dholmes, rdurbin Contributed-by: peter.all...@oracle.com ! src/solaris/native/com/sun/management/UnixOperatingSystem_md.c
hg: jdk8/tl/jdk: 8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ
Changeset: 8c06a38aa2c5 Author:sherman Date: 2013-04-24 21:27 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c06a38aa2c5 8012638: test/java/time/test/java/util/TestFormatter fails in UTC TZ Summary: updated the offending test case Reviewed-by: alanb ! test/java/time/test/java/util/TestFormatter.java
Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library
Won't this change break systems which don't have libpcsclite.so.1? Changes like this need to be thought through. What happens when libpcsclite.so.2 comes out? As for API changes, shouldn't there be some compatibility requirement on APIs as libpcsclite.so evolves? Valerie On 04/24/13 04:05, Florian Weimer wrote: On 03/01/2013 11:30 AM, Severin Gehwolf wrote: Hi, The bug for this review request is at: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=9000142 In PlatformPCSC.java unversioned native libraries are loaded by default if no system property is specified. This could lead to a JVM crash if the API of the native library changes, but the Java code still relies on old API. The fix is to load versioned shared libraries instead. Hmm. Why doesn't the j2pcsc library link against the right version of libpcsclite.so?
Code review request: 7025699: Policy Tool is not accessible by keyboard
Hi All Please take a look at http://cr.openjdk.java.net/~weijun/7025699/webrev.00/ The bug is about policytool not accessible through a keyboard. Mainly two problems: First menu items have no key accelerators. Second, pressing ENTER on any button is not working. Basically I made these changes: 1. Assign shortcut keys to 5 menu items, like this -menu.add(QUIT); +menu.add(new MenuItem(QUIT, new MenuShortcut(KeyEvent.VK_Q))); 2. Make all buttons ENTER aware. In the program, an action listener is added to a button with button.addActionListener(new MainWindowListener(tool, this)); and this MainWindowListener implements ActionListener. After this, it seems the button can react to mouse click event. It also reacts to spacebar press, but no other key. Anyway, I make all these button listeners also implementing KeyListener, and override the keyReleased event there so that when ENTER is pressed on a button, trigger a mouse click event on it. Now it seems working in Mac OS X, Linux and Windows XP. However, I'm really not a GUI guy and I am not sure if this fix is the right way. The bug mentions High Contrast Mode is also not working. I have no idea how to fix that. Thanks Max
