Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

[Wang Weijun]

> I will also apply the same change to P11DHPrivateKey/P11DHPublicKey then. 
> Equality check using ASN.1 encoding is fine for non-DH algorithms but not for 
> DH.

I cannot read the source codes now, but is it possible to implement the equals 
method right in the base interface using the JDK 8 default method feature? 

> 
>> 
>> For DHKeyPairGenerator.java, it looks like you don't want the first octet 
>> being zero. Is this related to this bug? Is that required in the "Handbook 
>> of Applied Cryptography" book? I understand it could be necessary for 
>> interop.
> The change is for conforming to the description under section 7.1 
> "Private-value generation" of PKCS#3 DH Key Agreement Standard 
> ftp://ftp.rsasecurity.com/pub/pkcs/ascii/pkcs-3.asc , i.e.
> 
> An integer x, the private value, shall be generated
> privately and randomly. This integer shall satisfy 0<  x<
> p-1, unless the central authority specifies a private-value
> length l, in which case the integer shall satisfy 2^(l-1)<=
> x<  2^l.

Great. I think you can add a reference to pkcs3. The current wording seems to 
say it's suggested by the Handbook.

Thanks
Max

hg: jdk8/tl/jdk: 8015402: Lambda metafactory should not attempt to determine bridge methods

[robert . field]

Changeset: 989049977d04
Author:rfield
Date:  2013-06-17 20:31 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/989049977d04

8015402: Lambda metafactory should not attempt to determine bridge methods
Summary: paired with 8013789: Compiler should emit bridges in interfaces
Reviewed-by: twisti

! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java
! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
! src/share/classes/java/lang/invoke/LambdaMetafactory.java

hg: jdk8/tl/langtools: 8013789: Compiler should emit bridges in interfaces

[robert . field]

Changeset: 455be95bd1b5
Author:rfield
Date:  2013-06-17 20:29 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/455be95bd1b5

8013789: Compiler should emit bridges in interfaces
Summary: paired with 8015402: Lambda metafactory should not attempt to 
determine bridge methods
Reviewed-by: vromero
Contributed-by: maurizio.cimadam...@oracle.com

! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java
! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! test/tools/javac/lambda/lambdaExpression/LambdaTest6.java
! test/tools/javac/lambda/methodReference/BridgeMethod.java

hg: jdk8/tl/jdk: 8014620: Signature.getAlgorithm return null in special case

[bradford . wetmore]

Changeset: 116050227ee9
Author:youdwei
Date:  2013-06-17 17:36 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9

8014620: Signature.getAlgorithm return null in special case
Reviewed-by: wetmore

! src/share/classes/java/security/Signature.java
+ test/java/security/Signature/SignatureGetAlgorithm.java

Re: RFR JDK8007636

[Brad Wetmore]

Ditto.

brad



On 6/17/2013 5:16 PM, Xuelei Fan wrote:

Looks fine to me.

Thanks,
Xuelei

On 6/17/2013 10:29 PM, John Zavgren wrote:

Greetings:

I'm posting a fix for a memory leak. As you can see, the original code
deallocated a structure, thereby rendering it's memory invalid, then it
deallocated the memory that was allocated to one of its data members.

I merely reversed the order of the free() operations.


http://cr.openjdk.java.net/~jzavgren/8007636/webrev.01/


Thanks!
John

--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA

Re: Signature.getAlogrithm return null in special case

[Brad Wetmore]

On 6/17/2013 5:38 PM, Brad Wetmore wrote:

Pushed.  Thanks for the contribution.


P.S.  http://hg.openjdk.java.net/jdk8/tl/jdk/rev/116050227ee9

Brad




Brad


On 5/27/2013 12:11 PM, Brad Wetmore wrote:

Hi Deven,

I just got back from a short break, hope to return back to this shortly.

I tweaked your test a bit before I left, but the builds were failing
(unrelated issue) so I couldn't check in.  Still need to check the
actual Signature code for a couple things, but I think it's ok.

Brad


On 5/21/2013 2:07 AM, Deven You wrote:

Hi Brad,

Thanks for your reply, is there any progress on this problem?

I see the last comments on JDK-8014620 is six days before.

Thanks a lot!

On 05/15/2013 08:28 AM, Brad Wetmore wrote:

Offhand, this seems reasonable.

Since you are an OpenJDK author, I've filed:

JDK-8014620: Signature.getAlogrithm return null in special case

and stocked it with your patch.

Thanks,

Brad


On 5/13/2013 9:46 PM, Deven You wrote:

Hi All,

I find in a special case: If you create a SignatureSpi service through
extending Signature rather than SignatureSpi, the returned signature
instance will lose its algortithm name.

Though the fix[1] is simple I think it's valuable. Could anyone take
a look?

[1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/


Thanks a lot

Re: Signature.getAlogrithm return null in special case

[Brad Wetmore]

Pushed.  Thanks for the contribution.

Brad


On 5/27/2013 12:11 PM, Brad Wetmore wrote:

Hi Deven,

I just got back from a short break, hope to return back to this shortly.

I tweaked your test a bit before I left, but the builds were failing
(unrelated issue) so I couldn't check in.  Still need to check the
actual Signature code for a couple things, but I think it's ok.

Brad


On 5/21/2013 2:07 AM, Deven You wrote:

Hi Brad,

Thanks for your reply, is there any progress on this problem?

I see the last comments on JDK-8014620 is six days before.

Thanks a lot!

On 05/15/2013 08:28 AM, Brad Wetmore wrote:

Offhand, this seems reasonable.

Since you are an OpenJDK author, I've filed:

JDK-8014620: Signature.getAlogrithm return null in special case

and stocked it with your patch.

Thanks,

Brad


On 5/13/2013 9:46 PM, Deven You wrote:

Hi All,

I find in a special case: If you create a SignatureSpi service through
extending Signature rather than SignatureSpi, the returned signature
instance will lose its algortithm name.

Though the fix[1] is simple I think it's valuable. Could anyone take
a look?

[1] http://cr.openjdk.java.net/~youdwei/ojdk-809/webrev/


Thanks a lot

Re: RFR JDK8007636

[Xuelei Fan]

Looks fine to me.

Thanks,
Xuelei

On 6/17/2013 10:29 PM, John Zavgren wrote:
> Greetings:
> 
> I'm posting a fix for a memory leak. As you can see, the original code
> deallocated a structure, thereby rendering it's memory invalid, then it
> deallocated the memory that was allocated to one of its data members.
> 
> I merely reversed the order of the free() operations.
> 
> 
> http://cr.openjdk.java.net/~jzavgren/8007636/webrev.01/
> 
> 
> Thanks!
> John
> 
> -- 
> John Zavgren
> john.zavg...@oracle.com
> 603-821-0904
> US-Burlington-MA
> 

hg: jdk8/tl/jdk: 7177472: JSR292: MethodType interning penalizes scalability

[christian . thalinger]

Changeset: 2b63fda275a3
Author:twisti
Date:  2013-06-17 16:24 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b63fda275a3

7177472: JSR292: MethodType interning penalizes scalability
Reviewed-by: twisti
Contributed-by: Aleksey Shipilev 

! src/share/classes/java/lang/invoke/MethodType.java

hg: jdk8/tl/langtools: 8016779: Fix doclint warnings in javax.lang.model

[joe . darcy]

Changeset: b7a10bc02e7a
Author:darcy
Date:  2013-06-17 14:46 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7a10bc02e7a

8016779: Fix doclint warnings in javax.lang.model
Reviewed-by: jjg

! src/share/classes/javax/lang/model/util/ElementScanner6.java
! src/share/classes/javax/lang/model/util/ElementScanner7.java
! src/share/classes/javax/lang/model/util/ElementScanner8.java
! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java

Re: Code Review Request for 7196805: DH Key interoperability testing between SunJCE and JsafeJCE not successful

[Valerie (Yu-Ching) Peng]

Max,

Please find comments in line...

On 06/12/13 18:27, Weijun Wang wrote:

Hi Valerie

Not sure if we really need to fix the equals() method here. Is there a 
spec saying the equality is based on internal fields instead of 
encoded bytes?
There is no spec saying the equality check should be based on encoded 
bytes neither.
DH keys are different from other keys in that its parameters contains an 
optional field. Thus, even for 2 DH public keys whose internal fields 
are identical (including the optional one), they could still have 
different ASN.1 encodings, i.e. one includes the optional value vs one 
does not. I think the reasonable expectation would be that if all 
non-optional fields match, then the 2 keys are equal. Otherwise, it's 
hard to predict the behavior since DH keys can be constructed w/ or w/o 
the optional field and there are mixed usages in our JDK code base.


I am saying this because it's not easy to get equals() correct here. 
In DHPrivateKey.java, the new equals() requires the other object to be 
instanceof javax.crypto.interfaces.DHPrivateKey. I see that another 
class P11DHPrivateKey also implements this interface but has not 
overridden equals, so it looks like a 
com/sun/crypto/provider/DHPrivateKey could equals() to a 
P11DHPrivateKey, but a P11DHPrivateKey will not equals() to a 
com/sun/crypto/provider/DHPrivateKey.


Same with DHPublicKey.java.
I will also apply the same change to P11DHPrivateKey/P11DHPublicKey 
then. Equality check using ASN.1 encoding is fine for non-DH algorithms 
but not for DH.




BTW, the hashCode() methods in these 2 classes use <<2 and <<4 which 
looks not as cool as the normal "*31+". I would simply use 
Objects.hash() method.

Ok, I am fine with just using Objects.hash(Object... values) method.



For DHKeyPairGenerator.java, it looks like you don't want the first 
octet being zero. Is this related to this bug? Is that required in the 
"Handbook of Applied Cryptography" book? I understand it could be 
necessary for interop.
The change is for conforming to the description under section 7.1 
"Private-value generation" of PKCS#3 DH Key Agreement Standard 
ftp://ftp.rsasecurity.com/pub/pkcs/ascii/pkcs-3.asc , i.e.


An integer x, the private value, shall be generated
privately and randomly. This integer shall satisfy 0<  x<
p-1, unless the central authority specifies a private-value
length l, in which case the integer shall satisfy 2^(l-1)<=
x<  2^l.

I will re-test everything and let you know once I have the webrev updated.
Thanks,
Valerie


Thanks
Max

On 5/29/13 9:25 AM, Valerie (Yu-Ching) Peng wrote:

Vinnie,

Can you help reviewing my fix for 7196805 "DH Key interoperability
testing between SunJCE and JsafeJCE not successful"?

In SunJCE provider, the equality check for DH private/public keys is
based on DER encoding which may not be correct all the time due to the
optional L value defined in the DER syntax. In addition, JsafeJCE
provider sometimes encode the optional L value incorrectly which leads
to unexpected IOException when parsing the DER bytes.
I have changed the comparison to based on component values rather than
DER encodings which may vary due to the presence or missing of optional
values. In addition, I made the changes to DHKeyPairGenerator to ensure
that generated private value has the requested length/size.

Webrev: http://cr.openjdk.java.net/~valeriep/7196805/webrev.00/

Thanks,
Valerie

hg: jdk8/tl/jaxp: 8016133: Regression: diff. behavior with user-defined SAXParser

[huizhe . wang]

Changeset: 09d55894844d
Author:joehw
Date:  2013-06-17 12:47 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/09d55894844d

8016133: Regression: diff. behavior with user-defined SAXParser
Reviewed-by: chegar, dfuchs

! src/org/xml/sax/helpers/XMLReaderFactory.java

hg: jdk8/tl/jdk: 7040556: SimpleDateFormat.format Portuguese Month should not be capitalized

[yong . huang]

Changeset: 3c7bab68cd2f
Author:yhuang
Date:  2013-06-12 23:54 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c7bab68cd2f

7040556: SimpleDateFormat.format Portuguese Month should not be capitalized
Reviewed-by: okutsu

! src/share/classes/sun/text/resources/pt/FormatData_pt.java
! test/sun/text/resources/LocaleData
! test/sun/text/resources/LocaleDataTest.java

hg: jdk8/tl: 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile

[mike . duigou]

Changeset: f8770fe60d53
Author:mduigou
Date:  2013-06-17 09:41 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/rev/f8770fe60d53

8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile
Reviewed-by: alanb, erikj

! common/makefiles/Main.gmk

RFR JDK8007636

[John Zavgren]

Greetings:

I'm posting a fix for a memory leak. As you can see, the original code 
deallocated a structure, thereby rendering it's memory invalid, then it 
deallocated the memory that was allocated to one of its data members.


I merely reversed the order of the free() operations.


http://cr.openjdk.java.net/~jzavgren/8007636/webrev.01/ 



Thanks!
John

--
John Zavgren
john.zavg...@oracle.com
603-821-0904
US-Burlington-MA

hg: jdk8/tl/jdk: 8016236: Class.getGenericInterfaces performance improvement

[alan . bateman]

Changeset: b0cfde1e70e9
Author:shade
Date:  2013-06-17 16:28 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0cfde1e70e9

8016236: Class.getGenericInterfaces performance improvement
Summary: cache more reflective data and lookup results.
Reviewed-by: alanb, plevart, psandoz, dl
Contributed-by: Doug Lea , Aleksey Shipilev 


! src/share/classes/java/lang/Class.java
! src/share/classes/sun/reflect/generics/repository/ClassRepository.java
! src/share/native/java/lang/Class.c

hg: jdk8/tl/jdk: 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level)

[chris . hegarty]

Changeset: adf70cb48ce0
Author:chegar
Date:  2013-06-17 14:09 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adf70cb48ce0

8016747: Replace deprecated PlatformLogger isLoggable(int) with 
isLoggable(Level)
Reviewed-by: darcy

! src/macosx/classes/sun/lwawt/LWComponentPeer.java
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/share/classes/java/awt/AWTEvent.java
! src/share/classes/java/awt/AttributeValue.java
! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Container.java
! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
! src/share/classes/java/awt/Cursor.java
! src/share/classes/java/awt/DefaultKeyboardFocusManager.java
! src/share/classes/java/awt/EventDispatchThread.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/awt/KeyboardFocusManager.java
! src/share/classes/java/awt/SplashScreen.java
! src/share/classes/java/awt/Toolkit.java
! src/share/classes/java/awt/WaitDispatchSupport.java
! src/share/classes/java/awt/Window.java
! src/share/classes/java/awt/event/InputEvent.java
! src/share/classes/java/net/CookieManager.java
! src/share/classes/java/util/Currency.java
! src/share/classes/javax/swing/BufferStrategyPaintManager.java
! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java
! src/share/classes/sun/awt/AWTAutoShutdown.java
! src/share/classes/sun/awt/DebugSettings.java
! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java
! src/share/classes/sun/awt/ScrollPaneWheelScroller.java
! src/share/classes/sun/awt/SunDisplayChanger.java
! src/share/classes/sun/awt/SunGraphicsCallback.java
! src/share/classes/sun/awt/SunToolkit.java
! src/share/classes/sun/awt/datatransfer/DataTransferer.java
! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java
! src/share/classes/sun/awt/im/InputContext.java
! src/share/classes/sun/font/SunFontManager.java
! src/share/classes/sun/net/ftp/impl/FtpClient.java
! src/share/classes/sun/net/www/http/HttpClient.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java
! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java
! src/share/classes/sun/net/www/protocol/http/Negotiator.java
! src/share/classes/sun/net/www/protocol/https/HttpsClient.java
! src/solaris/classes/sun/awt/X11/ListHelper.java
! src/solaris/classes/sun/awt/X11/UnsafeXDisposerRecord.java
! src/solaris/classes/sun/awt/X11/XAWTXSettings.java
! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java
! src/solaris/classes/sun/awt/X11/XBaseWindow.java
! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java
! src/solaris/classes/sun/awt/X11/XChoicePeer.java
! src/solaris/classes/sun/awt/X11/XComponentPeer.java
! src/solaris/classes/sun/awt/X11/XContentWindow.java
! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java
! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java
! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java
! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java
! src/solaris/classes/sun/awt/X11/XDropTargetContextPeer.java
! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java
! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java
! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java
! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java
! src/solaris/classes/sun/awt/X11/XEmbedHelper.java
! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java
! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java
! src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java
! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java
! src/solaris/classes/sun/awt/X11/XFramePeer.java
! src/solaris/classes/sun/awt/X11/XIconWindow.java
! src/solaris/classes/sun/awt/X11/XInputMethod.java
! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java
! src/solaris/classes/sun/awt/X11/XListPeer.java
! src/solaris/classes/sun/awt/X11/XMSelection.java
! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java
! src/solaris/classes/sun/awt/X11/XMenuPeer.java
! src/solaris/classes/sun/awt/X11/XMenuWindow.java
! src/solaris/classes/sun/awt/X11/XNETProtocol.java
! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java
! src/solaris/classes/sun/awt/X11/XProtocol.java
! src/solaris/classes/sun/awt/X11/XScrollbar.java
! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java
! src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java
! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java
! src/solaris/classes/sun/awt/X11/XWINProtocol.java
! src/solaris/classes/sun/awt/X11/XWM.java
! src/solaris/classes/sun/awt/X11/XWindow.java
! src/solaris/classes/sun/awt/X11/XWindowPeer.java
! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java
! src/solaris/classes/sun/awt/X11InputMethod.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java
! src/windows/classes/sun/awt/windows/WDesktopProperties.java
! src/windows/c

hg: jdk8/tl/jdk: 36 new changesets

[lana . steuck]

Changeset: 583e6dec1ed7
Author:erikj
Date:  2013-05-29 14:01 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/583e6dec1ed7

8013489: New build system does not run codesign on SA-related launchers on OS X
Reviewed-by: sla, tbell

! makefiles/CompileLaunchers.gmk

Changeset: d8c97d6772cd
Author:erikj
Date:  2013-05-30 09:29 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8c97d6772cd

Merge


Changeset: bc3a17982aae
Author:erikj
Date:  2013-05-31 14:05 +0200
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc3a17982aae

7195481: FDS: debuginfo file for libjdwp.so is missed
Reviewed-by: tbell

! make/jpda/back/Makefile
! makefiles/CompileNativeLibraries.gmk

Changeset: c50add191a39
Author:katleman
Date:  2013-06-04 11:03 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c50add191a39

Merge

! makefiles/CompileNativeLibraries.gmk

Changeset: 16003f414ca3
Author:katleman
Date:  2013-06-04 14:11 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/16003f414ca3

8015644: makefile changes to allow integration of new features
Reviewed-by: tbell, erikj, dholmes
Contributed-by: amy.y.w...@oracle.com

! makefiles/Images.gmk

Changeset: 691d6c6cd332
Author:katleman
Date:  2013-06-05 15:25 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/691d6c6cd332

6983966: remove lzma and upx from repository JDK8
Reviewed-by: tbell, paulk, ngthomas

! make/common/Defs-windows.gmk

Changeset: 7b757d567346
Author:katleman
Date:  2013-06-06 09:55 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b757d567346

Added tag jdk8-b93 for changeset 691d6c6cd332

! .hgtags

Changeset: fd377533608b
Author:andrew
Date:  2013-05-30 16:50 +0100
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd377533608b

8011693: Remove redundant fontconfig files
Summary: Remove unused fontconfig files from OpenJDK GNU/Linux builds
Reviewed-by: andrew, prr
Contributed-by: Jiri Vanek 

! make/sun/awt/Makefile
! makefiles/GendataFontConfig.gmk
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties
- src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties

Changeset: b9b73bf450a4
Author:bae
Date:  2013-05-31 14:30 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9b73bf450a4

8015606: Text is not rendered correctly if destination buffer is custom
Reviewed-by: prr, vadim

! src/share/classes/sun/java2d/loops/MaskFill.java
+ test/sun/java2d/loops/RenderToCustomBufferTest.java

Changeset: 0a17344d074e
Author:prr
Date:  2013-05-31 09:25 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a17344d074e

8015556: [macosx] surrogate pairs do not render properly.
Reviewed-by: bae, jchen

! src/macosx/classes/sun/font/CCharToGlyphMapper.java
+ test/java/awt/FontClass/SurrogateTest/SuppCharTest.java

Changeset: 3af3981dee11
Author:lana
Date:  2013-06-05 09:52 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3af3981dee11

Merge

- 
test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh

Changeset: 768fcc36182a
Author:anthony
Date:  2013-05-30 18:10 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/768fcc36182a

8015303: [macosx] Application launched via custom URL Scheme does not receive 
URL
Summary: Make copies of event parameters
Reviewed-by: anthony, swingler, serb
Contributed-by: James Tomson 

! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.m

Changeset: 8472c148688c
Author:ant
Date:  2013-05-30 18:23 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8472c148688c

8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on 
Linux/Java 7
Reviewed-by: anthony

! src/solaris/classes/sun/awt/X11/XClipboard.java

Changeset: 56512cfccef9
Author:ant
Date:  2013-05-30 18:31 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56512cfccef9

8013773: requestFocusInWindow to a disabled component prevents window of 
getting focused
Reviewed-by: leonidr, alexsch

! src/share/classes/java/awt/DefaultKeyboardFocusManager.java
+ 
test/java/awt/Focus/ResetMostRecentFocusOwnerTest/ResetMostRecentFocusOwnerTest.java

Changeset: b0eab0f8b503
Author:anthony
Date:  2013-05-31 14:12 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b0eab0f8b503

8013189: JMenuItems draw behind TextArea
Summary: Untie XTextAreaPeer internal components from the TextArea parent to 
prevent its invalidation. I.e. force the java.awt.smartInvalidate=true locally.
Reviewed-by: art, serb

! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java
+ test/java/awt/TextArea/Mixing/TextAreaMixing.java

Changeset: 481476e941fd
Author:ant
Date:  2013-05-31 15:56 +0400
URL:   http://hg.openjdk.java.net/jdk8/tl/jdk/rev/481476e941fd

8