[8] Request for review: 8012288: XML DSig API allows wrong tag names and extra elements in SignedInfo
Xuelei, Could you please review my fix for 8012288: http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/ There is already an SQE test for this, so I have added the noreg-sqe label. Thanks, Sean
hg: jdk8/tl/jdk: 8016838: improvement of RedefineBigClass and RetransformBigClass tests
Changeset: 6f3b940fe9f8 Author:igerasim Date: 2013-07-23 18:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f3b940fe9f8 8016838: improvement of RedefineBigClass and RetransformBigClass tests Reviewed-by: dcubed ! test/ProblemList.txt ! test/java/lang/instrument/RedefineBigClass.sh ! test/java/lang/instrument/RedefineBigClassApp.java ! test/java/lang/instrument/RetransformBigClass.sh ! test/java/lang/instrument/RetransformBigClassApp.java
hg: jdk8/tl/nashorn: 10 new changesets
Changeset: e1d19f9fd5a9 Author:jlaskey Date: 2013-07-16 17:40 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e1d19f9fd5a9 8017585: Exclude two failing tests from Nashorn CC run Reviewed-by: jlaskey, sundar, attila Contributed-by: konstantin.she...@oracle.com + exclude/exclude_list.txt + exclude/exclude_list_cc.txt ! make/build.xml Changeset: 71cfe4e66bcb Author:jlaskey Date: 2013-07-17 11:53 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/71cfe4e66bcb 8020596: Initialization of white space strings in scanner should be done with \u strings Reviewed-by: attila, hannesw Contributed-by: james.las...@oracle.com ! src/jdk/nashorn/internal/parser/Lexer.java Changeset: 3d6f6b8d8bc8 Author:hannesw Date: 2013-07-17 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3d6f6b8d8bc8 8020356: ClassCastException Undefined-Scope on spiltter class generated for a large switch statement Reviewed-by: jlaskey, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Label.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/LexicalContext.java + test/script/basic/JDK-8020356.js + test/script/basic/JDK-8020356.js.EXPECTED Changeset: e3307f1a30e5 Author:sundar Date: 2013-07-18 18:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e3307f1a30e5 8020731: Revisit checkPermission calls in Context class Reviewed-by: attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java - src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: 624f8be5c3fe Author:attila Date: 2013-07-18 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/624f8be5c3fe 8020809: Java adapter should not allow overriding of caller sensitive methods Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/trusted/JDK-8020809.js + test/script/trusted/JDK-8020809.js.EXPECTED Changeset: 4b06441b7624 Author:attila Date: 2013-07-18 16:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4b06441b7624 8020820: Limit access to static members of reflective classes Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! test/script/basic/JDK-8010946-2.js ! test/script/basic/JDK-8010946-2.js.EXPECTED ! test/script/basic/NASHORN-473.js + test/script/basic/classloader.js + test/script/basic/classloader.js.EXPECTED ! test/script/basic/javaarray.js ! test/script/sandbox/classloader.js.EXPECTED ! test/script/sandbox/reflection.js ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java Changeset: 0cfa27ed82fe Author:sundar Date: 2013-07-23 18:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0cfa27ed82fe 8021122: Not all callables are handled for toString and other function valued properties Reviewed-by: attila, hannesw, jlaskey ! src/jdk/nashorn/internal/ir/debug/ASTWriter.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java ! src/jdk/nashorn/internal/runtime/linker/NashornBottomLinker.java + test/script/basic/JDK-8021122.js + test/script/basic/JDK-8021122.js.EXPECTED Changeset: e86b297d26aa Author:jlaskey Date: 2013-07-23 12:00 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e86b297d26aa 8021130: Comments need to be tokens Reviewed-by: lagergren, attila Contributed-by: james.las...@oracle.com ! src/jdk/nashorn/internal/parser/AbstractParser.java ! src/jdk/nashorn/internal/parser/Lexer.java !
TLS extension needed for HTTP/2.0
Hi there, HTTP/2.0 draft (based on google's SPDY) requires the use of a new TLS extension (ALPN), see http://tools.ietf.org/html/draft-ietf-httpbis-http2-04#section-3.3 The current javax.net.ssl API does not support that, so it'll be a problem for someone trying to implement the HTTP/2.0 draft on Java platform. Is there a remedy to that? If javax.net.ssl needs further development to be able to support ALPN, would you give a rough estimate on when it could be released? And would it be back ported to earlier versions of Java? What kind of API change do you envision that's necessary to expose ALPN negotiation process to applications? Note that HTTP/2.0 is in very early stage; it's possible that the requirement of ALPN could be relaxed if there's difficulty to implement it on popular platforms; see this thread: http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html Thank you very much, Zhong Yu
Re: TLS extension needed for HTTP/2.0
On Tue, Jul 23, 2013 at 05:41:52PM -0500, Zhong Yu wrote: Note that HTTP/2.0 is in very early stage; it's possible that the requirement of ALPN could be relaxed if there's difficulty to implement it on popular platforms; see this thread: http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html I'm not sure putting ALPN in there is the best idea, if you want this to work right on millions of already deployed but un-upgradeable mobile devices around the world. I think maybe it makes more sense to have an HTTP/2.0 string like what's seen with HTTP/1.0 and HTTP/1.1 or some other such mechanism that doesn't cause contamination between the layers of the protocol stack. Matthew.
Re: TLS extension needed for HTTP/2.0
On Tue, Jul 23, 2013 at 5:50 PM, Matthew Hall mh...@mhcomputing.net wrote: On Tue, Jul 23, 2013 at 05:41:52PM -0500, Zhong Yu wrote: Note that HTTP/2.0 is in very early stage; it's possible that the requirement of ALPN could be relaxed if there's difficulty to implement it on popular platforms; see this thread: http://lists.w3.org/Archives/Public/ietf-http-wg/2013JulSep/0425.html I'm not sure putting ALPN in there is the best idea, if you want this to work right on millions of already deployed but un-upgradeable mobile devices around the world. I think maybe it makes more sense to have an HTTP/2.0 string like what's seen with HTTP/1.0 and HTTP/1.1 or some other such mechanism that doesn't cause contamination between the layers of the protocol stack. These are very good points and you probably should raise them on the http list. My objection to the ALPN mandate is that Java doesn't have out-of-box support, and the http people like to get an understanding just how difficult/distant it would be to to deploy ALPN on Java platforms. Zhong Yu
hg: jdk8/tl/langtools: 8021215: javac gives incorrect doclint warnings on normal package statements
Changeset: 129751018061 Author:jjg Date: 2013-07-23 16:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/129751018061 8021215: javac gives incorrect doclint warnings on normal package statements Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/DocLint.java ! test/tools/doclint/packageTests/bad/Test.java + test/tools/doclint/packageTests/bad/Test.javac.out ! test/tools/doclint/packageTests/bad/Test.out ! test/tools/doclint/packageTests/bad/package-info.java + test/tools/doclint/packageTests/bad/package-info.javac.out ! test/tools/doclint/packageTests/bad/package-info.out ! test/tools/doclint/packageTests/good/Test.java ! test/tools/doclint/packageTests/good/package-info.java
[8] Request for Review: 8016916: UnstructuredName should support DirectoryString
Can I please get a review of this changeset? Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016916 Webrev: http://cr.openjdk.java.net/~juh/8016916/webrev.00/ This change adds PrintableString to the list of ASN.1 tags that PKCS9Attribute accepts for the UnstructuredName attribute. Also, the 'keytool -printcertreq' output has been enhanced because the way it was before, it would have printed: 1.2.840.113549.1.9.2 [Ljava.lang.String;@4e0e2f2a for an UnstructuredName attribute. Thanks, Jason
hg: jdk8/tl/langtools: 8016880: 42 tests in annot102* fail with compile-time errors.
Changeset: 558fe98d1ac0 Author:emc Date: 2013-07-23 20:42 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/558fe98d1ac0 8016880: 42 tests in annot102* fail with compile-time errors. Summary: Fixes error in type equality when bounds of type variables have annotations. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/annotations/typeAnnotations/ErasureTest.java
Re: code review request: 8012971 PKCS11Test hiding exception failures
PKCS11Test.java 263 System.arraycopy(data, 900, data, 0, 100); 264 is.read(data, 0, 900); Do you really mean to overwrite the data[0..99] that you just copied on line 263 with line 264? In addition, don't you want to know how much is read in order to exclude the data from earlier read(...) calls in case that the current read only returns a few bytes? Do you have the list of supported curves does NSS ECC Basic and Extensive? Some tests you check the curves and some tests you return immediately. Also, do you know if there is a mozilla bug# for the DER issue that you referred in several files? Seems hard to tell which call would trigger this NSS bug, i.e. when to add this check, until the test actually failed using the older NSS library. After seeing all these checks and list of known bugs for testing against NSS, I think we probably need a README or some wiki page to keep track all this... Thanks, Valerie On 07/17/13 13:51, Anthony Scarpino wrote: JDK-8020424 The NSS version should be detected before running crypto tests http://cr.openjdk.java.net/~ascarpino/8020424/webrev.00/ Tony
