hg: jdk8/tl/corba: 2 new changesets
Changeset: 5029f982dfae Author:cl Date: 2013-11-28 08:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/5029f982dfae Added tag jdk8-b118 for changeset d6820a414f18 ! .hgtags Changeset: 379fc7609beb Author:lana Date: 2013-12-03 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/379fc7609beb Merge
hg: jdk8/tl/jaxp: 2 new changesets
Changeset: 6b37ae056340 Author:cl Date: 2013-11-28 08:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6b37ae056340 Added tag jdk8-b118 for changeset e4e5069250e7 ! .hgtags Changeset: 69a930376c70 Author:lana Date: 2013-12-03 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/69a930376c70 Merge
hg: jdk8/tl/jdk: 6461635: [TESTBUG] BasicTests.sh test fails intermittently
Changeset: d30f49aa2d01 Author:sla Date: 2013-12-03 17:06 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f49aa2d01 6461635: [TESTBUG] BasicTests.sh test fails intermittently Summary: Transform dummy class instead of BigInteger to avoid complication by -Xshare. Ported from script to java. Reviewed-by: alanb Contributed-by: mattias.tobias...@oracle.com ! test/ProblemList.txt - test/com/sun/tools/attach/AgentSetup.sh ! test/com/sun/tools/attach/Application.java - test/com/sun/tools/attach/ApplicationSetup.sh ! test/com/sun/tools/attach/BasicTests.java - test/com/sun/tools/attach/BasicTests.sh - test/com/sun/tools/attach/CommonSetup.sh ! test/com/sun/tools/attach/PermissionTest.java - test/com/sun/tools/attach/PermissionTests.sh ! test/com/sun/tools/attach/ProviderTest.java - test/com/sun/tools/attach/ProviderTests.sh ! test/com/sun/tools/attach/RedefineAgent.java + test/com/sun/tools/attach/RedefineDummy.java + test/com/sun/tools/attach/RunnerUtil.java ! test/lib/testlibrary/jdk/testlibrary/ProcessThread.java ! test/lib/testlibrary/jdk/testlibrary/ProcessTools.java ! test/lib/testlibrary/jdk/testlibrary/Utils.java ! test/sun/tools/jstatd/JstatdTest.java
hg: jdk8/tl/jaxp: 8027973: Error in the documentation for newFactory method of the javax.xml.stream factories
Changeset: aed9ca4d33ec Author:joehw Date: 2013-12-04 00:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aed9ca4d33ec 8027973: Error in the documentation for newFactory method of the javax.xml.stream factories Reviewed-by: alanb, dfuchs, lancea, rriggs ! src/javax/xml/stream/FactoryFinder.java ! src/javax/xml/stream/XMLEventFactory.java ! src/javax/xml/stream/XMLInputFactory.java ! src/javax/xml/stream/XMLOutputFactory.java
hg: jdk8/tl/jdk: 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task
Changeset: 2aa455506c49 Author:psandoz Date: 2013-12-04 10:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aa455506c49 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task Reviewed-by: dl, chegar, mduigou ! src/share/classes/java/util/concurrent/CompletableFuture.java + test/java/util/concurrent/CompletableFuture/ThenComposeAsyncTest.java
hg: jdk8/tl/jdk: 8029117: (reflect) clarify javadoc for getMethod(...) and getMethods()
Changeset: e984e2871bf7 Author:jfranck Date: 2013-12-04 11:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e984e2871bf7 8029117: (reflect) clarify javadoc for getMethod(...) and getMethods() Reviewed-by: darcy ! src/share/classes/java/lang/Class.java
hg: jdk8/tl/jdk: 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic
Changeset: 6d583b9d99e1 Author:henryjen Date: 2013-12-04 08:12 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d583b9d99e1 8029434: Spliterator of Stream returned by BufferedReader.lines() should have NONNULL characteristic Reviewed-by: mduigou ! src/share/classes/java/io/BufferedReader.java ! test/java/io/BufferedReader/Lines.java
hg: jdk8/tl/jdk: 8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly intermittently
Changeset: 0f1332dd805c Author:coffeys Date: 2013-12-04 17:03 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1332dd805c 8029347: sun/rmi/runtime/Log/checkLogging/CheckLogging.java fails in nightly intermittently Reviewed-by: alanb ! test/sun/rmi/runtime/Log/checkLogging/CheckLogging.java
hg: jdk8/tl: 8027963: Create unlimited policy jars.
Changeset: c009462c1e92 Author:erikj Date: 2013-12-04 12:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c009462c1e92 8027963: Create unlimited policy jars. Reviewed-by: wetmore, ihse ! common/autoconf/spec.gmk.in
hg: jdk8/tl/jdk: 8029141: Add @FunctionalInterface annotation to Callable interface
Changeset: 2a6611ebfb6c Author:smarks Date: 2013-12-04 18:02 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a6611ebfb6c 8029141: Add @FunctionalInterface annotation to Callable interface Reviewed-by: chegar, alanb ! src/share/classes/java/util/concurrent/Callable.java
Re: Code Review request 8027218 EC Test
Your test changes look good. Thanks. On 3 Dec 2013, at 22:26, Anthony Scarpino anthony.scarp...@oracle.com wrote: Hi, I need a review of the below test bug fix: 8027218: TEST_BUG: sun/security/pkcs11/ec tests fail because of ever-changing key size restrictions http://cr.openjdk.java.net/~ascarpino/8027218/webrev/ Thanks Tony
hg: jdk8/tl/jdk: 7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently
Changeset: a3b804e3d5f7 Author:mchung Date: 2013-12-04 09:26 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a3b804e3d5f7 7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently Reviewed-by: mchung Contributed-by: yiming.w...@oracle.com ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdParallelGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdSerialGC.sh
hg: jdk8/tl/jdk: 8027218: TEST_BUG: sun/security/pkcs11/ec tests fail because of ever-changing key size restrictions
Changeset: 6deabb82f72b Author:ascarpino Date: 2013-12-04 10:59 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6deabb82f72b 8027218: TEST_BUG: sun/security/pkcs11/ec tests fail because of ever-changing key size restrictions Reviewed-by: vinnie ! test/sun/security/pkcs11/PKCS11Test.java ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/ec/TestCurves.java
Code Review request: 8029550 javadoc updates
Hi, I need a quick review of the below. The changes reflect comments that Brad made about javadoc @since tags not being inherited from the new methods, additionally some formatting changes. No code changes were made 8029550 javadoc since tag and formatting updates for recent Hashtable updates http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/ Tony
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 6a5a54193118 Author:mfang Date: 2013-12-04 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a5a54193118 8027244: Need to translate new error message and usage information for jar tool Reviewed-by: naoto, yhuang ! src/share/classes/sun/tools/jar/resources/jar_de.properties ! src/share/classes/sun/tools/jar/resources/jar_es.properties ! src/share/classes/sun/tools/jar/resources/jar_fr.properties ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_ko.properties ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jar/resources/jar_sv.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties Changeset: bfe3a26a2c5e Author:mfang Date: 2013-12-04 09:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfe3a26a2c5e Merge - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdParallelGC.sh - test/java/lang/management/MemoryMXBean/CollectionUsageThresholdSerialGC.sh
Re: Code Review request: 8029550 javadoc updates
Looks ok to me. I'm not really sure if code formatting changes are considered a docs change though, I think this is stretching the definition, so I would probably just make the @since changes. --Sean On 12/04/2013 02:14 PM, Anthony Scarpino wrote: Hi, I need a quick review of the below. The changes reflect comments that Brad made about javadoc @since tags not being inherited from the new methods, additionally some formatting changes. No code changes were made 8029550 javadoc since tag and formatting updates for recent Hashtable updates http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/ Tony
Re: Code Review request: 8029550 javadoc updates
Ok.. I've removed the formatting changes and updated the webrev in-place. Tony On 12/04/2013 11:52 AM, Sean Mullan wrote: Looks ok to me. I'm not really sure if code formatting changes are considered a docs change though, I think this is stretching the definition, so I would probably just make the @since changes. --Sean On 12/04/2013 02:14 PM, Anthony Scarpino wrote: Hi, I need a quick review of the below. The changes reflect comments that Brad made about javadoc @since tags not being inherited from the new methods, additionally some formatting changes. No code changes were made 8029550 javadoc since tag and formatting updates for recent Hashtable updates http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/ Tony
Re: [8] Request for Review: 8007967: Infinite loop can happen in sun.security.provider.certpath.SunCertPathBuilder.depthFirstSearchForward()
Just 2 comments on DistributionPointFetcher: You can eliminate some duplication of code by changing the existing getCRLs method to just call the new method with a null prevCert parameter. On lines 659-663, you don't need to add @code tags, that is only for javadoc comments. --Sean On 12/03/2013 01:51 PM, Jason Uh wrote: Could I please get a review for this change? This change fixes some issues in CertPath building and CRL verification. The main components of this fix are: 1. Proper setting of TrustAnchors when verifying indirect CRLs obtained from CRL Distribution Points. I added an overloaded getCRLs() method to DistributionPointFetcher for this. 2. Terminating the CertPath build immediately when the target cert is found to be revoked. 3. Some clarification in the comments. Webrev: http://cr.openjdk.java.net/~juh/8007967/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8007967 Thanks, Jason
hg: jdk8/tl/jdk: 8029552: Remove java/lang/management/MemoryMXBean/CollectionUsageThreshold.java from ProblemList.txt
Changeset: 4345e3e82c55 Author:mchung Date: 2013-12-04 13:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4345e3e82c55 8029552: Remove java/lang/management/MemoryMXBean/CollectionUsageThreshold.java from ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt
hg: jdk8/tl/langtools: 8029216: (jdeps) Provide a specific option to report JDK internal APIs
Changeset: 4a2ed1900428 Author:mchung Date: 2013-12-04 15:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a2ed1900428 8029216: (jdeps) Provide a specific option to report JDK internal APIs Reviewed-by: alanb ! src/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/share/classes/com/sun/tools/jdeps/resources/jdeps.properties ! test/tools/jdeps/APIDeps.java
Re: Code Review Request: 8028562
Hi Xuelei,
Can you help to submit this change to repository? I don't have openjdk
account.
Thanks
Kevin
On 2013/12/4 15:41, Xuelei Fan wrote:
Looks fine to me.
Xuelei
On 12/4/2013 3:24 PM, zaiyao liu wrote:
Hi Xuelei,
I have updated, please
review:http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/
http://cr.openjdk.java.net/%7Eewang/kevin/JDK-8028562/webrev.00/
Thanks
Kevin
On 2013/12/4 14:50, Xuelei Fan wrote:
On 12/4/2013 2:36 PM, zaiyao liu wrote:
Hi Xuelei,
Thanks for you suggestion. please review again:
http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/
Need a white space:
- 224 //will try to read one more roud when read error
+ 224 // will try to read one more roud when read error
The message is not clear enough:
- 302 log(will read one more round);
+ 302 log(Need to read more from client);
Otherwise, looks fine to me. Please go ahead.
Thanks,
Xuelei
Kevin
On 2013/12/4 12:06, Xuelei Fan wrote:
On 12/4/2013 11:33 AM, zaiyao liu wrote:
Hi Xuelei,
Can you help to review again.
http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/
Thanks for the update. Please pay attentions to the code conversions.
300 if (serverIn.remaining() != clientMsg.length) {
301 if(retry){
302log(will read one more round);
It might be reasonable to retry when serverIn.remaining() less than
clientMsg.length, what do you think?
Xuelei
Thanks
Kevin
On 2013/12/3 19:50, Xuelei Fan wrote:
On 12/3/2013 6:59 PM, zaiyao liu wrote:
Hi Xuelei,
I can't reproduce this issue after run 900 times at windows and
linux
platform,
It should be pretty hard to reproduce the issue in normal TCP/IP
environment.
for this fix just run one more round after get exception.
please review:
http://sqeweb.us.oracle.com/net/sqenfs-1/export1/comp/jsn/users/kevin1/webrev/8028562/webrev/
I don't think it is the expected fix. Looks like the underlying
issue
is that serverOut.remaining() == 0 (line 282) does not always mean
the
server has received all of the client message (line 298,
(serverIn.remaining() != clientMsg.length)). I would suggest run one
more round (at line 241) after server message delivered
(serverOut.remaining() == 0 (line 282)).
The logic looks like, in runTest(boolean):
loop (line 241):
read client message
send server message
if server delivered all server message {
if server received all client message {
check the message
} else {
loop one more time, go to loop (only one time?).
}
}
Hope it helps.
Xuelei
Thanks
Kevin
Re: Code Review request: 8029550 javadoc updates
I really don't think formatting changes as part of other approved changes would be taboo. Joe Darcy has the same opinion. I would restore, but too late now. I knew I should have got to this email earlier. :) One question, I haven't tried this out, but will the simple @since 8 additions clobber all of the existing Description copied from... in methods like getOrDefault() ? If so, then we should probably wait until that bug is fixed. Brad On 12/4/2013 12:32 PM, Anthony Scarpino wrote: Ok.. I've removed the formatting changes and updated the webrev in-place. Tony On 12/04/2013 11:52 AM, Sean Mullan wrote: Looks ok to me. I'm not really sure if code formatting changes are considered a docs change though, I think this is stretching the definition, so I would probably just make the @since changes. --Sean On 12/04/2013 02:14 PM, Anthony Scarpino wrote: Hi, I need a quick review of the below. The changes reflect comments that Brad made about javadoc @since tags not being inherited from the new methods, additionally some formatting changes. No code changes were made 8029550 javadoc since tag and formatting updates for recent Hashtable updates http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/ Tony
Re: Code Review request: 8029550 javadoc updates
On 12/04/2013 05:46 PM, Bradford Wetmore wrote: I really don't think formatting changes as part of other approved changes would be taboo. Joe Darcy has the same opinion. I would restore, but too late now. I knew I should have got to this email earlier. :) Yeah, I wish you had sent earlier since I just pushed it. One question, I haven't tried this out, but will the simple @since 8 additions clobber all of the existing Description copied from... in methods like getOrDefault() ? If so, then we should probably wait until that bug is fixed. No, I double checked that it wouldn't clobber the other descriptions. If it had I would have jumped on the bandwagon that it's a javadoc problem Brad On 12/4/2013 12:32 PM, Anthony Scarpino wrote: Ok.. I've removed the formatting changes and updated the webrev in-place. Tony On 12/04/2013 11:52 AM, Sean Mullan wrote: Looks ok to me. I'm not really sure if code formatting changes are considered a docs change though, I think this is stretching the definition, so I would probably just make the @since changes. --Sean On 12/04/2013 02:14 PM, Anthony Scarpino wrote: Hi, I need a quick review of the below. The changes reflect comments that Brad made about javadoc @since tags not being inherited from the new methods, additionally some formatting changes. No code changes were made 8029550 javadoc since tag and formatting updates for recent Hashtable updates http://cr.openjdk.java.net/~ascarpino/8029550/webrev.00/ Tony
hg: jdk8/tl/jdk: 8029550: javadoc since tag for recent Hashtable updates
Changeset: 014c04fd7460 Author:ascarpino Date: 2013-12-04 17:37 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/014c04fd7460 8029550: javadoc since tag for recent Hashtable updates Reviewed-by: mullan ! src/share/classes/java/security/Provider.java
