Withdrawn: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
On Wed, 29 Sep 2021 19:31:53 GMT, Alexey Bakhtin wrote: > Please review the patch for JDK-8274524 > > The fix just adds locks around InputStream read and skip operations to > prevent concurrent read from socket. > sun/security/ssl jtreg tests passed > api/javax_net/ssl/SSLSocket/setUseClientMode jck test passed This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5760
Integrated: Merge jdk18
On Thu, 6 Jan 2022 00:42:14 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 844dfb3a Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/844dfb3ab6a1d8b68ccdcc73726ee0f73cfcb3c8 Stats: 750 lines in 28 files changed: 687 ins; 8 del; 55 mod Merge - PR: https://git.openjdk.java.net/jdk/pull/6975
RFR: Merge jdk18
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18 - 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 - 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS - 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64 - 8278897: Alignment of heap segments is not enforced correctly - 8279222: Incorrect legacyMap.get in java.security.Provider after JDK-8276660 - 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.java.net/?repo=jdk=6975=00.0 - jdk18: https://webrevs.openjdk.java.net/?repo=jdk=6975=00.1 Changes: https://git.openjdk.java.net/jdk/pull/6975/files Stats: 750 lines in 28 files changed: 687 ins; 8 del; 55 mod Patch: https://git.openjdk.java.net/jdk/pull/6975.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6975/head:pull/6975 PR: https://git.openjdk.java.net/jdk/pull/6975
[jdk18] Integrated: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
On Wed, 5 Jan 2022 17:22:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > > JDK-8279529 ProblemList > java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 > JDK-8279532 ProblemList > sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java This pull request has now been integrated. Changeset: 564c8c63 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk18/commit/564c8c6390ee380ab2e2eb73ef22c3184c369f9f Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java Reviewed-by: jnimeh - PR: https://git.openjdk.java.net/jdk18/pull/83
Re: [jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
On Wed, 5 Jan 2022 17:39:16 GMT, Jamil Nimeh wrote: >> A couple of trivial ProblemListings: >> >> JDK-8279529 ProblemList >> java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on >> macosx-aarch64 >> JDK-8279532 ProblemList >> sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java > > Looks good to me. @jnimeh - Thanks for the review. @AlanBateman - I presume you are talking about java/nio/channels/DatagramChannel/ManySourcesAndTargets.java. It could be a macosx-aarch64 config issue and if we can get to the bottom of that issue, then we can re-enable the test. For now, with the JDK18 clock ticking down, I'd like to reduce the noise in the CI. Did you plan on adding your reviewer approval here? - PR: https://git.openjdk.java.net/jdk18/pull/83
Re: [jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
On Wed, 5 Jan 2022 17:22:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > > JDK-8279529 ProblemList > java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 > JDK-8279532 ProblemList > sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java This looks okay although I think we're working around a macOS or configuration issue rather than a JDK or test issue. - PR: https://git.openjdk.java.net/jdk18/pull/83
Re: [jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
On Wed, 5 Jan 2022 17:22:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > > JDK-8279529 ProblemList > java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 > JDK-8279532 ProblemList > sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java Looks good to me. - Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.java.net/jdk18/pull/83
[jdk18] RFR: 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64
A couple of trivial ProblemListings: JDK-8279529 ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 JDK-8279532 ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java - Commit messages: - 8279532: ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java - 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 Changes: https://git.openjdk.java.net/jdk18/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18=83=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279529 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk18/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/83/head:pull/83 PR: https://git.openjdk.java.net/jdk18/pull/83
RFR: 8279520: SPNEGO has not passed channel binding info into the underlying mechanism
8279520: SPNEGO has not passed channel binding info into the underlying mechanism - Commit messages: - 8279520: SPNEGO has not passed channel binding info into the underlying mechanism Changes: https://git.openjdk.java.net/jdk/pull/6969/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6969=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279520 Stats: 21 lines in 2 files changed: 8 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk/pull/6969.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6969/head:pull/6969 PR: https://git.openjdk.java.net/jdk/pull/6969
[jdk18] Integrated: 8278897: Alignment of heap segments is not enforced correctly
On Thu, 16 Dec 2021 12:31:01 GMT, Maurizio Cimadamore wrote: > This PR fixes an issue with alignment constraints not being enforced > correctly on on-heap segments dereference/copy operations. Alignment of > on-heap segments cannot be computed exactly, as alignment of elements in > arrays is, ultimately a VM implementation detail. Because of this, alignment > checks on heap segments can fail or pass depending on the platform being used. > > For more details about the problem and the solution please refer to: > https://mail.openjdk.java.net/pipermail/panama-dev/2021-November/015852.html This pull request has now been integrated. Changeset: 9d43d25d Author:Maurizio Cimadamore URL: https://git.openjdk.java.net/jdk18/commit/9d43d25da8bcfff425a795dcc230914a384a5c82 Stats: 600 lines in 20 files changed: 566 ins; 0 del; 34 mod 8278897: Alignment of heap segments is not enforced correctly Reviewed-by: jvernee - PR: https://git.openjdk.java.net/jdk18/pull/37
Re: RFR: 8255739: x509Certificate returns � for invalid subjectAlternativeNames
On Thu, 23 Dec 2021 11:59:18 GMT, Masanori Yano wrote: > Could you please review the JDK-8255739 bug fix? > > I think sun.security.x509.SubjectAlternativeNameExtension() should throw an > exception for incorrect SubjectAlternativeNames instead of returning the > substituted characters, which is explained in the description of BugDB. > > I modified DerValue.readStringInternal() not to read incorrect > SubjectAlternativeNames and throw an IOException. > sun.security.x509.X509CertInfo.parse() catch the IOExcepton and ignore it if > SAN is a non-ciritical extension like the behavior of the IOException in > readStringInternal(). So I added a test with -Djava.security.debug=x509 to > confirm that. Could someone please review this pull request? - PR: https://git.openjdk.java.net/jdk/pull/6928
Withdrawn: 8274308: Improve efficiency for HandshakeContext initialization.
On Sat, 2 Oct 2021 05:45:47 GMT, Clive Verghese wrote: > Hi, > > We have identified that the `HandshakeContext` initialization takes up a > close to 50% of the flame graph for startHandshake. I have moved the > computation of the `activeProtocols` and `activeCipherSuites` from the > HandshakeContext constructor to SSLConfiguration class because the values > used to compute the two list are available in the SSLConfiguration. > > In order to reuse this, I have initialized SSLConfiguration in the > SSLSocketFactory and reused this when possible for Client Socket Constructors > in the SSLSocketImpl. > > Sockets created from the SSLSocketFactory see this improvements. > > Old Benchmarks > > Benchmark Mode Cnt Score Error Units > SSLStartHandshake.handshakeBenchmark thrpt 25 0.247 ± 0.011 ops/ms > SSLStartHandshake.handshakeBenchmarkavgt 25 4.210 ± 0.445 ms/op > > New Benchmarks > > SSLStartHandshake.handshakeBenchmark thrpt 25 0.257 ± 0.017 ops/ms > SSLStartHandshake.handshakeBenchmarkavgt 25 3.967 ± 0.208 ms/op > > > > I have also attached the JFR profiles from before and after the change. > Before > src="https://user-images.githubusercontent.com/934461/135705010-a8502966-c6be-4cb5-b743-4a5b382c8e1f.png;> > > After > src="https://user-images.githubusercontent.com/934461/135705007-ea852b36-e10f-4741-a166-249270b34465.png;> > > We have been able to optimize the `TransportContext.kickstart` function by > removing the `HandshakeContext.` initialization and reduce the time to > start the handshake by reusing `activeProtocols` and `activeCipherSuites` > > In addition to the SSL and http tests, I have run tier-1 and tier-2 tests and > ensure that they pass. > > Looking for your feedback This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5793
