Re: RFR: 8273553: sun.security.ssl.SSLEngineImpl.closeInbound also has similar error of JDK-8253368

2022-03-20 Thread Xue-Lei Andrew Fan 
On Sat, 12 Mar 2022 00:55:07 GMT, Bradford Wetmore  wrote:

> JDK-8253368 changed the behavior of SSLSocket to no longer throw a fatal 
> internal_error (80) and invalidate existing sessions (either completed or 
> under construction) as described in (RFC 4346/TLSv1.1+) if a connection was 
> closed without receiving a close_notify alert from the peer.  
> 
> This change introduces similar behavior to SSLEngine.
> 
> The unit test checks that closing the read(input) sides of the 
> SSLSocket/SSLEngine throws an SSLException, but doesn't invalidate their 
> respective sessions.
> 
> Tier1/2 mach5 tests have been successfully run.

Looks good to me.  Thanks!

-

Marked as reviewed by xuelei (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7796

Re: RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread Bradford Wetmore 
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov  wrote:

> Fix repeated typo `exeption`

Good grief!  I wouldn't have expected it to be so widespread.  

Thanks for noticing and fixing.

-

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread David Holmes 
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov  wrote:

> Fix repeated typo `exeption`

Looks good.

Thanks for cleaning this up.

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread Iris Clark 
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov  wrote:

> Fix repeated type `exeption`

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread Xue-Lei Andrew Fan 
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov  wrote:

> Fix repeated type `exeption`

Looks good to me.  Thanks!

-

Marked as reviewed by xuelei (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7879

RFR: 8283426: Fix 'exeption' typo

2022-03-20 Thread Andrey Turbanov 
Fix repeated type `exeption`

-

Commit messages:
 - [PATCH] Typo 'Exeption' instead of 'Exception'

Changes: https://git.openjdk.java.net/jdk/pull/7879/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7879&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8283426
  Stats: 24 lines in 10 files changed: 0 ins; 2 del; 22 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7879.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7879/head:pull/7879

PR: https://git.openjdk.java.net/jdk/pull/7879

Integrated: 8282723: Add constructors taking a cause to JSSE exceptions

2022-03-20 Thread Xue-Lei Andrew Fan 
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan  wrote:

> Please review this small API enhancement to add the usual constructors taking 
> a cause to javax.net.ssl exceptions.  The use of initCause in the JSSE 
> implementation code is updated to use the new constructors accordingly.
> 
> Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724

This pull request has now been integrated.

Changeset: 4df67426
Author:Xue-Lei Andrew Fan 
URL:   
https://git.openjdk.java.net/jdk/commit/4df67426ed02f18af0757897acb28b636a317a91
Stats: 396 lines in 30 files changed: 264 ins; 53 del; 79 mod

8282723: Add constructors taking a cause to JSSE exceptions

Reviewed-by: wetmore, iris

-

PR: https://git.openjdk.java.net/jdk/pull/7722