Request for review : 8032573 - CertificateFactory.getInstance("X.509").generateCertificates(InputStream) does not throw CertificateException for invalid input
HI Jamil, All, Request your review for backport of bug# 8032573 to 7u-dev. https://bugs.openjdk.java.net/browse/JDK-8032573 webrev: http://cr.openjdk.java.net/~mbankal/8032573/webrev.00/ rgds mala
Request for review : 7196009-SunPkcs11 provider fails to parse config path containing parenthesis
HI Valerie, All, Request your review for backport of bug 7196009 to 7u-dev. https://bugs.openjdk.java.net/browse/JDK-7196009 webrev: http://cr.openjdk.java.net/~mbankal/7196009/webrev.00/ rgds mala
Request for review : 8037591 - Still seeing Invalid Padding length SSL errors after the fix for JDK-8014618
HI Brad, All, Request your review for bug # 8037591 https://bugs.openjdk.java.net/browse/JDK-8037591 Solaris mechanisms trims out the leading zeros due to which the Invalid Padding length errors are to be seen. The fix disables the mechanisms in the sunpkcs11-solaris.cfg. webrev : http://cr.openjdk.java.net/~mbankal/8037591/webrev.00/ rgds mala
Request for review : 8054817: File ccache only recognizes Linux and Solaris defaults
HI Max, All, Request to review the changes for the backport of 8054817 to jdk7u-dev. webrev : http://cr.openjdk.java.net/~mbankal/8054817/webrev.00/ JDK9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ec98f141c757 JDK8 changeset : http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ec98f141c757 The backport has been derived from JDK8 changes. Thanks. rgds mala
Review Request : JDK-7197159 : accept different kvno if there no match
HI Max, Request your review for backport of bug# JDK-7197159 : accept different kvno if there no match , to 7u-dev webrev : http://cr.openjdk.java.net/~mbankal/7197159/webrev.00/ regression tests : http://nightsvr.us.oracle.com/export5/users/mbankal/7u80/testing/7197159/JTreport/html/index.html Thanks. rgds mala
Re: Request for review : backport of bug# 8031046 to 7u-dev
HI Max, Thanks for the review. Yes it means no extra code changes. :) rgds mala On 8/6/2014 6:53 AM, Weijun Wang wrote: Hi Mala Code change looks fine. When you say "Direct backport", is it equivalent to "applying the same patch with no conflict"? :-) Thanks Max On 8/5/2014 17:32, mala bankal wrote: HI, Request review for the direct backport of bug# 8031046 to 7u-dev. http://cr.openjdk.java.net/~mbankal/8031046/webrev.00/ JDK9 Changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ab914c760352 JDK8 Changeset : http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b32e9aba4888 Regression test is not added since it requires special setup, SQE bug filed for the same : https://bugs.openjdk.java.net/browse/INTJDK-7604925 Thanks. rgds mala
Request for review : backport of bug# 8031046 to 7u-dev
HI, Request review for the direct backport of bug# 8031046 to 7u-dev. http://cr.openjdk.java.net/~mbankal/8031046/webrev.00/ JDK9 Changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ab914c760352 JDK8 Changeset : http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b32e9aba4888 Regression test is not added since it requires special setup, SQE bug filed for the same : https://bugs.openjdk.java.net/browse/INTJDK-7604925 Thanks. rgds mala
Request review for backport of bug#8036709 to 7u-dev
Hi, Request review for the direct backport of bug#8036709 from 9/8 to 7u-dev. http://cr.openjdk.java.net/~mbankal/8036709/webrev.00/ JDK9 changeset : http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d1978cf32bc1 JDK8 changeset : http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/2aa925ce9852 Thanks. rgds mala
Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM
Yes there was some problem with the webrev generation , i had to generate it too many times. But i made sure all changes are present. Thanks for taking a detailed look into this !! rgds mala On 12/4/2012 10:52 AM, Xuelei Fan wrote: Let's look at the history of the parent workspace; 1. You putback CR 7192392, Dec 2. 2. David undo the putback, Dec 3, 10:33 3. You bringover the workspace, Dec 3, 10:45 4. The you putback CR 7192392, Dec 3. 11:42 5. Java RE bringover the workspace, maybe for jar building. The processes look right to me. But the webrev is incorrect. From item 4, it seems that you have putbacked the fix into the master workspace. I looked more into a few history of the updated files. It seems that you did the putback right. OK, the webrev is incorrect. I guess that you did not generate a new webrev before you integrate the chanegs. It's OK to me, but I need a confirm in case of any mis-understanding from my side. Thanks, Xuelei On 12/4/2012 12:51 PM, mala bankal wrote: HI Andrew, No it is not based on previous integration. I brought over a fresh wses after Dave's rollback and made all changes again. Made the changes and built the wses again. It took me more time but i did it right. Now before final integration i checked if changes are present in MASTER ws. rgds mala On 12/4/2012 10:19 AM, Xuelei Fan wrote: It seems that you webrev is based on your previous integration. I may be wrong, but as my previous comment, I think as David has rollover your previous integration, you need to rollover the changes in your local workspace as well, or bringover new workspace, and then generate the webrev, and then do a fresh integration. You webrev in the request make me nervous that you properly cannot do the integration properly. I would suggest: 1. backup the updated files. 2. bringover a new worksapce 3. merge the updated files into the new workspace 4. new webrev and ask for approval 5. integrate the change in the new workspace PLEASE DON'T USE the old workspaces unless you know how to handle it properly. ;-) I though you have accept my and Brad's comments, and added me as the approve. I will add my name when you confirm to my above concerns. Thanks, Xuelei On 12/4/2012 12:31 PM, mala.ban...@oracle.com wrote: mala.ban...@oracle.com's following code review request has been sent to xuelei@oracle.com. Please review the code before 12/8/12_8:29_PM. If xuelei@oracle.com can not meet the review timeline, please contact mala.ban...@oracle.com to negotiate for an appropriate time-frame. http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4897 webrev: http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4897 == Escalation ID : Escalation Synopsis : Bug ID : JDK-7192392 Bug Synopsis : Better validation of client keys Request Engineer : mala.ban...@oracle.com Code Reviewer : xuelei@oracle.com Parent Workspace : http://jdksrc.sfbay.sun.com/hg/jdk5u/jdk5.0u39-dev/j2se Child Workspace : /net/nightsvr.sfbay/export5/users/mbankal/7192392/5.0u39/j2se Platforms : Shared Code Version : JDK5.0_u39 Fix information : Backport Severity : normal - level 1 Submit Date : 12/3/12 8:29 PM Problem and Fix Description : Please see : https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=14474441 JSSE webrev: http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JSSE/ JCE webrev: http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JCE/ PKCS webrev : http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/PKCS/ removed KeyUtil.java from J2SE ws, it was introduced in JCE, JSSE. PKCS wses to avoid dependency on ALT_BOOTDIR and build issues due to the dependency. Also updating RE built jar files Modified source lists : make/tools/crypto/jce/sunjce_provider.jar make/tools/crypto/jsse/jsse.jar make/tools/crypto/pkcs11/sunpkcs11.jar Approve Info : Putback info : == This message is autogenerated by code management tool.
Re: JPSE-J2SE Code Review Request-JDK-7192392-jdk150_u39#4897, due by 12/8/12_8:29_PM
HI Andrew, No it is not based on previous integration. I brought over a fresh wses after Dave's rollback and made all changes again. Made the changes and built the wses again. It took me more time but i did it right. Now before final integration i checked if changes are present in MASTER ws. rgds mala On 12/4/2012 10:19 AM, Xuelei Fan wrote: It seems that you webrev is based on your previous integration. I may be wrong, but as my previous comment, I think as David has rollover your previous integration, you need to rollover the changes in your local workspace as well, or bringover new workspace, and then generate the webrev, and then do a fresh integration. You webrev in the request make me nervous that you properly cannot do the integration properly. I would suggest: 1. backup the updated files. 2. bringover a new worksapce 3. merge the updated files into the new workspace 4. new webrev and ask for approval 5. integrate the change in the new workspace PLEASE DON'T USE the old workspaces unless you know how to handle it properly. ;-) I though you have accept my and Brad's comments, and added me as the approve. I will add my name when you confirm to my above concerns. Thanks, Xuelei On 12/4/2012 12:31 PM, mala.ban...@oracle.com wrote: mala.ban...@oracle.com's following code review request has been sent to xuelei@oracle.com. Please review the code before 12/8/12_8:29_PM. If xuelei@oracle.com can not meet the review timeline, please contact mala.ban...@oracle.com to negotiate for an appropriate time-frame. http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4897 webrev: http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4897 == Escalation ID : Escalation Synopsis : Bug ID : JDK-7192392 Bug Synopsis : Better validation of client keys Request Engineer : mala.ban...@oracle.com Code Reviewer : xuelei@oracle.com Parent Workspace : http://jdksrc.sfbay.sun.com/hg/jdk5u/jdk5.0u39-dev/j2se Child Workspace : /net/nightsvr.sfbay/export5/users/mbankal/7192392/5.0u39/j2se Platforms : Shared Code Version : JDK5.0_u39 Fix information : Backport Severity : normal - level 1 Submit Date : 12/3/12 8:29 PM Problem and Fix Description : Please see : https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=14474441 JSSE webrev: http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JSSE/ JCE webrev: http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JCE/ PKCS webrev : http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/PKCS/ removed KeyUtil.java from J2SE ws, it was introduced in JCE, JSSE. PKCS wses to avoid dependency on ALT_BOOTDIR and build issues due to the dependency. Also updating RE built jar files Modified source lists : make/tools/crypto/jce/sunjce_provider.jar make/tools/crypto/jsse/jsse.jar make/tools/crypto/pkcs11/sunpkcs11.jar Approve Info : Putback info : == This message is autogenerated by code management tool.
Request for approval (7157903 : JSSE client sockets are very slow) for 6-open
HI, Request approval for : 7157903 JSSE client sockets are very slow for 6-open webrev : http://cr.openjdk.java.net/~mbankal/7157903/webrev.00/ Nagle Algorithm (TCP_NODELAY) which affects small packets is false by default. As a result, the kernel was throttling the JSSE output waiting for the peer's TCP ACK before sending the next packet. Fix is to combine the small/output packets if TCP_NODELAY is not active. JDK8 and JDK7 integrations : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/10480cf00dcd http://hg.openjdk.java.net/icedtea/jdk7/jdk/rev/0b287839e567 rgds mala
hg: jdk8/tl/jdk: 2 new changesets
Changeset: 52bc200b14e5 Author:mbankal Date: 2011-09-14 21:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/52bc200b14e5 7049963: DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC Reviewed-by: mullan ! src/share/classes/sun/security/x509/AVA.java Changeset: 1260be51581f Author:mbankal Date: 2011-09-14 22:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1260be51581f Merge
Re: request for reviews for bug# 7049963
HI Sean, Yes i have done a successful build and tests, i can point you to the builds and tests. rgds mala On 9/14/2011 1:22 AM, Sean Mullan wrote: On 9/13/11 12:53 PM, Mala Bankal wrote: HI Sean, Request for review : bug# 7049963 - DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC For jdk8 http://cr.openjdk.java.net/~mbankal/7049963/webrev_jdk8.00/ Looks fine. However, you are not a committer on the jdk8 project [1] so you do not have the rights to push changesets to JDK 8. I will need to push this for you. Have you also done a successful jprt build and test? If so, then I'll contact you separately to work out how I can push the changeset for you. for jdk7u2 http://cr.openjdk.java.net/~mbankal/7049963/webrev.00/ The process for pushing changesets to JDK 7 updates are done differently [2]. Also, you are not a committer on the jdk7u project so someone else will have to push for you. Let's work on getting the fix into JDK 8 first. --Sean [1] http://openjdk.java.net/census/ [2] http://openjdk.java.net/projects/jdk7u/
request for reviews for bug# 7049963
HI Sean, Request for review : bug# 7049963 - DISTINGUISHED NAMES FOR CERT ARE ESCAPED IN JROCKIT 1.6(NOT COMPATIBLE WITH JROC For jdk8 http://cr.openjdk.java.net/~mbankal/7049963/webrev_jdk8.00/ for jdk7u2 http://cr.openjdk.java.net/~mbankal/7049963/webrev.00/ Since the testcase will be integrated in the closedjdk repository it is raised separately: http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4249 http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4251 Thanks . rgds mala
