[9] RFR: 8078823: javax/net/ssl/ciphersuites/DisabledAlgorithms.java fails intermittently
Hello, Please review this fix for javax/net/ssl/ciphersuites/DisabledAlgorithms.java test. It fails very rarely with SocketException. The test runs clients in main thread, but a server runs in a separate thread. In checkFailure() method, clients expect a SSLHandshakeException, and when it occurs, they stop the server by calling SSLServer.stop() method which makes the server close its server socket. The server usually throws an expected SSLHandshakeException, then server socket is closed. But it seems that sometimes the server closes the server socket before handshake failure is processed. As a result, IOException happens instead of SSLHandshakeException. The server should stop if any exception occurs, and clients shouldn't stop the server by themselves. Bug: https://bugs.openjdk.java.net/browse/JDK-8078823 Webrev: http://cr.openjdk.java.net/~asmotrak/8078823/webrev.00/ Artem
Re: [9] RFR: 8078823: javax/net/ssl/ciphersuites/DisabledAlgorithms.java fails intermittently
Looks fine to me. Thanks, Xuelei On 5/25/2015 11:58 PM, Artem Smotrakov wrote: Hello, Please review this fix for javax/net/ssl/ciphersuites/DisabledAlgorithms.java test. It fails very rarely with SocketException. The test runs clients in main thread, but a server runs in a separate thread. In checkFailure() method, clients expect a SSLHandshakeException, and when it occurs, they stop the server by calling SSLServer.stop() method which makes the server close its server socket. The server usually throws an expected SSLHandshakeException, then server socket is closed. But it seems that sometimes the server closes the server socket before handshake failure is processed. As a result, IOException happens instead of SSLHandshakeException. The server should stop if any exception occurs, and clients shouldn't stop the server by themselves. Bug: https://bugs.openjdk.java.net/browse/JDK-8078823 Webrev: http://cr.openjdk.java.net/~asmotrak/8078823/webrev.00/ Artem
