Re: [RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

2020-06-09 Thread Jamil Nimeh 

+1

--Jamil

On 6/8/2020 12:22 PM, Sergey Kuksenko wrote:

Looks fine to me.

On 6/8/20 11:15 AM, Anthony Scarpino wrote:

Hi,

I need a quick code review of updates to the microbenchmarks tests 
for EC.  These tests used curves that are now disabled by default in 15.


https://cr.openjdk.java.net/~ascarpino/8241680/webrev/

thanks

Tony

Re: [RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

2020-06-08 Thread Sergey Kuksenko 

Looks fine to me.

On 6/8/20 11:15 AM, Anthony Scarpino wrote:

Hi,

I need a quick code review of updates to the microbenchmarks tests for 
EC.  These tests used curves that are now disabled by default in 15.


https://cr.openjdk.java.net/~ascarpino/8241680/webrev/

thanks

Tony

Re: [RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

2020-06-08 Thread Claes Redestad 

+1

/Claes

On 2020-06-08 20:27, eric.casp...@oracle.com wrote:

Looks fine to me.
Eric


On 6/8/20 2:15 PM, Anthony Scarpino wrote:

Hi,

I need a quick code review of updates to the microbenchmarks tests for 
EC.  These tests used curves that are now disabled by default in 15.


https://cr.openjdk.java.net/~ascarpino/8241680/webrev/

thanks

Tony

Re: [RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

2020-06-08 Thread eric . caspole 

Looks fine to me.
Eric


On 6/8/20 2:15 PM, Anthony Scarpino wrote:

Hi,

I need a quick code review of updates to the microbenchmarks tests for 
EC.  These tests used curves that are now disabled by default in 15.


https://cr.openjdk.java.net/~ascarpino/8241680/webrev/

thanks

Tony

[RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

2020-06-08 Thread Anthony Scarpino 

Hi,

I need a quick code review of updates to the microbenchmarks tests for 
EC.  These tests used curves that are now disabled by default in 15.


https://cr.openjdk.java.net/~ascarpino/8241680/webrev/

thanks

Tony