Re: Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-13 Thread Bradford Wetmore 

Looks ok to me too.

Brad


On 9/11/2018 8:43 PM, Jamil Nimeh wrote:

Looks good to me.

Thanks,
--Jamil

On 9/11/2018 7:22 PM, Xuelei Fan wrote:

Hi Jamil,

Would you please review the fix for the NPE issue:
   http://cr.openjdk.java.net/~xuelei/8209916/webrev.00/

The issue may happen if the client supports a SunJSSE provider known 
but not supported named group.


Thanks,
Xuelei

Re: Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-12 Thread Thomas Lußnig 

Hi,

does the fix work if there is only one unknown named group ?
Not that the connection fails than with an better error text instead of 
skiping the unknown group.


Gruß Thomas

On 12.09.2018 04:22:49, Xuelei Fan wrote:

Hi Jamil,

Would you please review the fix for the NPE issue:
   http://cr.openjdk.java.net/~xuelei/8209916/webrev.00/

The issue may happen if the client supports a SunJSSE provider known 
but not supported named group.


Thanks,
Xuelei

Re: Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-11 Thread Jamil Nimeh 

Looks good to me.

Thanks,
--Jamil

On 9/11/2018 7:22 PM, Xuelei Fan wrote:

Hi Jamil,

Would you please review the fix for the NPE issue:
   http://cr.openjdk.java.net/~xuelei/8209916/webrev.00/

The issue may happen if the client supports a SunJSSE provider known 
but not supported named group.


Thanks,
Xuelei

Re: Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-11 Thread Jamil Nimeh 
Yes I will take a look at this tonight.


--Jamil
 Original message From: Xuelei Fan  
Date: 9/11/18  7:22 PM  (GMT-08:00) To: security-dev@openjdk.java.net, Jamil 
Nimeh  Subject: Code Review Request, JDK-8209916 : 
NPE in SupportedGroupsExtension 
Hi Jamil,

Would you please review the fix for the NPE issue:
    http://cr.openjdk.java.net/~xuelei/8209916/webrev.00/

The issue may happen if the client supports a SunJSSE provider known but 
not supported named group.

Thanks,
Xuelei

Code Review Request, JDK-8209916 : NPE in SupportedGroupsExtension

2018-09-11 Thread Xuelei Fan 

Hi Jamil,

Would you please review the fix for the NPE issue:
   http://cr.openjdk.java.net/~xuelei/8209916/webrev.00/

The issue may happen if the client supports a SunJSSE provider known but 
not supported named group.


Thanks,
Xuelei