Re: Code review request, 8044771, PKIXValidator indent cleanup

2014-06-04 Thread Xuelei Fan
On 6/5/2014 2:00 AM, Bradford Wetmore wrote:
> 
> On 6/4/2014 2:38 AM, Xuelei Fan wrote:
>> Webrev toolkit ignore space update so the webrev above looks strange.
>> The major update is cleanup the indentation.   For example, 4 leading
>> space are removed at line 250 of PKIXValidator.java.
> 
> Use the -b option in webrev to force whitespace changes to appear.
> 
Thanks!

Xuelei



Re: Code review request, 8044771, PKIXValidator indent cleanup

2014-06-04 Thread Bradford Wetmore


On 6/4/2014 2:38 AM, Xuelei Fan wrote:

Webrev toolkit ignore space update so the webrev above looks strange.
The major update is cleanup the indentation.   For example, 4 leading
space are removed at line 250 of PKIXValidator.java.


Use the -b option in webrev to force whitespace changes to appear.

Brad





Re: Code review request, 8044771, PKIXValidator indent cleanup

2014-06-04 Thread Wang Weijun
Looks fine. Please remember to add a noreg-cleanup to JBS.

Thanks
Max

On Jun 4, 2014, at 17:38, Xuelei Fan  wrote:

> Hi,
> 
> Please review this code conversion cleanup update:
> 
>http://cr.openjdk.java.net/~xuelei/8044771/webrev.00/
> 
> Webrev toolkit ignore space update so the webrev above looks strange.
> The major update is cleanup the indentation.   For example, 4 leading
> space are removed at line 250 of PKIXValidator.java.
> 
> Thanks,
> Xuelei



Code review request, 8044771, PKIXValidator indent cleanup

2014-06-04 Thread Xuelei Fan
Hi,

Please review this code conversion cleanup update:

http://cr.openjdk.java.net/~xuelei/8044771/webrev.00/

Webrev toolkit ignore space update so the webrev above looks strange.
The major update is cleanup the indentation.   For example, 4 leading
space are removed at line 250 of PKIXValidator.java.

Thanks,
Xuelei