Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms [v3]

2020-10-30 Thread Sean Mullan
On Fri, 9 Oct 2020 01:33:38 GMT, Weijun Wang  wrote:

>> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. 
>> Please also review the CSR at 
>> https://bugs.openjdk.java.net/browse/JDK-8228481.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   update README and exclude README

Marked as reviewed by mullan (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/473


Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms [v3]

2020-10-08 Thread Weijun Wang
On Fri, 9 Oct 2020 00:07:39 GMT, Weijun Wang  wrote:

>> I tried but cannot find a way to tell if a system is Windows Server 2016 or 
>> 2019. Their os.version is all 10.0. I've
>> filed an enhancement at https://bugs.openjdk.java.net/browse/JDK-8254241 for 
>> it. That said, I did try running the test
>> on a Windows Server 2019 using new algorithms and it succeeds.
>
> There are existing tests reading openssl generated pkcs12 files in
> https://github.com/openjdk/jdk/tree/master/test/jdk/sun/security/pkcs12/params,
>  it already contains files using both
> weak and strong algorithms.

Update `params/README`, exclude it from the de-BASE64 list (don't know it 
succeeded) in the `ParamsTest.java` test.
Also remove a useless call in the test.

Thinking about adding a benchmark, but it will be in another commit.

-

PR: https://git.openjdk.java.net/jdk/pull/473


Re: RFR: 8153005: Upgrade the default PKCS12 encryption/MAC algorithms [v3]

2020-10-08 Thread Weijun Wang
> Default algorithms are bumped to be based on PBES2 with AES-256 and SHA-256. 
> Please also review the CSR at
> https://bugs.openjdk.java.net/browse/JDK-8228481.

Weijun Wang has updated the pull request incrementally with one additional 
commit since the last revision:

  update README and exclude README

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/473/files
  - new: https://git.openjdk.java.net/jdk/pull/473/files/6b5c5b5e..41be78aa

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=473=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=473=01-02

  Stats: 39 lines in 2 files changed: 7 ins; 6 del; 26 mod
  Patch: https://git.openjdk.java.net/jdk/pull/473.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/473/head:pull/473

PR: https://git.openjdk.java.net/jdk/pull/473