Re: RFR: 8186958: Need method to create pre-sized HashMap [v20]

2022-04-14 Thread Joe Wang
On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess  wrote:

>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>>  line 3:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights 
>>> reserved.
>>> 3:  */
>> 
>> The LastModified tag was missing in this class. Pls use this opportunity to 
>> add it in the same format as the other classes (CoreDocumentImpl, 
>> XSAttributeChecker), that is after line 52. Thanks.
>
> @JoeWang-Java done.

Thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/7928


Re: RFR: 8186958: Need method to create pre-sized HashMap [v20]

2022-04-14 Thread XenoAmess
On Thu, 14 Apr 2022 17:23:42 GMT, Joe Wang  wrote:

>> XenoAmess has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   revert changes on ProcessEnvironment
>
> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>  line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights 
>> reserved.
>> 3:  */
> 
> The LastModified tag was missing in this class. Pls use this opportunity to 
> add it in the same format as the other classes (CoreDocumentImpl, 
> XSAttributeChecker), that is after line 52. Thanks.

@JoeWang-Java done.

-

PR: https://git.openjdk.java.net/jdk/pull/7928


Re: RFR: 8186958: Need method to create pre-sized HashMap [v20]

2022-04-14 Thread Joe Wang
On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess  wrote:

>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   revert changes on ProcessEnvironment

src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
 line 3:

> 1: /*
> 2:  * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights 
> reserved.
> 3:  */

The LastModified tag was missing in this class. Pls use this opportunity to add 
it in the same format as the other classes (CoreDocumentImpl, 
XSAttributeChecker), that is after line 52. Thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/7928


Re: RFR: 8186958: Need method to create pre-sized HashMap [v20]

2022-04-14 Thread XenoAmess
> 8186958: Need method to create pre-sized HashMap

XenoAmess has updated the pull request incrementally with one additional commit 
since the last revision:

  revert changes on ProcessEnvironment

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7928/files
  - new: https://git.openjdk.java.net/jdk/pull/7928/files/5603f193..5b437dab

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=7928=19
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7928=18-19

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7928.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7928/head:pull/7928

PR: https://git.openjdk.java.net/jdk/pull/7928