Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters() [v5]
On Tue, 10 May 2022 20:38:31 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8209038
>> - update to address review feedback and minor javadoc cleanup
>> - Update for getParameters()
>> - Update w/ review feedbacks
>> - 8209038: Clarify the javadoc of Cipher.getParameters()
>
> src/java.base/share/classes/javax/crypto/CipherSpi.java line 294:
>
>> 292: * values used by the underlying cipher implementation. If the
>> required
>> 293: * parameters were not supplied and can be generated by the cipher,
>> the
>> 294: * generated parameters will be returned. Otherwise, {@code null} is
>
> Minor wording nit - change "will be" to "are" to be consistent with other
> wording which uses the present tense. Same comment applies to
> `Cipher.getParameters`.
Yes, will fix the nit.
-
PR: https://git.openjdk.java.net/jdk/pull/8117
Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters() [v5]
On Mon, 9 May 2022 18:28:04 GMT, Valerie Peng wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to broaden this to accommodate more
>> scenarios such as when null can be returned.
>> The rest are minor things like add {@code } to class name and null, and
>> remove redundant ".".
>>
>> Will file CSR after the review is close to being wrapped up.
>> Thanks~
>
> Valerie Peng has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8209038
> - update to address review feedback and minor javadoc cleanup
> - Update for getParameters()
> - Update w/ review feedbacks
> - 8209038: Clarify the javadoc of Cipher.getParameters()
Marked as reviewed by mullan (Reviewer).
src/java.base/share/classes/javax/crypto/CipherSpi.java line 294:
> 292: * values used by the underlying cipher implementation. If the
> required
> 293: * parameters were not supplied and can be generated by the cipher,
> the
> 294: * generated parameters will be returned. Otherwise, {@code null} is
Minor wording nit - change "will be" to "are" to be consistent with other
wording which uses the present tense. Same comment applies to
`Cipher.getParameters`.
-
PR: https://git.openjdk.java.net/jdk/pull/8117
Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters() [v5]
On Mon, 9 May 2022 18:28:04 GMT, Valerie Peng wrote:
>> Anyone can help review this javadoc update? The main change is the wording
>> for the method javadoc of
>> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
>> is somewhat restrictive and request is to broaden this to accommodate more
>> scenarios such as when null can be returned.
>> The rest are minor things like add {@code } to class name and null, and
>> remove redundant ".".
>>
>> Will file CSR after the review is close to being wrapped up.
>> Thanks~
>
> Valerie Peng has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8209038
> - update to address review feedback and minor javadoc cleanup
> - Update for getParameters()
> - Update w/ review feedbacks
> - 8209038: Clarify the javadoc of Cipher.getParameters()
Marked as reviewed by weijun (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8117
Re: RFR: 8209038: Clarify the javadoc of Cipher.getParameters() [v5]
> Anyone can help review this javadoc update? The main change is the wording
> for the method javadoc of
> Cipher.getParameters()/CipherSpi.engineGetParameters(). The original wording
> is somewhat restrictive and request is to broaden this to accommodate more
> scenarios such as when null can be returned.
> The rest are minor things like add {@code } to class name and null, and
> remove redundant ".".
>
> Will file CSR after the review is close to being wrapped up.
> Thanks~
Valerie Peng has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains five additional commits since
the last revision:
- Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8209038
- update to address review feedback and minor javadoc cleanup
- Update for getParameters()
- Update w/ review feedbacks
- 8209038: Clarify the javadoc of Cipher.getParameters()
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8117/files
- new: https://git.openjdk.java.net/jdk/pull/8117/files/77e8fa0d..f9727edf
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk=8117=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk=8117=03-04
Stats: 313143 lines in 4579 files changed: 242497 ins; 21053 del; 49593 mod
Patch: https://git.openjdk.java.net/jdk/pull/8117.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8117/head:pull/8117
PR: https://git.openjdk.java.net/jdk/pull/8117
