Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v8]
On Wed, 30 Mar 2022 14:40:00 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed the PSSParameterSpec javadoc link to show arguments.
>
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 105:
>
>> 103: * standard for more details. Thus, it is recommended to
>> create
>> 104: * a new {@code PSSParameterSpec} with the desired
>> parameter values
>> 105: * using
>
> s/using/using the/
Yes, thanks. Need to re-read the whole sentence again even with minor changes...
> src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 174:
>
>> 172: * https://tools.ietf.org/rfc/rfc8017.txt";>PKCS#1
>> v2.2
>> 173: * standard for more details. Thus, it is recommended to
>> explicitly
>> 174: * specify all desired parameter values with
>
> s/with/with the/
Yes.
-
PR: https://git.openjdk.java.net/jdk/pull/7913
Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v8]
On Tue, 29 Mar 2022 22:47:21 GMT, Valerie Peng wrote:
>> Can someone help review this update to the PSSParameterSpec class regarding
>> the constructor with int argument and the DEFAULT static field? Just added
>> @Deprecate javadoc tag and caution about their usage as suggested in the bug
>> record.
>>
>> A CSR will be filed once the wording changes are reviewed.
>>
>> Thanks,
>> Valerie
>
> Valerie Peng has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changed the PSSParameterSpec javadoc link to show arguments.
Marked as reviewed by mullan (Reviewer).
src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 105:
> 103: * standard for more details. Thus, it is recommended to
> create
> 104: * a new {@code PSSParameterSpec} with the desired parameter
> values
> 105: * using
s/using/using the/
src/java.base/share/classes/java/security/spec/PSSParameterSpec.java line 174:
> 172: * https://tools.ietf.org/rfc/rfc8017.txt";>PKCS#1
> v2.2
> 173: * standard for more details. Thus, it is recommended to
> explicitly
> 174: * specify all desired parameter values with
s/with/with the/
-
PR: https://git.openjdk.java.net/jdk/pull/7913
Re: RFR: 8254935: Deprecate the PSSParameterSpec(int) constructor [v8]
> Can someone help review this update to the PSSParameterSpec class regarding > the constructor with int argument and the DEFAULT static field? Just added > @Deprecate javadoc tag and caution about their usage as suggested in the bug > record. > > A CSR will be filed once the wording changes are reviewed. > > Thanks, > Valerie Valerie Peng has updated the pull request incrementally with one additional commit since the last revision: Changed the PSSParameterSpec javadoc link to show arguments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7913/files - new: https://git.openjdk.java.net/jdk/pull/7913/files/db4dddb1..26e31a64 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7913&range=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7913&range=06-07 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/7913.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7913/head:pull/7913 PR: https://git.openjdk.java.net/jdk/pull/7913
