Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-24 Thread Kevin Rushforth
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath  wrote:

>> I would like to submit AES-GCM optimization for x86_64 architectures 
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES 
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
>
> Smita Kamath has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
> are not duplicated

Checking to see if the bot is awake (it should reject my attempt).

-

PR: https://git.openjdk.java.net/jdk/pull/4019


Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-24 Thread Smita Kamath
On Mon, 23 Aug 2021 20:04:00 GMT, Anthony Scarpino  
wrote:

>> Smita Kamath has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
>> are not duplicated
>
> Tier 1-3 passed on linux-x64, windows-x64, macosx-x64, linux-aarch64

@ascarpino Looks like AES-GCM is ready to be integrated. Can you sponsor this 
patch? Thank you.

-

PR: https://git.openjdk.java.net/jdk/pull/4019


Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-24 Thread Vladimir Kozlov
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath  wrote:

>> I would like to submit AES-GCM optimization for x86_64 architectures 
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES 
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
>
> Smita Kamath has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
> are not duplicated

Yes, my testing during weekend passed too.
Changes are good for integration.

-

PR: https://git.openjdk.java.net/jdk/pull/4019


Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-23 Thread Anthony Scarpino
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath  wrote:

>> I would like to submit AES-GCM optimization for x86_64 architectures 
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES 
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
>
> Smita Kamath has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
> are not duplicated

Tier 1-3 passed on linux-x64, windows-x64, macosx-x64, linux-aarch64

-

PR: https://git.openjdk.java.net/jdk/pull/4019


Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-20 Thread Vladimir Kozlov
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath  wrote:

>> I would like to submit AES-GCM optimization for x86_64 architectures 
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES 
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
>
> Smita Kamath has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
> are not duplicated

Good.

I will test it.

-

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4019


Re: RFR: 8267125: AES Galois CounterMode (GCM) interleaved implementation using AVX512 + VAES instructions [v12]

2021-08-20 Thread Smita Kamath
> I would like to submit AES-GCM optimization for x86_64 architectures 
> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES 
> and GHASH operations.
> Performance gain of ~1.5x - 2x for message sizes 8k and above.

Smita Kamath has updated the pull request incrementally with one additional 
commit since the last revision:

  changes to make sure that ghash_long_swap_mask and counter_mask_addr calls 
are not duplicated

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4019/files
  - new: https://git.openjdk.java.net/jdk/pull/4019/files/94e46aae..c31bfe9a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=4019=11
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4019=10-11

  Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4019.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4019/head:pull/4019

PR: https://git.openjdk.java.net/jdk/pull/4019