Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]
On Wed, 12 Jan 2022 07:29:04 GMT, John Jiang wrote: >> In class `sun.security.ec.ECDHKeyAgreement`, the last `mod()` in the below >> line looks redundant, >> >> BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); >> >> I think this tiny change just be a code cleanup, so no test for it and label >> `noreg-cleanup` is added for this JBS issue. > > John Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > update copyright notes Marked as reviewed by xuelei (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7042
Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]
On Wed, 12 Jan 2022 07:29:04 GMT, John Jiang wrote: >> In class `sun.security.ec.ECDHKeyAgreement`, the last `mod()` in the below >> line looks redundant, >> >> BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); >> >> I think this tiny change just be a code cleanup, so no test for it and label >> `noreg-cleanup` is added for this JBS issue. > > John Jiang has updated the pull request incrementally with one additional > commit since the last revision: > > update copyright notes Good catch. Looks good to me. Thanks. - Marked as reviewed by weijun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7042
Re: RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement [v2]
> In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the > below line looks redundant, > > BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); John Jiang has updated the pull request incrementally with one additional commit since the last revision: update copyright notes - Changes: - all: https://git.openjdk.java.net/jdk/pull/7042/files - new: https://git.openjdk.java.net/jdk/pull/7042/files/4b44997f..6504ac3d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7042=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7042=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7042.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7042/head:pull/7042 PR: https://git.openjdk.java.net/jdk/pull/7042
RFR: 8279903: Redundant modulo operation in ECDHKeyAgreement
In class `sun.security.ec.ECDHKeyAgreement.java`, the last `mod()` in the below line looks redundant, BigInteger lhs = y.modPow(BigInteger.valueOf(2), p).mod(p); - Commit messages: - 8279903: Redundant modulo operation in ECDHKeyAgreement Changes: https://git.openjdk.java.net/jdk/pull/7042/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7042=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279903 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7042.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7042/head:pull/7042 PR: https://git.openjdk.java.net/jdk/pull/7042
