Re: RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Mandy Chung 

> On Dec 10, 2015, at 7:56 AM, Chris Hegarty  wrote:
> 
> sun.misc.HexDumpEncoder is an internal private API that is used almost
> exclusively by the security library code. It should be moved out of sun.misc
> and into a package more appropriate to its use, sun.security.util.
> 
> HexDumpEncoder extends CharacterEncoder, which is slated for later
> removal, so the minimal implementation was copied in-place ( no new
> code ).
> 
> http://cr.openjdk.java.net/~chegar/8144995/00/webrev/

Looks okay.

Mandy

Re: RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Paul Sandoz 
Looks ok to me,
Paul.

> On 10 Dec 2015, at 16:56, Chris Hegarty  wrote:
> 
> sun.misc.HexDumpEncoder is an internal private API that is used almost
> exclusively by the security library code. It should be moved out of sun.misc
> and into a package more appropriate to its use, sun.security.util.
> 
> HexDumpEncoder extends CharacterEncoder, which is slated for later
> removal, so the minimal implementation was copied in-place ( no new
> code ).
> 
> http://cr.openjdk.java.net/~chegar/8144995/00/webrev/
> 
> -Chris.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8144995



signature.asc
Description: Message signed with OpenPGP using GPGMail

RFR [9] 8144995: Move sun.misc.HexDumpEncoder to sun.security.util

2015-12-10 Thread Chris Hegarty 
sun.misc.HexDumpEncoder is an internal private API that is used almost
exclusively by the security library code. It should be moved out of sun.misc
and into a package more appropriate to its use, sun.security.util.

HexDumpEncoder extends CharacterEncoder, which is slated for later
removal, so the minimal implementation was copied in-place ( no new
code ).

http://cr.openjdk.java.net/~chegar/8144995/00/webrev/

-Chris.

[1] https://bugs.openjdk.java.net/browse/JDK-8144995