Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-08 Thread Jamil Nimeh 

On 08/08/2014 01:58 AM, Florian Weimer wrote:

On 08/07/2014 11:03 PM, Jamil Nimeh wrote:

Hello all,

This is just a quick broken-link fix for SecureRandom's javadoc.

http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01


You could link to the HTML version of the RFC instead:

  

It's nice because it has a link to errata and updating RFCs.
Personally I prefer tools.ietf.org for the in-document linking and the 
other links you referenced, too.  I was just trying to keep things 
consistent with what was already there.  If there's no objections I'm 
happy to use the HTML version instead.


--Jamil

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-08 Thread Florian Weimer 

On 08/07/2014 11:03 PM, Jamil Nimeh wrote:

Hello all,

This is just a quick broken-link fix for SecureRandom's javadoc.

http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01


You could link to the HTML version of the RFC instead:

  

It's nice because it has a link to errata and updating RFCs.

--
Florian Weimer / Red Hat Product Security

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Bradford Wetmore 



On 8/7/2014 3:59 PM, Sean Mullan wrote:

On 08/07/2014 05:03 PM, Jamil Nimeh wrote:

Hello all,

This is just a quick broken-link fix for SecureRandom's javadoc.

http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01


The fix for the broken link looks fine. I think you should double-check
with Brad as to whether changing the RFC reference is appropriate.


Looking over the Appendix A (changes from 1750), I think this should be 
ok.  These seem to be primarily additional suggestions/caveats, not 
requirements.


Brad

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Sean Mullan 

On 08/07/2014 05:03 PM, Jamil Nimeh wrote:

Hello all,

This is just a quick broken-link fix for SecureRandom's javadoc.

http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01


The fix for the broken link looks fine. I think you should double-check 
with Brad as to whether changing the RFC reference is appropriate.


--Sean

Re: RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Xuelei Fan 
Looks fine to me.

Thanks,
Xuelei

On 8/8/2014 5:03 AM, Jamil Nimeh wrote:
> Hello all,
> 
> This is just a quick broken-link fix for SecureRandom's javadoc.
> 
> http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01
> 
> Thanks,
> --Jamil

RFR 8054366: Broken link in SecureRandom.html

2014-08-07 Thread Jamil Nimeh 

Hello all,

This is just a quick broken-link fix for SecureRandom's javadoc.

http://cr.openjdk.java.net/~ascarpino/8054366/webrev.01

Thanks,
--Jamil