RFR 8244674: Third-party code version check
Please take a review at https://cr.openjdk.java.net/~weijun/8244674/webrev.00 I've consolidated 2 old tests into one and added a new case. Thanks, Max
Re: RFR 8244674: Third-party code version check
Sorry, send the wrong reply. Please ignore this mail. > On May 11, 2020, at 10:50 AM, Weijun Wang wrote: > > Can you update the existing TimeStampCheck test to use this class? I know > that test can simulate some error conditions. Maybe you can add one or more > virtual methods in this class so TimeStampCheck can override them. > > getDefaultSigAlgo(): Please call AlgorithmId.getDefaultSigAlgForKey() > instead. It will be enhanced to support new algorithm. > > Param: How about making it a JDK 14 record? > > Thanks, > Max > > >> On May 9, 2020, at 11:29 AM, Weijun Wang wrote: >> >> Please take a review at >> >> https://cr.openjdk.java.net/~weijun/8244674/webrev.00 >> >> I've consolidated 2 old tests into one and added a new case. >> >> Thanks, >> Max >> >
Re: RFR 8244674: Third-party code version check
Can you update the existing TimeStampCheck test to use this class? I know that test can simulate some error conditions. Maybe you can add one or more virtual methods in this class so TimeStampCheck can override them. getDefaultSigAlgo(): Please call AlgorithmId.getDefaultSigAlgForKey() instead. It will be enhanced to support new algorithm. Param: How about making it a JDK 14 record? Thanks, Max > On May 9, 2020, at 11:29 AM, Weijun Wang wrote: > > Please take a review at > > https://cr.openjdk.java.net/~weijun/8244674/webrev.00 > > I've consolidated 2 old tests into one and added a new case. > > Thanks, > Max >
Re: RFR 8244674: Third-party code version check
Looks good to me. --Sean On 5/8/20 11:29 PM, Weijun Wang wrote: Please take a review at https://cr.openjdk.java.net/~weijun/8244674/webrev.00 I've consolidated 2 old tests into one and added a new case. Thanks, Max
