Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Sat, 16 Jan 2021 00:48:43 GMT, Naoto Sato wrote:
>> Actually I was correcting the L217, changed {) -> {}. But 2 days ago,
>> Jonathan Gibbons fixed it in another commit 6bb6093. I found his fix after
>> running the merge. Looks both of us forgot to update the copyright year. Any
>> suggestion?
>> doclet.help.systemProperties.body=\
>> The {0} page lists references to system properties.
>
> I believe your PR still contains the fix to add the newline at the end of the
> file (at L518). So I think you can simply change the copyright year in
> `standard.properties` file.
Thx! Fixed the copyright year for this file.
-
PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Fri, 15 Jan 2021 01:59:07 GMT, Leo Jiang wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
>> line 518:
>>
>>> 516: doclet.footer_specified=\
>>> 517: The -footer option is no longer supported and will be ignored.\n\
>>> 518: It may be removed in a future release.
>>
>> I believe this is to fix no newline at the end (unrelated to l10n changes).
>> Do we need to change the copyright year for this?
>
> Actually I was correcting the L217, changed {) -> {}. But 2 days ago,
> Jonathan Gibbons fixed it in another commit 6bb6093. I found his fix after
> running the merge. Looks both of us forgot to update the copyright year. Any
> suggestion?
> doclet.help.systemProperties.body=\
> The {0} page lists references to system properties.
I believe your PR still contains the fix to add the newline at the end of the
file (at L518). So I think you can simply change the copyright year in
`standard.properties` file.
-
PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Thu, 14 Jan 2021 17:19:11 GMT, Naoto Sato wrote:
>> Leo Jiang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> since the last revision:
>>
>> - Merge branch 'master' into msgdrop
>> - JDK-8259732: JDK 16 L10n resource file update - msg drop 10
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
> line 518:
>
>> 516: doclet.footer_specified=\
>> 517: The -footer option is no longer supported and will be ignored.\n\
>> 518: It may be removed in a future release.
>
> I believe this is to fix no newline at the end (unrelated to l10n changes).
> Do we need to change the copyright year for this?
Actually I was correcting the L217, changed {) -> {}. But 2 days ago, Jonathan
Gibbons fixed it in another commit 6bb6093. I found his fix after running the
merge. Looks both of us forgot to update the copyright year. Any suggestion?
doclet.help.systemProperties.body=\
The {0} page lists references to system properties.
-
PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Thu, 14 Jan 2021 14:27:25 GMT, Leo Jiang wrote: >> This is the changes for JDK 16 msg drop 10. > > Leo Jiang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains two additional commits since > the last revision: > > - Merge branch 'master' into msgdrop > - JDK-8259732: JDK 16 L10n resource file update - msg drop 10 src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 518: > 516: doclet.footer_specified=\ > 517: The -footer option is no longer supported and will be ignored.\n\ > 518: It may be removed in a future release. I believe this is to fix no newline at the end (unrelated to l10n changes). Do we need to change the copyright year for this? - PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
> This is the changes for JDK 16 msg drop 10. Leo Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into msgdrop - JDK-8259732: JDK 16 L10n resource file update - msg drop 10 - Changes: - all: https://git.openjdk.java.net/jdk16/pull/123/files - new: https://git.openjdk.java.net/jdk16/pull/123/files/230117b4..d72f444a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk16=123=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk16=123=00-01 Stats: 718 lines in 32 files changed: 616 ins; 38 del; 64 mod Patch: https://git.openjdk.java.net/jdk16/pull/123.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123 PR: https://git.openjdk.java.net/jdk16/pull/123
