Re: RFR: 8253635: Implement toString() for SSLEngineImpl [v2]

2021-01-12 Thread Bradford Wetmore
On Tue, 12 Jan 2021 17:19:17 GMT, Xue-Lei Andrew Fan  wrote:

>> The SSLSocketImpl and SSLEngineImpl implementation does not override the 
>> toString() method.  The old code did.  BTW, I also made a few code clean up 
>> in the SSLSocketImpl.java.
>> 
>> Code clean up, trivial update, no new regression test.
>
> Xue-Lei Andrew Fan has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - Merge master
>  - missing a white space
>  - 8253635: Implement toString() for SSLEngineImpl

Marked as reviewed by wetmore (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/2019


Re: RFR: 8253635: Implement toString() for SSLEngineImpl [v2]

2021-01-12 Thread Xue-Lei Andrew Fan
> The SSLSocketImpl and SSLEngineImpl implementation does not override the 
> toString() method.  The old code did.  BTW, I also made a few code clean up 
> in the SSLSocketImpl.java.
> 
> Code clean up, trivial update, no new regression test.

Xue-Lei Andrew Fan has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains three additional 
commits since the last revision:

 - Merge master
 - missing a white space
 - 8253635: Implement toString() for SSLEngineImpl

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2019/files
  - new: https://git.openjdk.java.net/jdk/pull/2019/files/78e12edf..6600ee32

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=2019=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2019=00-01

  Stats: 8715 lines in 333 files changed: 5636 ins; 1731 del; 1348 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2019.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2019/head:pull/2019

PR: https://git.openjdk.java.net/jdk/pull/2019