Re: RFR: 8257722: Improve "keytool -printcert -jarfile" output [v4]

2021-10-28 Thread Hai-May Chao 
On Thu, 28 Oct 2021 21:13:40 GMT, Hai-May Chao  wrote:

>> This change does a few improvements to the output of `keytool -printcert 
>> -jarfile` command to help readability and diagnosis.
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update while block code

It'd be worry-free by keeping the same ordering. Changed as suggested. Thanks 
for the review!

-

PR: https://git.openjdk.java.net/jdk/pull/6126

Re: RFR: 8257722: Improve "keytool -printcert -jarfile" output [v4]

2021-10-28 Thread Weijun Wang 
On Thu, 28 Oct 2021 21:13:40 GMT, Hai-May Chao  wrote:

>> This change does a few improvements to the output of `keytool -printcert 
>> -jarfile` command to help readability and diagnosis.
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update while block code

Looks fine now.

I wonder if the order of signers in the set matters. It's possible that one 
signer appears first in the result of `getCodeSigners()` but because `HashSet` 
maintains no order it becomes the second. If you are also worried about this, 
you can make `ss` a `LinkedHashSet`.

-

Marked as reviewed by weijun (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6126

Re: RFR: 8257722: Improve "keytool -printcert -jarfile" output [v4]

2021-10-28 Thread Hai-May Chao 
> This change does a few improvements to the output of `keytool -printcert 
> -jarfile` command to help readability and diagnosis.

Hai-May Chao has updated the pull request incrementally with one additional 
commit since the last revision:

  Update while block code

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6126/files
  - new: https://git.openjdk.java.net/jdk/pull/6126/files/85b3cf46..1b5840b8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=6126=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=6126=02-03

  Stats: 82 lines in 1 file changed: 33 ins; 38 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6126.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6126/head:pull/6126

PR: https://git.openjdk.java.net/jdk/pull/6126