Re: RFR: 8274809: Update java.base classes to use try-with-resources [v3]

2021-10-06 Thread Bradford Wetmore 
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov 
 wrote:

>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8274809: Update java.base classes to use try-with-resources
>   update copyright year

src/java.base/share/classes/sun/net/NetProperties.java line 72:

> 70: fname = f.getCanonicalPath();
> 71: try (FileInputStream in = new FileInputStream(fname)) {
> 72: BufferedInputStream bin = new BufferedInputStream(in);

Shouldn't this have a multiple resource block in the try-with block here:  

try (FileInputStream in = new FileInputStream(fname);
BufferedInputStream bin = new BufferedInputStream(in)) {
props.land(bin);
}

-

PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v3]

2021-10-06 Thread Bradford Wetmore 
On Wed, 6 Oct 2021 18:47:26 GMT, Andrey Turbanov 
 wrote:

>> 8274809: Update java.base classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8274809: Update java.base classes to use try-with-resources
>   update copyright year

Greater than 80 chars comment missing in latest changeset.

-

PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v3]

2021-10-06 Thread Bradford Wetmore 
On Wed, 6 Oct 2021 16:07:12 GMT, Bradford Wetmore  wrote:

>> Andrey Turbanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8274809: Update java.base classes to use try-with-resources
>>   update copyright year
>
> src/java.base/share/classes/sun/security/util/PolicyUtil.java line 156:
> 
>> 154: }
>> 155: 
>> 156: try (InputStream inStream = new 
>> BufferedInputStream(getInputStream(keyStoreUrl))) {
> 
> Same comment as above.

Looks like it's still > 80 chars

-

PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v3]

2021-10-06 Thread Andrey Turbanov 
> 8274809: Update java.base classes to use try-with-resources

Andrey Turbanov has updated the pull request incrementally with one additional 
commit since the last revision:

  8274809: Update java.base classes to use try-with-resources
  update copyright year

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5818/files
  - new: https://git.openjdk.java.net/jdk/pull/5818/files/78893df9..423c3069

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5818=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5818=01-02

  Stats: 5 lines in 4 files changed: 1 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5818.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5818/head:pull/5818

PR: https://git.openjdk.java.net/jdk/pull/5818

Re: RFR: 8274809: Update java.base classes to use try-with-resources [v3]

2021-10-06 Thread Andrey Turbanov 
On Wed, 6 Oct 2021 16:11:25 GMT, Bradford Wetmore  wrote:

>Files like HttpTimestamper need the copyright dates updated to 2021.

Updated

-

PR: https://git.openjdk.java.net/jdk/pull/5818