Re: RFR: 8277881 Missing SessionID in TLS1.3 resumption in compatibility mode [v2]
On Thu, 23 Dec 2021 21:47:53 GMT, Daniel Jeliński wrote: >> All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID >> field. Currently TLS1.3 session resumptions are sending empty session ID. >> This patch fixes that problem. >> >> All jdk_core tests passed. The newly added check passes with the patch, >> fails without it. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year Approved - Marked as reviewed by ascarpino (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6583
Re: RFR: 8277881 Missing SessionID in TLS1.3 resumption in compatibility mode [v2]
On Tue, 21 Dec 2021 21:25:53 GMT, Anthony Scarpino wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year > > Please add " 2021," to the copyright of ResumeTLS13withSNI.java. > I have run all the tests and they pass. > > Have you run this fix on your customer's setup or similar setup to confirm > this fixed their problem? Thanks @ascarpino for reviewing. Copyright year updated. Yes I confirmed that the updated version fixes the problem. Interestingly, aside from the empty SessionID there were no other differences between the initial and resumption ClientHello messages, i.e. pre_shared_key extension was absent in both. I suppose the server didn't send any NewSessionTicket, but didn't investigate it further. - PR: https://git.openjdk.java.net/jdk/pull/6583
Re: RFR: 8277881 Missing SessionID in TLS1.3 resumption in compatibility mode [v2]
> All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID > field. Currently TLS1.3 session resumptions are sending empty session ID. > This patch fixes that problem. > > All jdk_core tests passed. The newly added check passes with the patch, fails > without it. Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/6583/files - new: https://git.openjdk.java.net/jdk/pull/6583/files/a01a3070..f62fb604 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6583&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6583&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6583.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6583/head:pull/6583 PR: https://git.openjdk.java.net/jdk/pull/6583
Re: RFR: 8277881 Missing SessionID in TLS1.3 resumption in compatibility mode
On Mon, 29 Nov 2021 08:42:22 GMT, Daniel Jeliński wrote: > All TLS 1.3 handshakes in compatibility mode must send a non-empty SessionID > field. Currently TLS1.3 session resumptions are sending empty session ID. > This patch fixes that problem. > > All jdk_core tests passed. The newly added check passes with the patch, fails > without it. Please add " 2021," to the copyright of ResumeTLS13withSNI.java. I have run all the tests and they pass. Have you run this fix on your customer's setup or similar setup to confirm this fixed their problem? - Changes requested by ascarpino (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6583
