Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Max comments Brad contacted Oracle's copyright person, and yes, we do need an Oracle copyright. Thanks for noticing this. - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
On Thu, 5 May 2022 23:24:12 GMT, Mark Powers wrote: > The IBM files say this at the top: DO NOT ALTER OR REMOVE COPYRIGHT NOTICES > OR THIS FILE HEADER That's the standard copyright notice. Let's check with Oracle's copyright person... - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Max comments The IBM files say this at the top: DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Max comments Do the various IBM files need a copyright date update? - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > Max comments OK. But let's wait until next week so loom can be integrated smoothly. I doubt loom will touch any of the files here but this commit is still quite big. - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v5]
> https://bugs.openjdk.java.net/browse/JDK-8284688 > > [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the > umbrella bug for this bug. The changes were too large for a single code > review, so it was decided to split into smaller chunks. This is one such > chunk: > > open/src/java.security.jgss/share/classes/javax/security > open/src/java.security.jgss/share/classes/org/ietf > open/src/java.security.jgss/share/classes/sun/security Mark Powers has updated the pull request incrementally with one additional commit since the last revision: Max comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/7746/files - new: https://git.openjdk.java.net/jdk/pull/7746/files/5ce46ffb..15769b15 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7746=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7746=03-04 Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7746.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7746/head:pull/7746 PR: https://git.openjdk.java.net/jdk/pull/7746
