Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v7]
On Wed, 18 May 2022 04:47:13 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 18 commits: > > - Merge > - reverse IntelliJ unboxing suggestion > - Merge > - Merge > - Merge > - Brad comments > - Max comments > - sixth iteration > - Merge > - fifth iteration > - ... and 8 more: > https://git.openjdk.java.net/jdk/compare/2ed75be6...30ca27a2 Mach5 tests all passed in spite of some failing pre-submit tests. bash ./jib.sh mach5 -- remote-build-and-test --email mark.pow...@oracle.com -b linux-x64,windows-x64,macosx-x64 --job tier1,tier2 - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v7]
On Wed, 18 May 2022 04:47:13 GMT, Mark Powers wrote: >> https://bugs.openjdk.java.net/browse/JDK-8284688 >> >> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the >> umbrella bug for this bug. The changes were too large for a single code >> review, so it was decided to split into smaller chunks. This is one such >> chunk: >> >> open/src/java.security.jgss/share/classes/javax/security >> open/src/java.security.jgss/share/classes/org/ietf >> open/src/java.security.jgss/share/classes/sun/security > > Mark Powers has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 18 commits: > > - Merge > - reverse IntelliJ unboxing suggestion > - Merge > - Merge > - Merge > - Brad comments > - Max comments > - sixth iteration > - Merge > - fifth iteration > - ... and 8 more: > https://git.openjdk.java.net/jdk/compare/2ed75be6...30ca27a2 IntelliJ complains that unboxed values should be boxed, e.g. `Integer.valueOf()` should be changed to `Integer`. After some discussion, it has been decided to ignore IntelliJ's complaints and leave the code as written. To box or unbox is a matter of personal preference. The generated byte code is the same either way. - PR: https://git.openjdk.java.net/jdk/pull/7746
Re: RFR: JDK-8284688 Minor cleanup could be done in java.security.jgss [v7]
> https://bugs.openjdk.java.net/browse/JDK-8284688 > > [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the > umbrella bug for this bug. The changes were too large for a single code > review, so it was decided to split into smaller chunks. This is one such > chunk: > > open/src/java.security.jgss/share/classes/javax/security > open/src/java.security.jgss/share/classes/org/ietf > open/src/java.security.jgss/share/classes/sun/security Mark Powers has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge - reverse IntelliJ unboxing suggestion - Merge - Merge - Merge - Brad comments - Max comments - sixth iteration - Merge - fifth iteration - ... and 8 more: https://git.openjdk.java.net/jdk/compare/2ed75be6...30ca27a2 - Changes: https://git.openjdk.java.net/jdk/pull/7746/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7746&range=06 Stats: 894 lines in 72 files changed: 96 ins; 193 del; 605 mod Patch: https://git.openjdk.java.net/jdk/pull/7746.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7746/head:pull/7746 PR: https://git.openjdk.java.net/jdk/pull/7746
