Re: RFR 8074835/8074836: Resolve disabled warnings for libj2gss/libosxkrb5

2015-03-16 Thread Wang Weijun 

> On Mar 16, 2015, at 22:04, Magnus Ihse Bursie  
> wrote:
> 
> On 2015-03-16 04:12, Wang Weijun wrote:
>> Hi All
>> 
>> Please review the change at
>> 
>>http://cr.openjdk.java.net/~weijun/8074836/webrev.00/
>> 
>> Thanks
>> Max
>> 
> 
> Looks good to me. Thanks for fixing this.
> 
> I'm just curious about the new deprecated-declarations warning. I didn't see 
> it when I excluded the warnings for the library in the first place. Did it 
> show up when you fixed the other warnings, or did you see it all the time? If 
> so, what compiler version are you using?

All the time.

It's in /System/Library/Frameworks/Kerberos.framework/Headers/krb5.h. All those 
"KERBEROS_APPLE_DEPRECATED("use GSS.framework")" words.

$ /usr/bin/clang -v
Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin14.1.0
Thread model: posix

--Max

> 
> /Magnus

Re: RFR 8074835/8074836: Resolve disabled warnings for libj2gss/libosxkrb5

2015-03-16 Thread Magnus Ihse Bursie 

On 2015-03-16 04:12, Wang Weijun wrote:

Hi All

Please review the change at

http://cr.openjdk.java.net/~weijun/8074836/webrev.00/

Thanks
Max



Looks good to me. Thanks for fixing this.

I'm just curious about the new deprecated-declarations warning. I didn't 
see it when I excluded the warnings for the library in the first place. 
Did it show up when you fixed the other warnings, or did you see it all 
the time? If so, what compiler version are you using?


/Magnus

Re: RFR 8074835/8074836: Resolve disabled warnings for libj2gss/libosxkrb5

2015-03-16 Thread Erik Joelsson 

Looks good to me. Thanks for fixing warnings!

/Erik

On 2015-03-16 04:12, Wang Weijun wrote:

Hi All

Please review the change at

http://cr.openjdk.java.net/~weijun/8074836/webrev.00/

Thanks
Max