Re: RFR 8245520: Provide a way to add CA certificate to cacerts during test run
Move this patch to sun/security/util/module_patch Webrev: http://cr.openjdk.java.net/~jjiang/8245520/webrev.01/ Best regards, John Jiang On 2020/6/11 15:55, sha.ji...@oracle.com wrote: Hi Max, Thanks for your info! It looks that patch for java.base:sun.security.util.FilePaths.java is used for specifying an alternative cacerts file. But my requirement is updating the existing cacerts with given CAs. Both of the functions are useful. I'll submit a new webrev after the fix for JDK-8244148 is pushed. I also have some comments about Hai-May's webrev. Best regards, John Jiang On 2020/6/11 11:25, Weijun Wang wrote: Hai-May has a similar function as a by-product in https://cr.openjdk.java.net/~hchao/8244148/webrev.02/ See FilePaths.java and MyOwnCacerts.java for the detail. Her code change is in code review now. Please coordinate with her on how to get this done nicely. Thanks, Max On Jun 11, 2020, at 9:39 AM, sha.ji...@oracle.com wrote: Hi, This patch contains a patched version for class sun.security.util.AnchorCertificates. It allows to add CAs to cacerts at runtime for testing purpose. Webrev: http://cr.openjdk.java.net/~jjiang/8245520/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8245520 Best regards, John Jiang
Re: RFR 8245520: Provide a way to add CA certificate to cacerts during test run
Hi Max, Thanks for your info! It looks that patch for java.base:sun.security.util.FilePaths.java is used for specifying an alternative cacerts file. But my requirement is updating the existing cacerts with given CAs. Both of the functions are useful. I'll submit a new webrev after the fix for JDK-8244148 is pushed. I also have some comments about Hai-May's webrev. Best regards, John Jiang On 2020/6/11 11:25, Weijun Wang wrote: Hai-May has a similar function as a by-product in https://cr.openjdk.java.net/~hchao/8244148/webrev.02/ See FilePaths.java and MyOwnCacerts.java for the detail. Her code change is in code review now. Please coordinate with her on how to get this done nicely. Thanks, Max On Jun 11, 2020, at 9:39 AM, sha.ji...@oracle.com wrote: Hi, This patch contains a patched version for class sun.security.util.AnchorCertificates. It allows to add CAs to cacerts at runtime for testing purpose. Webrev: http://cr.openjdk.java.net/~jjiang/8245520/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8245520 Best regards, John Jiang
Re: RFR 8245520: Provide a way to add CA certificate to cacerts during test run
Hai-May has a similar function as a by-product in https://cr.openjdk.java.net/~hchao/8244148/webrev.02/ See FilePaths.java and MyOwnCacerts.java for the detail. Her code change is in code review now. Please coordinate with her on how to get this done nicely. Thanks, Max > On Jun 11, 2020, at 9:39 AM, sha.ji...@oracle.com wrote: > > Hi, > This patch contains a patched version for class > sun.security.util.AnchorCertificates. > It allows to add CAs to cacerts at runtime for testing purpose. > > Webrev: http://cr.openjdk.java.net/~jjiang/8245520/webrev.00/ > Issue: https://bugs.openjdk.java.net/browse/JDK-8245520 > > Best regards, > John Jiang >
