Re: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-10 Thread Sean Mullan 

Looks fine too.

--Sean

On 07/10/2013 03:42 AM, Weijun Wang wrote:

Hi Sean

Can you take a look at the webrev for jdk7u-dev. The only difference is
that in 7u there is no check for output == null at all so an NPE is thrown.

http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/

Thanks
Max

On 7/9/13 8:16 PM, Sean Mullan wrote:

Looks fine.

--Sean

On 07/09/2013 03:32 AM, Weijun Wang wrote:

Hi All

An NPE was suppressed in jdk8 with a simple if. This new fix tries to
output useful info even for a null argument.

Please review the code changes at

http://cr.openjdk.java.net/~weijun/8019267/webrev.01/

The added test makes sure logging does not crash and the output is
informational.

Thanks
Max

Re: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-10 Thread Weijun Wang 

Hi Sean

Can you take a look at the webrev for jdk7u-dev. The only difference is 
that in 7u there is no check for output == null at all so an NPE is thrown.


   http://cr.openjdk.java.net/~weijun/8019267/7u-dev/webrev.00/

Thanks
Max

On 7/9/13 8:16 PM, Sean Mullan wrote:

Looks fine.

--Sean

On 07/09/2013 03:32 AM, Weijun Wang wrote:

Hi All

An NPE was suppressed in jdk8 with a simple if. This new fix tries to
output useful info even for a null argument.

Please review the code changes at

http://cr.openjdk.java.net/~weijun/8019267/webrev.01/

The added test makes sure logging does not crash and the output is
informational.

Thanks
Max

Re: Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-09 Thread Sean Mullan 

Looks fine.

--Sean

On 07/09/2013 03:32 AM, Weijun Wang wrote:

Hi All

An NPE was suppressed in jdk8 with a simple if. This new fix tries to
output useful info even for a null argument.

Please review the code changes at

http://cr.openjdk.java.net/~weijun/8019267/webrev.01/

The added test makes sure logging does not crash and the output is
informational.

Thanks
Max

Request for review: 8019267: NPE in AbstractSaslImpl when trace level >= FINER in KRB5

2013-07-09 Thread Weijun Wang 

Hi All

An NPE was suppressed in jdk8 with a simple if. This new fix tries to 
output useful info even for a null argument.


Please review the code changes at

   http://cr.openjdk.java.net/~weijun/8019267/webrev.01/

The added test makes sure logging does not crash and the output is 
informational.


Thanks
Max