Re: Very simple webrev.

2013-10-30 Thread Bradford Wetmore 
I'm still going to change the name of the provider, the name "test" was 
resulting in failure mode:


test failed:  some condition

which of course wasn't obvious where test was coming from.

Brad




On 10/30/2013 2:45 PM, Bradford Wetmore wrote:

*facepalm*

CR withdrawn...it must be the one in the closed repo then.  Thanks Mandy.

Brad



On 10/30/2013 2:37 PM, Mandy Chung wrote:


On 10/30/2013 2:25 PM, Bradford Wetmore wrote:


https://bugs.openjdk.java.net/browse/JDK-8027526
http://cr.openjdk.java.net/~wetmore/8027526/webrev/



   32  * @run main/othervm SignatureGetAlgorithm
   33  * @author youdwei
   34  * @run main/othervm SignatureGetAlgorithm

I think you intended to move line 32 rather than copy?  Otherwise, looks
okay.

Mandy

Re: Very simple webrev.

2013-10-30 Thread Bradford Wetmore 

*facepalm*

CR withdrawn...it must be the one in the closed repo then.  Thanks Mandy.

Brad



On 10/30/2013 2:37 PM, Mandy Chung wrote:


On 10/30/2013 2:25 PM, Bradford Wetmore wrote:


https://bugs.openjdk.java.net/browse/JDK-8027526
http://cr.openjdk.java.net/~wetmore/8027526/webrev/



   32  * @run main/othervm SignatureGetAlgorithm
   33  * @author youdwei
   34  * @run main/othervm SignatureGetAlgorithm

I think you intended to move line 32 rather than copy?  Otherwise, looks
okay.

Mandy

Re: Very simple webrev.

2013-10-30 Thread Mandy Chung 


On 10/30/2013 2:25 PM, Bradford Wetmore wrote:


https://bugs.openjdk.java.net/browse/JDK-8027526
http://cr.openjdk.java.net/~wetmore/8027526/webrev/



  32  * @run main/othervm SignatureGetAlgorithm
  33  * @author youdwei
  34  * @run main/othervm SignatureGetAlgorithm

I think you intended to move line 32 rather than copy?  Otherwise, looks 
okay.


Mandy

Re: Very simple webrev.

2013-10-30 Thread Sean Mullan 

Looks good.

--Sean

On 10/30/2013 05:25 PM, Bradford Wetmore wrote:


https://bugs.openjdk.java.net/browse/JDK-8027526
http://cr.openjdk.java.net/~wetmore/8027526/webrev/

Alan was getting some test failures, I'm 95% sure it's due to a provider
being inserted one of two tests and being run with agentvm.

According to Jon Gibbons, agentvm does not reset the Security Providers.

I'm putting this one open change back, and will be filing a bug for the
remainder.

Brad

Very simple webrev.

2013-10-30 Thread Bradford Wetmore 


https://bugs.openjdk.java.net/browse/JDK-8027526
http://cr.openjdk.java.net/~wetmore/8027526/webrev/

Alan was getting some test failures, I'm 95% sure it's due to a provider 
being inserted one of two tests and being run with agentvm.


According to Jon Gibbons, agentvm does not reset the Security Providers.

I'm putting this one open change back, and will be filing a bug for the 
remainder.


Brad