Re: [9] RFR: 8166530: sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java fails intermittently

[Chris Hegarty]

> On 7 Oct 2016, at 21:33, Artem Smotrakov  wrote:
> 
> Hello,
> 
> Please review the patch below for 
> sun/net/www/protocol/https/HttpsClient/ProxyAuthTest.java test.
> 
> The test has been observed to fail intermittently, but the failure is not 
> reproducible standalone. The patch updates the test to follow the approach 
> from SSLSocketSample.java
> 
> http://hg.openjdk.java.net/jdk9/dev/jdk/file/1f044f413e6c/test/javax/net/ssl/templates/SSLSocketSample.java
> 
> I merged OriginServer.java to ProxyAuthTest.java since only this test uses 
> that file. I also added a couple of new common methods to SSLTest.java. They 
> are not used by ProxyAuthTest.java, but can be useful in other tests.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8166530
> Webrev: http://cr.openjdk.java.net/~asmotrak/8166530/webrev.00/

From my point of view, this looks ok.

-Chris.

RFR 8167647: Copy-and-paste bug in javax.security.auth.kerberos.KerberosTicket.toString()

[Wang Weijun]

Please take a review on this change:

diff --git 
a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java 
b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
--- 
a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
+++ 
b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java

@@ -694,7 +694,7 @@
 "Proxy Ticket " + flags[PROXY_TICKET_FLAG] + "\n" +
 "Postdated Ticket " + flags[POSTDATED_TICKET_FLAG] + 
"\n" +
 "Renewable Ticket " + flags[RENEWABLE_TICKET_FLAG] + 
"\n" +

-"Initial Ticket " + flags[RENEWABLE_TICKET_FLAG] + "\n" +
+"Initial Ticket " + flags[INITIAL_TICKET_FLAG] + "\n" +
 "Auth Time = " + String.valueOf(authTime) + "\n" +
 "Start Time = " + String.valueOf(startTime) + "\n" +
 "End Time = " + endTime.toString() + "\n" +

Noreg-trivial.

Thanks
Max

Re: RFR 8167647: Copy-and-paste bug in javax.security.auth.kerberos.KerberosTicket.toString()

[Xuelei Fan]

Looks fine to me.

Xuelei

> On 19 Oct 2016, at 9:26 AM, Wang Weijun  wrote:
> 
> Please take a review on this change:
> 
> diff --git 
> a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
>  
> b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
> --- 
> a/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
> +++ 
> b/src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosTicket.java
> @@ -694,7 +694,7 @@
> "Proxy Ticket " + flags[PROXY_TICKET_FLAG] + "\n" +
> "Postdated Ticket " + flags[POSTDATED_TICKET_FLAG] + "\n" +
> "Renewable Ticket " + flags[RENEWABLE_TICKET_FLAG] + "\n" +
> -"Initial Ticket " + flags[RENEWABLE_TICKET_FLAG] + "\n" +
> +"Initial Ticket " + flags[INITIAL_TICKET_FLAG] + "\n" +
> "Auth Time = " + String.valueOf(authTime) + "\n" +
> "Start Time = " + String.valueOf(startTime) + "\n" +
> "End Time = " + endTime.toString() + "\n" +
> 
> Noreg-trivial.
> 
> Thanks
> Max
>