Re: RFR: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready

2023-07-17 Thread Jamil Nimeh
On Mon, 17 Jul 2023 17:45:56 GMT, Matthew Donovan  wrote:

> In this PR, i raised the client timeout from 5 to 60 seconds. I considered 
> refactoring the SimpleOSCPServer class a little but ultimately, the client 
> needs to just wait until the server is ready or a time-out is reached. 
> Alternately, we can wait indefinitely and let the test time out but that 
> results in holding onto resources for too long.
> 
> Thanks

I'm good with this.

-

Marked as reviewed by jnimeh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14905#pullrequestreview-1533717455


RFR: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready

2023-07-17 Thread Matthew Donovan
In this PR, i raised the client timeout from 5 to 60 seconds. I considered 
refactoring the SimpleOSCPServer class a little but ultimately, the client 
needs to just wait until the server is ready or a time-out is reached. 
Alternately, we can wait indefinitely and let the test time out but that 
results in holding onto resources for too long.

Thanks

-

Commit messages:
 - 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails 
with RuntimeException Server not ready

Changes: https://git.openjdk.org/jdk/pull/14905/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=14905=00
  Issue: https://bugs.openjdk.org/browse/JDK-8310629
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14905.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14905/head:pull/14905

PR: https://git.openjdk.org/jdk/pull/14905