Re: RFR: 8298127: HSS/LMS Signature Verification [v13]
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: > > Removed a comment line. Oops, more comments: 1. `engineSetParameter(AlgorithmParameterSpec params)` should be overridden. Existing implementations that does not require parameters (RSA and DSA) succeeds if input is null. 2. `engineGetParameters()` should be overridden and return null. - Changes requested by weijun (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13691#pullrequestreview-1426814309
Re: RFR: 8298127: HSS/LMS Signature Verification [v13]
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: > > Removed a comment line. Oops, more comments: 1. `engineSetParameter(AlgorithmParameterSpec params)` should be overridden. Existing implementations that does not require parameters (RSA and DSA) succeeds if input is null. 2. `engineGetParameters()` should be overridden and return null. - PR Comment: https://git.openjdk.org/jdk/pull/13691#issuecomment-1548063322
Re: RFR: 8298127: HSS/LMS Signature Verification [v13]
On Mon, 15 May 2023 13:44:27 GMT, Ferenc Rakoczi wrote: >> Implement support for Leighton-Micali Signatures (LMS) as described in RFC >> 8554. LMS is an approved software signing algorithm for CNSA 2.0, with >> SHA-256/192 parameters recommended. > > Ferenc Rakoczi has updated the pull request incrementally with one additional > commit since the last revision: > > Removed a comment line. src/java.base/share/classes/sun/security/util/RawKeySpec.java line 29: > 27: > 28: import java.security.spec.KeySpec; > 29: > //12345678901234567890123456789012345678901234567890123456789012345678901234567890 There is one extra line here as well. - PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1193966319
Re: RFR: 8298127: HSS/LMS Signature Verification [v13]
> Implement support for Leighton-Micali Signatures (LMS) as described in RFC > 8554. LMS is an approved software signing algorithm for CNSA 2.0, with > SHA-256/192 parameters recommended. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision: Removed a comment line. - Changes: - all: https://git.openjdk.org/jdk/pull/13691/files - new: https://git.openjdk.org/jdk/pull/13691/files/1abc1d78..3bc2a355 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13691&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13691&range=11-12 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13691.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13691/head:pull/13691 PR: https://git.openjdk.org/jdk/pull/13691
